Status Update
No update yet.
Comments
pe...@gmail.com
We're seeing a similar error in our code. Appears to be a combination of AGP 8.6.0 and Kotlin 2 needed to hit it.
private fun Intent.stripUnwantedFlags() {
// Explicitly remove the new task and clear task flags (Our browser activity is a single
// task activity and we never want to start a second task here).
flags = flags and Intent.FLAG_ACTIVITY_NEW_TASK.inv()
flags = flags and Intent.FLAG_ACTIVITY_CLEAR_TASK.inv()
// IntentReceiverActivity is started with the "excludeFromRecents" flag (set in manifest). We
// do not want to propagate this flag from the intent receiver activity to the browser.
flags = flags and Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS.inv()
}
All 3 lines then hit:
Must be one or more of: Intent.FLAG_GRANT_READ_URI_PERMISSION, Intent.FLAG_GRANT_WRITE_URI_PERMISSION, Intent.FLAG_FROM_BACKGROUND, Intent.FLAG_DEBUG_LOG_RESOLUTION, Intent.FLAG_EXCLUDE_STOPPED_PACKAGES, Intent.FLAG_INCLUDE_STOPPED_PACKAGES, Intent.FLAG_GRANT_PERSISTABLE_URI_PERMISSION, Intent.FLAG_GRANT_PREFIX_URI_PERMISSION, Intent.FLAG_ACTIVITY_MATCH_EXTERNAL, Intent.FLAG_ACTIVITY_NO_HISTORY, Intent.FLAG_ACTIVITY_SINGLE_TOP, Intent.FLAG_ACTIVITY_NEW_TASK, Intent.FLAG_ACTIVITY_MULTIPLE_TASK, Intent.FLAG_ACTIVITY_CLEAR_TOP, Intent.FLAG_ACTIVITY_FORWARD_RESULT, Intent.FLAG_ACTIVITY_PREVIOUS_IS_TOP, Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS, Intent.FLAG_ACTIVITY_BROUGHT_TO_FRONT, Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED, Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NEW_DOCUMENT, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NO_USER_ACTION, Intent.FLAG_ACTIVITY_REORDER_TO_FRONT, Intent.FLAG_ACTIVITY_NO_ANIMATION, Intent.FLAG_ACTIVITY_CLEAR_TASK, Intent.FLAG_ACTIVITY_TASK_ON_HOME, Intent.FLAG_ACTIVITY_RETAIN_IN_RECENTS, Intent.FLAG_ACTIVITY_LAUNCH_ADJACENT, Intent.FLAG_ACTIVITY_REQUIRE_NON_BROWSER, Intent.FLAG_ACTIVITY_REQUIRE_DEFAULT, Intent.FLAG_RECEIVER_REGISTERED_ONLY, Intent.FLAG_RECEIVER_REPLACE_PENDING, Intent.FLAG_RECEIVER_FOREGROUND, Intent.FLAG_RECEIVER_NO_ABORT, Intent.FLAG_RECEIVER_VISIBLE_TO_INSTANT_APPS
sg...@google.com
cl...@google.com
The initial report (
However,
cl...@google.com
Thanks for fixing! What release should we be able to verify the fix in? And is there any chance of a backport for 8.6.1?
pu...@gmail.com
Thanks for the update!
pu...@gmail.com
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Ladybug Feature Drop | 2024.2.2 Canary 2
- Android Gradle Plugin 8.8.0-alpha02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
to...@yahoo.com
The fixes for this issue are now also available in:
- Android Studio Ladybug | 2024.2.1 RC 1
- Android Gradle Plugin 8.7.0-rc01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
bi...@google.com
Hung, I guess you have more context on this "check"?
hu...@google.com
Could you provide a small example project to help us debug this issue?
@Clément: Do you know the difference between com.android.tools:desugar_jdk_libs_nio:2.0.4 and 2.1.1?
to...@yahoo.com
Could you provide a small example project to help us debug this issue?
I'll check if I can minimize some of my project tomorrow.
hu...@google.com
This issue happens when D8 reports to AGP (via com.android.tools.r8.D8Command.Builder#setDesugarGraphConsumer) that there is a dependency from the current project's classes to android.jar. But with minSdk >= 24, such a dependency shouldn't exist (desugaring shouldn't require a classpath when minSdk >= 24).
@R8 team: Could you confirm whether it is possible to have a (desugaring) dependency between the project's classes and android.jar when minSdk >= 24?
hu...@google.com
Re
to...@yahoo.com
I tried last week... but I can't reproduce it in a brand new project (app + java-library). I can only reproduce it in my full project. My best guess is that the 'app' part uses more android classes and thereby triggers the faulty behaviour in the desugar code.
Not sure how to proceed - but I'm quite happy to try out any custom/beta build you might have?
Depending on time, I'll have another go later this week.
hu...@google.com
It would be great to track down the root cause first before we come up with a fix.
Could you generate an
./gradlew :app:mergeLibDexDebug -Dcom.android.tools.r8.dumpinputtodirectory=.
make sure the build fails with the above error, and send us dumpNNNN.zip(s) (possibly in a restricted comment)?
pu...@gmail.com
I also have a project producing this error, but noticed it only happens in debug. In release, it builds fine. I can attach a r8dump.zip for it if necessary. Although in the zip produced, library.jar and program.jar are corrupted.
hu...@google.com
Please run the build with -Dcom.android.tools.r8.dumpinputtodirectory=. instead of -Dcom.android.tools.r8.dumpinputtofile, hopefully it will not be corrupted.
Make sure the build fails with The given file ... is located outside the root directory, and send us the dumpNNNN.zip files. Thanks a lot!
to...@yahoo.com Restricted
to...@yahoo.com
I can confirm #18 (thanks!, didn't think of trying that)
The failure only happens in debug builds (as uploaded in previous) while it builds fine and deploys without an issue in release builds.
hu...@google.com
That's great, thanks! (Release builds use a different pipeline, so it doesn't hit this code path.)
@Clément: Could you take a look at the dump above and see why in the desugaring graph (see com.android.tools.r8.D8Command.Builder#setDesugarGraphConsumer) D8 reports an edge to/from android.jar and whether that is expected?
If the behavior is correct in D8, I will fix this issue in AGP.
hu...@google.com
Update: By patching AGP with the input dump above, I can see that D8 reports the following dependency to AGP (via com.android.tools.r8.DesugarGraphConsumer#accept):
dependent = {ArchiveEntryOrigin@25758} "dump12086563528200/program.jar:com/.../.../channels/io/MyPipedInputStream.class"
dependency = {ArchiveEntryOrigin@25759} "Sdk/platforms/android-35/android.jar:java/io/InputStream.class"
Do we know why D8 reports that dependency given minSdk >= 24 (26 in the input dump)?
(It would be great to track this down before beta branching that's happening today.)
hu...@google.com
Steps to reproduce
Based on the input dump above, I've managed to reproduce this issue in a project (see attached):
- Create a project with
appandlib(Android library), using AGP 8.5.2 to 8.7.1, minSdk = 24+ - In
app, setisCoreLibraryDesugaringEnabled = trueandcoreLibraryDesugaring("com.android.tools:desugar_jdk_libs_nio:2.1.0") - In
lib, create a class that implementsjava.io.InputStreamorjava.io.PipedInputStream:
class ExampleClass(pipeSize: Int) : java.io.PipedInputStream(pipeSize)
- Run
./gradlew :app:mergeLibDexDebug, the build will fail with:
> Transform bundleLibRuntimeToDirDebug (project :lib) with DexingNoClasspathTransform
ERROR: D8: java.lang.IllegalStateException: The given file 'Sdk/platforms/android-34/android.jar' is located outside the root directory 'MyApplication/lib/build/intermediates/runtime_library_classes_dir/debug/bundleLibRuntimeToDirDebug'
Root cause
The issue is a combination of 2 factors:
- AGP doesn't expect desugaring dependencies between project's classes and
android.jar - D8 in some cases reports dependencies between the
ExampleClassabove andjava.io.InputStream(RetargetInterface)inandroid.jar
Workarounds
- Use
coreLibraryDesugaring("com.android.tools:desugar_jdk_libs_nio:2.0.4")instead of2.1.0+
Fix
- AGP: Ignore dependencies between project's classes and
android.jar - D8: Investigate root cause #2 and see why the behavior is inconsistent between
desugar_jdk_libs_nio:2.0.4and2.1.0+
hu...@google.com
- AGP: Ignore dependencies between project's classes and android.jar
We've done this in
Thanks a lot for this report and for helping us debug this issue!
Follow up
I'm closing this issue now, but it would be great if R8 team could verify the following, as it may indicate some bug in D8.
- D8: Investigate root cause #2 and see why the behavior is inconsistent between desugar_jdk_libs_nio:2.0.4 and 2.1.0+
ch...@google.com
Bugjuggler: wait until 20241120 -> clementbera
an...@google.com
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Ladybug Feature Drop | 2024.2.2 Canary 9
- Android Gradle Plugin 8.8.0-alpha09
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
ch...@google.com
I opened
pu...@gmail.com
Confirming it is fixed in Canary 9.
However, Canary 9 introduced a new unrelated issue for me:
to...@yahoo.com
I don't get the error described, but any source code changes are not reflected when I hit "Debug". I have to manually build first.
I added myself to the newest issue...
cl...@google.com
Could you confirm whether it is possible to have a (desugaring) dependency between the project's classes and android.jar when minSdk >= 24?
That is possible when using desugared library. Most desugaring happen below 24, but some methods are desugared up to latest android.
I see java.io.InputStream#transferTo(java.io.OutputStream) is desugared with desugared library up to android 32 so that makes sense.
to...@yahoo.com
meerkat / agp 8.9.x and suga 2.1.3 .... seems to build again ok.
thanks!
Description
Build failure after upgrading the desugar library to 2.1.0 It works in AGP 8.4.x.