IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date:   Tue Apr 11 14:38:58 2023

    [M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet
   
    Bug: 274872542
    Bug: 272973615
    Bug: 272334475
    Bug: 268432129
    Bug: 275849044
    Bug: 275486106
    Bug: 268433162
    RelNote: Add window insets parameter to ModalBottomSheet.
    RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
    RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
    RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
    RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
    Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
    Test: Manual EdgeToEdge testing on various devices and android APIs
    Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78

M       compose/material3/material3/api/public_plus_experimental_current.txt
M       compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M       compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M       compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M       compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M       compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt

https://android-review.googlesource.com/2531428

>>>> Pixel 4a landscape is not clipping the bottom of the sheet anymore, but a white box is appearing on the right side of the screen the size of the system navigation buttons when not using gesture navigation. <<<<

This is really a big problem. So unfortunately we cannot use the ModalBottomSheet productively yet.
When can we expect a correction?

upgraded to compose bom 2023.09.00. The right side no scrim issue is still there. Tested with Samsung m21 Android 13

such a shame that this issue still persists, it's been almost eight months

is there any update on this?

ModalBottomSheet is not ready for production yet, our project have a lot of code, I can't just enable edge-to-edge for my Activity.

Without edge-to-edge enabled (`decorFitsSystemWindows` is true) material ModalBottomSheet works incorrect, it always overlaps navigation bar.

I tried different solutions, but the only one that works for me is very ugly:

```
@Composable
@SuppressLint("DiscouragedApi")
// todo: https://issuetracker.google.com/issues/274872542
private fun rememberDimensionByName(name: String): Int {
    val resources = LocalContext.current.resources
    return remember {
        val id = resources.getIdentifier(name, "dimen", "android")
        if (id == 0) 0 else resources.getDimensionPixelSize(id)
    }
}

<...>

val topInsets = WindowInsets(top = rememberDimensionByName("status_bar_height"))
val bottomInsets = WindowInsets(bottom = rememberDimensionByName("navigation_bar_height"))
ModalBottomSheet(
    ...
    windowInsets = topInsets,
    content = {
        Box(Modifier.padding(bottomInsets.asPaddingValues())) {
            ...
        }
    },
)
```
android plugin "8.2.2"
kotlin version "1.9.22"
kotlinCompilerExtensionVersion = "1.5.8"
androidx.activity:activity-compose:1.8.2
androidx.compose.ui:ui:1.6.0
androidx.compose.material3:material3:1.1.2

Was really hoping that M3 1.2 moving to Rc1 meant this was fixed but appears its still very much an issue.