Status Update
Comments
sg...@google.com <sg...@google.com> #2
Hello,
Thank you for reaching out to us with your request.
We have duly noted your feedback and will thoroughly validate it. While we cannot provide an estimated time of implementation or guarantee the fulfillment of the issue, please be assured that your input is highly valued. Your feedback enables us to enhance our products and services.
We appreciate your continued trust and support in improving our Google Cloud Platform products. In case you want to report a new issue, Please do not hesitate to create a new issue on the
Once again, we sincerely appreciate your valuable feedback; Thank you for your understanding and collaboration.
ji...@gmail.com <ji...@gmail.com> #3
Will be any communication to me when google starts working on this feature?
ch...@google.com <ch...@google.com> #4
Looks like a dup of
ji...@gmail.com <ji...@gmail.com> #5
My fault, @Override was added by jadx when decompress. So the actual issue was, after upgrade r8 from 4.0.52 to 8.6.27 we got crash like above. and the jadx decompress look like these
ji...@gmail.com <ji...@gmail.com> #6
So I'm confused, the smali nearly the same, Why jadx add @override for the crash version
sg...@google.com <sg...@google.com> #7
I am not sure when jadx adds an @Override
, and we should stick to looking at the smali code from apktool
.
Compiling you dump with -dontobfuscate
(to make debugging easier) have the following class hierarchy:
sg.bigo.live.gift.newpanel.viewmodel.GiftPanelMultiMicViewModel
|
sg.bigo.base.ext.BaseViewModelExt
|
sg.bigo.arch.mvvm.BaseViewModel
|
androidx.lifecycle.ViewModel
Where class GiftPanelMultiMicViewModel
has a public final clear()
method and ViewModel
has a <package private> final clear()
method.
Running R8 without -dontobfuscate
(as you do) gives the following hierarchy for these classes:
sg.bigo.live.i
|
sg.bigo.live.c
|
sg.bigo.live.b
|
sg.bigo.live.y
Now the final package private clear()
method ends up in the same package as public method causing the invalid code.
This looks like an R8 issue. You could try to add the rule -keep class androidx.lifecycle.ViewModel { clear(); }
to see if that works around the issue until we can figure out what is wrong.
ji...@gmail.com <ji...@gmail.com> #8
Ok, I'll try add keep rules. thanks
ji...@gmail.com <ji...@gmail.com> #9
After add keep rule
-keep class androidx.lifecycle.ViewModel { clear(); }
crash fixed!
sg...@google.com <sg...@google.com> #10
Thank you for reporting back. I have tried previous R8 versions, and this issue was introduced in version 8.0. In version 4.0 the class androidx.lifecycle.ViewModel
is not repackaged, but just renamed to androidx.lifecycle.a
(version 4.0 was the version prior to 8.0, as we changed our versioning scheme).
Description
Code as below:
After optimise by R8. GiftPanelMultiMicViewModel will be
Reproduce sample see mydump.zip, and optimise shell command