Status Update
Comments
es...@gmail.com <es...@gmail.com> #2
Hey Doris, any ideas on where this random animation could be coming from?
es...@gmail.com <es...@gmail.com> #3
Re
I tried the repro project locally. I was not able to reproduce in the the tip of tree compose code base, after dozens of attempts. It's possible the issue has been fixed recently.
Could you try the latest androidx snapshot here:
es...@gmail.com <es...@gmail.com> #4
Hi! Thank you for checking into it and giving it a try.
Unfortunately, the issue is still reproducible with snapshot 12123985, 2.8.0-SNAPSHOT for navigation, and 1.8.0-SNAPSHOT for compose.
I've pushed an update containing SNAPSHOT dependencies and automated reproduction attempts:
Now, it's sufficient to launch the application and wait.
Here's a new video:
es...@gmail.com <es...@gmail.com> #5
Thanks for the repro in
Initial investigation showed that the enter/exit transitions are correct. What appears like a scale animation is a size transform. During the repeated destination change, there seems to be a frame where the new content is resolved into an empty list of measurables, which is incorrect.
Unclear what's causing this yet - either the content composable is not yet populated for that frame, or the UI tree applier deferred adding the nodes to the tree to the next frame. More investigation will be needed.
ap...@google.com <ap...@google.com> #6
The content composable is indeed empty. It comes from currentEntry
being null here:
Over to Jeremy to investigate further in Navigation.
cl...@google.com <cl...@google.com>
es...@gmail.com <es...@gmail.com> #7
ap...@google.com <ap...@google.com> #8
cl...@google.com <cl...@google.com> #9
I'm also experiencing this issue using Navigation Compose 2.8.3
It also happens with the default animation with null transition arguments. Sometimes it just animates through scale in.
ap...@google.com <ap...@google.com> #10
Likely this is the same issue as
ap...@google.com <ap...@google.com> #11
pr...@google.com <pr...@google.com> #12
I'm still experiencing this issue in my app as of version 2.8.4. Seemingly at random I'll see a scale animation from the top left instead of my custom one.
Feel free to reference it here:
Description
Component used: Navigation Version used: 2.8.0
I'm currently using Voyager but decided to try migrating to Compose Navigation as it already provides better type-safety. However, I find it difficult to migrate since the Api is lacking in some way while there are some that are available but is only limited to the Library Scope.
This is in conjunction with Issue 361863272
I would like to request non-reified
navigation
,composable
, andNavBackStackEntry.toRoute()
wherein you can enter the class's KClass as a parameter.Voyager provides
Screen
, andTab
interfaces which could easily be implemented and extended to another interface or abstract class wherein you could create a common Class with common implementations you can tailor according to your needs. Compose Navigation currently doesn't support this but it is much more scalable especially with deeplinks.Migration to Compose Navigation without any interface proves to be difficult unless the above requested are given. I have here an example implementation of interfaces. I don't know how much effective it will be but technically it could be applied to my project to some extent since there are a lot of caveats I don't know of. It would be much better if Compose Team can provide similar interfaces which could greatly boost migration to the library.