IssueTracker

Project: platform/frameworks/support
Branch: androidx-main

commit 4a2360456d817b3101f289aac55ea1f3f610cfef
Author: Gabriel Freitas Vasconcelos <gfreivasc@gmail.com>
Date:   Thu Mar 11 14:54:53 2021

    [GH] Adds KotlinPoet integration to Room Processing
   
    ## Proposed Changes
   
    Adds `write()` method that accepts KotlinPoet's an instance of
    `FileSpec`. Also adds KotlinPoet as an API dependency and an extension
    function similar to that of JavaPoet.
   
    ## Testing
   
    Test: ./gradlew test connectedCheck without benchmarks
   
    ## Fixes
    Fixes: [b/182195680](https://issuetracker.google.com/issues/182195680)
   
    This is an imported pull request from https://github.com/androidx/androidx/pull/137.
   
    Resolves #137
    Github-Pr-Head-Sha: 96dc315b7e0e417e6a5e3d8cd6a8adda5c1b6c6a
    GitOrigin-RevId: c5e4de3ab28fed968982e572c47b5ff07d210af7
    Change-Id: I9d3aaa0a752447d9ba3978ce3fb705c0e74b3d13

M       room/compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/CompilationResultSubject.kt
M       room/compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/Source.kt
M       room/compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/GeneratedCodeMatchTest.kt
M       room/compiler-processing/build.gradle
M       room/compiler-processing/src/main/java/androidx/room/compiler/processing/XFiler.kt
M       room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacFiler.kt
M       room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacProcessingEnv.kt
M       room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspFiler.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt

https://android-review.googlesource.com/1627560

It's not clear if this is the same problem identified in "Known Issues" for the new Sheets (https://developers.google.com/apps-script/migration/sheets) -- the description there is broader -- but allowing a user to generate an action on a row of data (e.g. from a custom Menu choice) based on where they are in the sheet (getActiveRange().getRowIndex()) has been quite useful.  

Would love to have this fixed. I've been eagerly waiting to move several of our old sheets spreadsheets to the new sheet format, but without this function working it isn't possible.

Here is the code I've been using to periodically check if it is working yet..

function displayHighlightedCells() {
  var ss = SpreadsheetApp.getActiveSpreadsheet();
  var sht = ss.getSheetByName("Sheet1");
  Browser.msgBox("Range " + sht.getActiveRange().getA1Notation() + " selected.");
}

function onOpen() {
  var sheet = SpreadsheetApp.getActiveSpreadsheet();
  var entries = [
  {
    name : "Show Highlighted Cell Range",
    functionName : "displayHighlightedCells"
  }];
  sheet.addMenu("Range Test", entries);
};

There appears to be an issue overall with the conjunction of spreadsheetapp WITH the "on change" trigger.  See this issue here..

https://code.google.com/p/google-apps-script-issues/issues/detail?id=4033

And also this issue here..
https://code.google.com/p/google-apps-script-issues/issues/detail?id=4059

Please star all items and have your friends star.  We need to get Google to address this issue.

Please fix it! Super important even for simple scripts. I am e.g. trying to emphasize bolded entries with a different color. Thus need get the onChange event for changing the font weight and need to get the cell where the change happened.

This is a huge issue an need immediate attention. A huge chunk of code is blocked because of it.

I am using the "from spreadsheet" "on change" trigger to email me notifications every time a cell has changed its value, it works fine, my only issue is that when I receive an email from one change, this particular email repeats 40 minutes later, then 20 minutes later, then 5, 2, and seconds later. Time between mails varies, but always the same problem, I receive emails that doesn't mean changes and next morning I have around 60 new mails in my inbox from only one or two changes. Can you explain what is going on?

function sendEmail(){
  var emailAddress = 'mail@gmail.mx';
  var message = "Message";
  var subject = "Subject";
  MailApp.sendEmail(emailAddress, subject, message);
}

I don't get A1 like OP but rather #REF! in following script, is the reported defect the reason why? If so, how come it is different? Is there any workaround to get the cell whos background color has changed in a function added as an installable trigger set to run From Spreadsheet on change?

function onChangeInstallable(e) {

  var ss = SpreadsheetApp.getActiveSpreadsheet();
  var activeSheet = ss.getActiveSheet();
  var activeSheetName = activeSheet.getSheetName();

  if (activeSheetName == "Settings") {

    if(e.changeType == "OTHER"){

      // makes it this far ok but following line returns
      // #REF! instead of A1 notation of changed cell.

      var editedRange = SpreadsheetApp.getActiveRange().getA1Notation();

      if (editedRange == 'B43' || editedRange == 'B44'){

        setBackgroundColors();

      }
    }
  }
}

This issue should now be fixed. Let us know if you continue to see this problem.

Hello,
I am trying to use this same function but it appears, it hasn't been fixed yet.
function onChangeInstallable(e) {

  var ss = SpreadsheetApp.getActiveSpreadsheet();
  var activeSheet = ss.getActiveSheet();
  var activeSheetName = activeSheet.getSheetName();

  if (activeSheetName == "Settings") {

    if(e.changeType == "OTHER"){

      // makes it this far ok but following line returns
      // #REF! instead of A1 notation of changed cell.

      var editedRange = SpreadsheetApp.getActiveRange().getA1Notation();

      if (editedRange == 'B43' || editedRange == 'B44'){

        setBackgroundColors();

      }
    }
  }

I can't get neither the values of an Active Range using (SpreadsheetApp.getActiveRange().getValues()) nor the A1 Notation of the range when the onChange event type is OTHER.

This issue isn't fixed, I am sorry.

Sad to say that the issue is still not fixed. We are still unable to pin point the exact cell where the change occurred. Appreciate if there is some progress with this 3+ years issue. Thanks

Not sure this is useful information, but I needed to know what row was inserted to do some adjustments to A and B to said row. This works for me:

function onChange(e) {
  if( e.changeType == 'INSERT_ROW' ) {
    var spreadsheet = SpreadsheetApp.getActiveSpreadsheet();
    var sh          = spreadsheet.getSheetByName("SOMESHEETNAMEHERE");
    var theRow      = sh.getActiveRange().getRow();
   
    Browser.msgBox("Range " + theRow + " selected.");
  }
}


theRow will be the number of the row inserted.

For e.changeType == "OTHER" still we are getting #REF!

getRange() is not working within the onChange event after unhiding rows?

Here is what i'm trying to do and the sample code.

I want to run some script when a user unhides rows. The only way, that I can see, to detect when a user unhides rows is within the onChange event. The only way, that I can see, to try and determine what changed is through the changeType property. However, when a user unhides rows, the changeType is equal to OTHER. OTHER can mean all kinds of things. So I'd like to try and determine if rows were unhidden.

What I noticed is that when I unhide rows, those rows are now selected (have focus). So in theory, I should just be able to use getActiveRange() to return the rows that were just unhidden.

The problem is that when I use getActiveRange within the onChange event, it returns nothing. However, if I call getActiveRange after the onChange event function code has completed, then I get the correct information...even though I have not changed what I have currently selected in the sheet.

Why is getRange() returning nothing while within the onChange event?

The following onChange code will show a dialog box with the number of rows that is returned by the getActiveRange method when the user unhides rows. The code will add a menu item called Plan -> Test. Clicking Test will show a dialog box with the number of rows currently selected. To try this out, hide some rows, then unhide them. When you unhide them you will see a dialog box that says 0. Then go to Plan ->

function onOpen() {
  var ui = SpreadsheetApp.getUi();
  ui.createMenu('Plan')
      .addItem('Collapse Section', 'collapseSection')
      .addSeparator()
      .addItem('Test','testThis')
      .addToUi();
}

function testThis() {
  var thisSheet = SpreadsheetApp.getActiveSpreadsheet().getActiveSheet();
  var thisRange = thisSheet.getActiveRange();
  popMsg(thisRange.getNumRows());
}

function onChange(e){
  var activeSheet = e.source.getActiveSheet();
  if (e.changeType == "OTHER") {
    // some other event occurred, possible Unhiding Rows    
    if (activeSheet.getName() == "Portfolio") {
      // only execute this code if the OTHER event occurred while on the Portfolio tab
      var thisSheet = SpreadsheetApp.getActiveSpreadsheet().getActiveSheet();
      var thisRange = thisSheet.getActiveRange();
      popMsg(thisRange.getNumRows());
    }
  }
}

function popMsg (thisMsg) {
  var ui = SpreadsheetApp.getUi();  
  var thisMsg = ui.alert('Information',thisMsg,ui.ButtonSet.OK);
}

@Jonathan Mueller, this seems to be a new occurrence of the bug, and I've filed https://issuetracker.google.com/38159142 to track it.

also here: https://issuetracker.google.com/issues/36761853

and here: https://issuetracker.google.com/issues/36760104

YOUR SOLUTION IS HERE (BY A LITTLE TRICK). VARIABLES AND EXPLANATIONS ARE CREATED ON TURKISH LANGUAGE FOR MYSELF. AND THERE ARE UNRELATED CODE PARTS WHICH IS ACTUALLY RELATED MY OWN PROJECT. IF YOU CHECK MY CODE, YOU CAN ELIMINATE THEM AND UNDERSTAND HOW I FIND THE SOLUTION...

function onChangeInstallable(e) {

  var kaynak = e.source;
  var aktif_sayfa = kaynak.getActiveSheet();
  var aktif_sayfa_ismi = aktif_sayfa.getSheetName();

  if (aktif_sayfa_ismi != "Flag List&Explanation") {

    var aktif_hucrenin_degeri = SpreadsheetApp.getActiveRange().getValue();
    console.log("Aktif Hücre'nin Değeri: " + aktif_hucrenin_degeri);

    var aktif_hucrenin_karakter_sayisi = aktif_hucrenin_degeri.toString().length;
    console.log("Aktif Hücre'nin Karakter Sayısı: " + aktif_hucrenin_karakter_sayisi)
   
 
    if(e.changeType == 'FORMAT'){

      // -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      // -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

        var aktif_hucrenin_yolu = SpreadsheetApp.getActiveRange().getA1Notation();
        console.log("Aktif Hücrenin Yolu: " + aktif_hucrenin_yolu);

        //----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
        // SÜTUN YOLUNDAN SATIR NUMARASINI ALDIKTAN SONRA, SÜTUN'UN REFERANS HARFİNİ VE HARFİN KAÇINCI SIRAYA GELDİĞİNİ BULUYORUZ.
        // Bunu yapmamızın nedeni Google Spreadsheet'in "onChange" fonksiyonunda aktif hücrenin yolunu bize sayısal sıraları olarak verememesinden kaynaklanıyor.
        // Hücrelerin yolunu Sütün ve Satır olarak parçalara ayırırken çok fazla değişkenlik olduğundan ve içinden çıkılamaz hal alabileceğinden ötürü sadece A:Z arası Tek Harfli sütunlar için uyduladık.
        //----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
       
          // Numaraları Siler, Harfleri Korur. (HÜCRE YOLUNDAN SÜTUNU ALIYORUZ)
        var sutun_yolu_harfi = aktif_hucrenin_yolu.replace(/\d+/g,'');
        console.log("Aktif Sütun'un Harfi: " + sutun_yolu_harfi);

        var sutun_yolu_numarasi = parseInt(sutun_yolu_harfi, 36) - 9;
        console.log("Aktif Sütun'un İndex Numarası: " + sutun_yolu_numarasi);

          // Harfleri Siler, Numaraları Korur. (HÜCRE YOLUNDAN SATIRI ALIYORUZ)
        var satir_numarasi = aktif_hucrenin_yolu.toString().replace(/[^0-9\.]+/g, "");
        console.log("Aktif Satır'ın İndex Numarası: " + satir_numarasi);

      // -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      // -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


        if (sutun_yolu_numarasi == 9 && satir_numarasi > 1){
           
          if (aktif_hucrenin_degeri == ""){

              SpreadsheetApp.getUi().alert("Any empty cell's format cannot be changed in this field column.");
              SpreadsheetApp.getActiveSheet().getRange(satir_numarasi, sutun_yolu_numarasi).setBackground(null).setFontColor('#000000');
              return onChangeInstallable;

          }

Almost a decade later and I am still having this exact issue. Come on Google. It shouldn't take this long to fix the issue.

Two more years later, and I'm still having this issue.