include tag is broken (overriding layout params never works) [36908001]

Infeasible

Bug

Status Update

No update yet.

Description

m....@gmail.com

created issue #1

Jun 4, 2009 08:52AM

Affects:
1.5 R1

Steps to reproduce the problem:
1) create a layout file containing a linear layout, set layout width to
fill_parent
2) include that layout in another layout using:
<include layout="@layout/custom_layout" android:layout_width="wrap_content" />
3) see how the included linear layout still fills its parent

I tested this with various layouts and various layout parameters, all are
ignored by the include tag (i.e. overriding layout params has no effect).

Comments

ro...@gmail.com <ro...@gmail.com> #2Jun 4, 2009 05:26PM

Status: Won't Fix (Infeasible)

Long overdue functionality that would help Android catch up.

m....@gmail.com <m....@gmail.com> #3Jun 4, 2009 05:33PM

LONG LONG LONG overdue.

m....@gmail.com <m....@gmail.com> #4Jun 4, 2009 05:39PM

Can't wait, please support this function..

m....@gmail.com <m....@gmail.com> #5Jun 4, 2009 05:42PM

This is really needed! Please add this soon!

m....@gmail.com <m....@gmail.com> #6Sep 7, 2009 07:56AM

I would like it too.

sy...@altran.com <sy...@altran.com> #7Nov 2, 2009 04:00PM

ID3v2.2 uses the ULT tag, while ID3v2.3 uses the USLT ID3 tag to store lyrics embedded in an MP3.

Hopefully Android will implement a robust system can display lyrics from either ID3 version.

m....@gmail.com <m....@gmail.com> #8Nov 2, 2009 04:26PM

this must be done asap.

bu...@gmail.com <bu...@gmail.com> #9Apr 13, 2010 04:02PM

Has anyone successfully ported Jaudiotagger to Android? That would be one solution.

bu...@gmail.com <bu...@gmail.com> #10Apr 13, 2010 05:33PM

#8 Jaudiotagger works in Android 'out of the box'.
I added lyrics support for Apollo, CyanogenMod's default audio player using that library, and works fine:

http://review.cyanogenmod.com/#/c/20056/

Anyway, it would be better and easier if Android provided access to 'lyrics' in the MediaProvider.

mi...@gmail.com <mi...@gmail.com> #11Aug 18, 2010 04:34PM

@rafagames92
I saw the linked page is for ICS branch. You imported Jaudiotagger without any problems? Perhaps the problems I had were related to Froyo, which doesn't have as complete of a Java system as the newer ICS?

m....@gmail.com <m....@gmail.com> #12Aug 18, 2010 04:43PM

Yes. Please add this soon!

he...@gmail.com <he...@gmail.com> #13Nov 4, 2010 03:06PM

I would like it too.

ar...@gmail.com <ar...@gmail.com> #14Nov 12, 2010 01:35AM

i'm really looking forward for this feature! it's a little shame if android phones cannot display embedded lyrics, especially the high-end ones when they are compared to other brands :)

ru...@gmail.com <ru...@gmail.com> #15Dec 15, 2010 01:06AM

I'm really lookng ford to see this feature on android phones! Without this function android will have hard to call better than I.os media play features.

va...@gmail.com <va...@gmail.com> #16Mar 26, 2011 10:55AM

Please add this soon

[Deleted User] <[Deleted User]> #17Jul 22, 2011 07:47PM

This would be a great idea , it would just make android better .

ps...@gmail.com <ps...@gmail.com> #18Oct 4, 2011 01:53AM

I I want this,please add

be...@gmail.com <be...@gmail.com> #19Oct 24, 2011 05:14AM

Yes, I need this so that podcasts from ChinesePod can show their lyrics. Thanks!

gv...@gmail.com <gv...@gmail.com> #20Jul 12, 2012 01:41PM

cannot believe this feature is missing in adroid

sc...@gmail.com <sc...@gmail.com> #21Jul 19, 2012 05:25AM

Get this approved google...

ta...@gmail.com <ta...@gmail.com> #22Nov 9, 2012 07:56AM

Cmon google iOS 3 had this feature!

ri...@gmail.com <ri...@gmail.com> #23Dec 10, 2012 12:18PM

This missing feature is the only thnig that prevents me from buying an Android handset.... ANy chance you're implementing it?

fa...@gmail.com <fa...@gmail.com> #24May 9, 2013 02:55AM

I am thinking of switching from iPhone to Android phone, and I am frankly staggered to find that no Android music player supports the showing of embedded lyrics. This needs to be done NOW!

ey...@gmail.com <ey...@gmail.com> #25Jun 14, 2013 08:26PM

#22 and #23, in the link I put in #8 there is an apk with a modified version of Apollo music player with lyric support. While they add it to the official application, you can use it with no problem.

jo...@gmail.com <jo...@gmail.com> #26Aug 14, 2013 09:39PM

Thanks @rafagames92. I'll give that a try when I get my new phone.

mi...@benesty.fr <mi...@benesty.fr> #27Aug 17, 2013 09:57PM

@rafagames92: I've downloaded Apollo from that site, installed using Astro, and yet don't see how to see lyrics on an mp3 which I know has lyrics. I didn't have a previous version of Apollo installed as this is a new phone. Any idea? Is there a setting I'm missing?

[Deleted User] <[Deleted User]> #28May 22, 2014 06:23PM

Ah, I found that on the screen for the album with the album image huge, I have to tap the screen on the image and it appears. Cool!

wh...@gmail.com <wh...@gmail.com> #29Mar 19, 2019 01:13PM

@rafagames92, I tried out your apk from post #9 and tapping on the album art for a song that has SYLT lyrics nothing happens.

Does your patched version only support USLT? Would it be possible to add support for scrolling SYLT lyrics as well?