Assigned
Status Update
No update yet.
Comments
ap...@google.com
Project: r8
Branch: main
Author: Søren Gjesse <
Link:
Do not optimize append indexing into char[] or CharSequence
Expand for full commit details
Do not optimize append indexing into char[] or CharSequence
Current analysis did not take into account that these methods might throw.
Fixes: b/369739224
Bug: b/369971265
Change-Id: Ied98075962ffd01ec1203bae4d934d00b4c43bf7
Files:
- M
src/main/java/com/android/tools/r8/graph/DexItemFactory.java - M
src/main/java/com/android/tools/r8/ir/optimize/string/StringBuilderOracle.java - M
src/test/java/com/android/tools/r8/ir/optimize/string/B369739224Test.java
Hash: c70826e97c186f41e12d63a14ff5120b346a06d9
Date: Fri Sep 27 11:22:14 2024
Description
The two append methods
used to be supported in the string builder optimization. However, that support could change semantics to not throw exceptions if these appends ended up as having "no effect" except for their potential throwing effect.