Status Update
Comments
ta...@gmail.com <ta...@gmail.com> #2
Red
tn...@google.com <tn...@google.com>
di...@android.com <di...@android.com> #4
ta...@gmail.com <ta...@gmail.com> #5
[Comment deleted]
ta...@gmail.com <ta...@gmail.com> #6
Sorry my patch is incomplete. I need proxy_connection_rewind(root) when skip header...
} else {
/* just skip headers */
proxy_connection_rewind(root); // ADD THIS LINE
}
}
} else {
/* just skip headers */
proxy_connection_rewind(root); // ADD THIS LINE
}
}
ta...@gmail.com <ta...@gmail.com> #8
The new patch has not been merged yet.
Would you please review the patch?
Would you please review the patch?
ta...@gmail.com <ta...@gmail.com> #9
This patch has been merged to master branch, but it seems not be merged to studio-master-dev branch yet.
https://android-review.googlesource.com/#/c/108816/
Would you please merge the patch? it is very important for us, because we can't connect any HTTPS server via our proxy without this patch.
Would you please merge the patch? it is very important for us, because we can't connect any HTTPS server via our proxy without this patch.
az...@gmail.com <az...@gmail.com> #10
The final fix for this issue (https://android.googlesource.com/platform/external/qemu/+/3e37599394b5fcb655db22c1943e2395832f7eb2 ) hasn't been merged into the emu-master-dev branch (https://android.googlesource.com/platform/external/qemu.git/+/emu-master-dev/android/android-emu/android/proxy/proxy_http_connector.c#150 ), where the emulator development seems to be happening today.
Thus, the issue is still present in the emulator:
$ emulator -writable-system -avd avd1 -http-proxy some-proxy-with-http-headers:8888 -version
Android emulator version 25.2.5.0
...
$ emulator -writable-system -avd avd1 -http-proxy some-proxy-with-http-headers:8888 -qemu -version
QEMU emulator version 2.2.0 , Copyright (c) 2003-2008 Fabrice Bellard
...
$ emulator -writable-system -avd avd1 -http-proxy some-proxy-with-http-headers:8888 -debug-proxy
...
http_service_connect: using HTTP connector
tcp:216.58.214.206:443(106): connecting
tcp:216.58.214.206:443(106): connected to http proxy, sending header
tcp:216.58.214.206:443(106): sending 144 bytes:
Thus, the issue is still present in the emulator:
$ emulator -writable-system -avd avd1 -http-proxy some-proxy-with-http-headers:8888 -version
Android emulator version 25.2.5.0
...
$ emulator -writable-system -avd avd1 -http-proxy some-proxy-with-http-headers:8888 -qemu -version
QEMU emulator version 2.2.0 , Copyright (c) 2003-2008 Fabrice Bellard
...
$ emulator -writable-system -avd avd1 -http-proxy some-proxy-with-http-headers:8888 -debug-proxy
...
http_service_connect: using HTTP connector
tcp:216.58.214.206:443(106): connecting
tcp:216.58.214.206:443(106): connected to http proxy, sending header
tcp:216.58.214.206:443(106): sending 144 bytes:
...
tcp:216.58.214.206:443(106): header sent, receiving first answer line
tcp:216.58.214.206:443(106): received 'HTTP/1.1 200 OK'
tcp:216.58.214.206:443(106): receiving second answer line
tcp:216.58.214.206:443(106): received 'x-hola-timeline-debug: ztun 104ms z381 xxx.yyy.69.126 us zgc us.direct_route z381'
tcp:216.58.214.206:443(106): received 'x-hola-timeline-debug: ztun 104ms z381 xxx.yyy.69.126 us zgc us.direct_route z381x-hola-ip: xxx.yyy.69.126'
tcp:216.58.214.206:443(106): received 'x-hola-timeline-debug: ztun 104ms z381 xxx.yyy.69.126 us zgc us.direct_route z381x-hola-ip: xxx.yyy.69.126'
tcp:216.58.214.206:443(106): blocked
...
I'd suggest reopening the issue until the 3e37599394b5fcb655db22c1943e2395832f7eb2 is merged back into the mainline branch (emu-master-dev as of now).
Thanks
tcp:216.58.214.206:443(106): header sent, receiving first answer line
tcp:216.58.214.206:443(106): received 'HTTP/1.1 200 OK'
tcp:216.58.214.206:443(106): receiving second answer line
tcp:216.58.214.206:443(106): received 'x-hola-timeline-debug: ztun 104ms z381 xxx.yyy.69.126 us zgc us.direct_route z381'
tcp:216.58.214.206:443(106): received 'x-hola-timeline-debug: ztun 104ms z381 xxx.yyy.69.126 us zgc us.direct_route z381x-hola-ip: xxx.yyy.69.126'
tcp:216.58.214.206:443(106): received 'x-hola-timeline-debug: ztun 104ms z381 xxx.yyy.69.126 us zgc us.direct_route z381x-hola-ip: xxx.yyy.69.126'
tcp:216.58.214.206:443(106): blocked
...
I'd suggest reopening the issue until the 3e37599394b5fcb655db22c1943e2395832f7eb2 is merged back into the mainline branch (emu-master-dev as of now).
Thanks
al...@interi.co <al...@interi.co> #11
Any possibility of this bug to be really fixed?
mt...@bec.dk <mt...@bec.dk> #12
The issue is still there. Will it be fixed?
Description
response header from HTTP Proxy.
When you connect any HTTPS server via HTTP proxy which respond with some header lines,
the SSL connection will be failed.
When receive any line from proxy in STATE_RECEIVE_ANSWER_LINE2 state,
this function stops reading response from proxy.
} else {
/* ok, we're connected */
PROXY_LOG("%s: connection succeeded", root->name);
proxy_connection_free( root, 1, PROXY_EVENT_CONNECTED );
}
I believe this code should be:
} else {
if (strlen(line) == 0) { /* end of headers */
/* ok, we're connected */
PROXY_LOG("%s: connection succeeded", root->name);
proxy_connection_free( root, 1, PROXY_EVENT_CONNECTED );
} else {
/* just skip header */
}
}