v4 support FileProvider does not work with setFlags [37005552]

Obsolete

Bug

Status Update

No update yet.

Description

nm...@gmail.com

created issue #1

Sep 26, 2014 01:28AM

AFAICT, in spite of the documentation claims (

https://developer.android.com/reference/android/support/v4/content/FileProvider.html#Permissions), using setFlags with intents for v4 support FileProvider URIs does not work.

Here is a small repro project:

https://github.com/nmr8acme/FileProvider-permission-bug

Running on N5 4.4.4 KTU84P

(This repro has the com.google.android.GoogleCamera package hardcoded for use with grantUriPermission, so when you tap "with grantUriPermission" you need to use that app to handle the intent.)

Observe that tapping "with grantUriPermission" allows you to take a photo in response to the "android.media.action.IMAGE_CAPTURE" intent and a supplied URI to a path to write the captured photo, and that photo is displayed in the activity.

Observe that tapping "with setFlags" results in a permission error after the image is captured. (Stack attached.) (And the captured photo is not displayed in the activity.)

Looks like this code is mostly Jeff Sharkey. If you're out there Jeff would you take a look at this?

A couple relevant SO questions:
-

http://stackoverflow.com/questions/18249007/how-to-use-support-fileprovider-for-sharing-content-to-other-apps/18332000#18332000
-

http://stackoverflow.com/questions/24467696/android-file-provider-permission-denial

deleted

Restricted

0 B

Comments

nm...@gmail.com <nm...@gmail.com> #2Oct 29, 2014 05:28PM

This is per design; in order to know if a user has the Chromecast extension installed (and which one), cast_sender.js requests the script from all potentially installed extensions.

ne...@gmail.com <ne...@gmail.com> #3Jan 23, 2015 06:19PM

This is terrible coding.

nm...@gmail.com <nm...@gmail.com> #4Jan 24, 2015 11:01PM

This is amateurish at best, incompetent at worst. It's bad and Chrome developers should feel bad.

pa...@gmail.com <pa...@gmail.com> #5Aug 14, 2016 02:57PM

at least keep the console free of errors...

pa...@gmail.com <pa...@gmail.com> #6Aug 14, 2016 03:02PM

Also I don't think you need to revoke manually if you grant it through the flags.

ck...@gmail.com <ck...@gmail.com> #7Dec 30, 2016 04:48AM

This would be about 3 lines of code to fix. I'm very surprised Chromecast team considers it reasonable to dump a long list of error messages in the vast majority of people's browsers, ie > 99% of users of a typical web app are either using another browser or using Chrome but without Chromecast, and this will aversely affect all of them.

"Don’t leave “broken windows” (bad designs, wrong decisions, or poor code) unrepaired. Fix each one as soon as it is discovered." [1]. By routinely dumping error messages in almost everyone's consoles as if it were a normal situation, you are encouraging developers and users to ignore error messages instead of taking them seriously, as they should do, and you are making it impossible for developers to attain a pristine error log.

1.

https://pragprog.com/the-pragmatic-programmer/extracts/software-entropy

[Deleted User] <[Deleted User]> #8Jun 15, 2017 01:47AM

This is ridiculous and very annoying. I dont want to see this error every time when developing.

Please fix!

jo...@gmail.com <jo...@gmail.com> #9Feb 11, 2019 08:11AM

Agree with all comments above. Please fix!

sa...@google.com <sa...@google.com> #10Aug 18, 2020 04:02PM

Status: Won't Fix (Obsolete)

Very annoying for me too. Trying to fix a bug in a program and it took me a while to figure out that this wasn't part of the bug and wasn't something I was doing.