ActionBarDrawerToggle default up icon is not tinted [37009338]

Fixed

Bug

[AOSP] assigned

[AOSP] Released

[AOSP] FutureRelease

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Nov 4, 2014 11:01AM

Library used: appcompat-v7
Version used: 21.0.0

When one uses the ActionBarDrawerToggle (v7) one can show the up button still (useful on tablets) by doing:

getSupportActionBar().setDisplayHomeAsUpEnabled(true);
getSupportActionBar().setHomeButtonEnabled(true);
mDrawerToggle.setDrawerIndicatorEnabled(false);

But it shows a white up button. If ActionBarDrawerToggle is not used, then it shows the correct color. setHomeAsUpIndicator in ActionBarDrawerToggle states:

resId Resource ID of a drawable to use for the up indicator, or 0 to use the theme's default

I guess this is true only that far, that it uses the correct drawable from the theme. But it should be using the correct drawable + tint from the theme in my opinion.

Current workaround is to set the icon by yourself:

TypedArray a = getTheme().obtainStyledAttributes(R.style.AppTheme, new int[] {R.attr.homeAsUpIndicator});
Drawable drawable = getResources().getDrawable(a.getResourceId(0, 0));
drawable.setColorFilter(WANTED_COLOR, PorterDuff.Mode.SRC_IN);
mDrawerToggle.setHomeAsUpIndicator(drawable);

Comments

al...@android.com <al...@android.com> Nov 5, 2014 12:59AM

Assigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Nov 5, 2014 09:48AM

Status: Won't Fix (Intended Behavior)

Disabling all extensions does not fix the problem.

pa...@gmail.com <pa...@gmail.com> #3Nov 5, 2014 10:37AM

Enabled log-level=0 and got the following:

$ google-chrome --enable-logging --log-level=0
[20397:20397:1383124398002:ERROR:chrome/app/chrome_dll_main.cc(247)] GLib-GObject: instance of invalid non-instantiatable type `(null)'
Segmentation fault

ch...@google.com <ch...@google.com> #4Nov 5, 2014 10:46AM

Adding debug log.

pa...@gmail.com <pa...@gmail.com> #5Nov 5, 2014 03:15PM

Do you have crash reporting enabled? If so, a crash id should be dumped, and if you give that to us, then we can look up what caused the crash.

pa...@gmail.com <pa...@gmail.com> #6Nov 19, 2014 03:35PM

My client_id appears to be B7776A6E-F752-1E5B-E46B-ACD5F961EE30.

I see crash_count: 0, but since I've enabled it I've gotten it to crash twice.

Seems to happen immediately after geolocation is finished.

ch...@google.com <ch...@google.com> #7Nov 19, 2014 03:51PM

Status: Assigned (reopened)

I only see 2 browser crashes from your client id:

Stack trace:

Thread 0 *CRASHED* ( SIGSEGV @ 0x00000020 )
0xb6c306ca [libdbus-glib-1.so.2.1.0 + 0x0000d6ca]
0xb6c30be4 [libdbus-glib-1.so.2.1.0 + 0x0000dbe4]
0xb6c324f9 [libdbus-glib-1.so.2.1.0 + 0x0000f4f9]
0xb6c2f17e [libdbus-glib-1.so.2.1.0 + 0x0000c17e]
0xb6c07790 [libdbus-1.so.3.4.0 + 0x0001d790]
0xb6bf73c5 [libdbus-1.so.3.4.0 + 0x0000d3c5]
0xb6bf9991 [libdbus-1.so.3.4.0 + 0x0000f991]
0xb6c2a92c [libdbus-glib-1.so.2.1.0 + 0x0000792c]
0xb705b5e4 [libglib-2.0.so.0.2400.1 + 0x0003b5e4]
0xb705f2d7 [libglib-2.0.so.0.2400.1 + 0x0003f2d7]
0xb705f4b7 [libglib-2.0.so.0.2400.1 + 0x0003f4b7]
0x08707d34 [chrome - base/message_pump_glib.cc:195] base::MessagePumpForUI::RunWithDispatcher(base::MessagePump::Delegate*, base::MessagePumpForUI::Dispatcher*)
0x0870796f [chrome - ./base/message_pump_glib.h:59] base::MessagePumpForUI::Run(base::MessagePump::Delegate*)
0x086e00f3 [chrome - base/message_loop.cc:214] MessageLoop::RunInternal()
0x086e0161 [chrome - base/message_loop.cc:617] MessageLoopForUI::Run(base::MessagePumpForUI::Dispatcher*)
0x08073625 [chrome - chrome/browser/browser_main.cc:198] BrowserMain(MainFunctionParams const&)
0x0806cb4a [chrome - chrome/app/chrome_dll_main.cc:861] ChromeMain
0x0806cf5f [chrome - chrome/app/chrome_exe_main_gtk.cc:50]

ch...@google.com <ch...@google.com> Nov 20, 2014 09:15AM

Marked as fixed.

ch...@google.com <ch...@google.com> #8Apr 22, 2015 11:13AM

Are they the same? I can reproduce it a few more times if you'd like.