Status Update
No update yet.
Comments
pp...@google.com
since these are in public API (:/) we need to do this in 1.2
jm...@gmail.com
since it is already marked as deprecated, we can probably do it by now.
jm...@gmail.com
Opening diff shortly
[Deleted User] <[Deleted User]>
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
ma...@gmail.com
It should be able to install any component requested. As long as it can't - it won't end up in the build pipeline. I had added it to ours and was required to remove it because it could not download everything that was requested.
xa...@google.com
jo...@gmail.com
[Comment deleted]
jo...@gmail.com
[Comment deleted]
jo...@gmail.com
[Comment deleted]
jo...@gmail.com
Apparently all the components *are* updated, but gradle will not see the update until its next invocation.
One workaround is to execute gradle twice, once to throw away:
$ gradle dependencies || true
$ gradle clean assembleDebug
Another workaround is to update the extra repos explicitly:
$ echo y | android update sdk --no-ui --all --filter "extra-android-m2repository"
$ gradle clean assembleDebug
Seehttp://stackoverflow.com/a/38381577/901597 for more details.
Seehttps://github.com/JakeWharton/sdk-manager-plugin/issues/10 for more background.
One workaround is to execute gradle twice, once to throw away:
$ gradle dependencies || true
$ gradle clean assembleDebug
Another workaround is to update the extra repos explicitly:
$ echo y | android update sdk --no-ui --all --filter "extra-android-m2repository"
$ gradle clean assembleDebug
See
See
be...@google.com
I understand this bug is about support libraries, not emulator images?
Can you add detailed repro steps, i.e. what dependencies are you using? Gradle should be able to download support libraries now. Are you using Jake's sdk-manager-plugin? Can you reproduce the problem without it?
Can you add detailed repro steps, i.e. what dependencies are you using? Gradle should be able to download support libraries now. Are you using Jake's sdk-manager-plugin? Can you reproduce the problem without it?
jo...@gmail.com
The bug concerns sdkDownload's ability to *update* components in the extra-*-m2repository's. support-v4, for example. Yes, it downloads support libraries, but the task still fails.
You can see the failure here:
https://circleci.com/gh/libpd/pd-for-android/88
Expand the "gradle dependencies" step, which fails because of failure to resolve support-v4 even though, looking up a few lines in the console output you can see that support-v4 was already updated ("Install Android Support Repository").
The workaround employed in this case is to discard the result of one gradle command so that the following command will succeed.
AFAIK, this is the same bug that exists in Jake Wharton's sdk-manager-plugin, in case that's helpful, and there's more information in the issue I referenced.
You can see the failure here:
Expand the "gradle dependencies" step, which fails because of failure to resolve support-v4 even though, looking up a few lines in the console output you can see that support-v4 was already updated ("Install Android Support Repository").
The workaround employed in this case is to discard the result of one gradle command so that the following command will succeed.
AFAIK, this is the same bug that exists in Jake Wharton's sdk-manager-plugin, in case that's helpful, and there's more information in the issue I referenced.
Description
The `sdkDownload` feature of the Android Gradle plugin, when enabled, only downloads the Build Tools and Platform into the Android SDK directory.
Even if the app depends on Android or Google support libraries — which are only readily available for install via the Android SDK Manager — the Gradle plugin does not install them.
If this feature is intended to be a replacement for the `android update sdk` command line, which is being killed off (see
I realise this is experimental, and I would hope that this is in planning, but to be clear: the `android.builder.sdkDownload` option needs to download and install all Android-related dependencies.
Ideally, it would also be able to (optionally) download and install the SDK Tools (i.e. emulator), and system images (much like