Infeasible
Status Update
Comments
vi...@google.com <vi...@google.com> #2
Surely this is something that the developer can handle themselves. If they just have a reference to the Marker then add a custom property to the marker and use that as the id, I don't think we need to start adding more info to Marker objects for everyone.
I would need more use cases where this is out of the developers hands before I would consider putting this in the API.
I would need more use cases where this is out of the developers hands before I would consider putting this in the API.
vi...@google.com <vi...@google.com> #3
If there was a property name that was guaranteed to be safe - then sure. Theoretically any property name longer than three characters won't conflict with a closure-compiler renamed property, but this could break things:
myMarker.a = "test".
This would also be fixable by having a sub-property for objects that was designated for developers to add to.
myMarker.a = "test".
This would also be fixable by having a sub-property for objects that was designated for developers to add to.
Description
1. open hotspot at DUT
2. one client connected this hotspot
3.run speedtest at client
4. found speed is very slow than ref
analysis: DUT's cellular nic enable gro, transfer one large packet to kernel sometimes, then transfer to clat for processing. After processing, send it to the TUN. TUN receive this packet, forward it to wlan. When forwarding, it was found that the packet size exceeded MTU, reply ICMP to speedtest server immediately.
from 002-1029_095939--1029_100043\tcpdump.cap:
1) receive one large packet, size is 2508:
41505 2024-10-29 17:00:04.896774 64:ff9b::4e0a:a103 2a00:f41:18b0:38ca:39d3:4bf:35f3:c0c3 TCP 2416 31872 2508 http-alt(8080) → 51812 [ACK] Seq=4048662303 Ack=116708023 Win=31872 Len=2416 TSval=3298733802 TSecr=3625573412 [TCP segment of a reassembled PDU]
2) after clat, tun receive this large packet:
41550 2024-10-29 17:00:04.975651 78.10.161.3 192.0.0.4 TCP 247706 31872 2488 0x0000 (0) http-alt(8080) → 51812 [ACK] Seq=4048662303 Ack=116708023 Win=31872 Len=2416 TSval=3298733802 TSecr=3625573412 [TCP segment of a reassembled PDU]
3) when forward this packet, ip_forward found packet's size is larger than mtu, so replay icmp:
41551 2024-10-29 17:00:04.976037 192.0.0.4 78.10.161.3 ICMP 249 596 0xa2c6 (41670),0x0000 (0) Destination unreachable (Fragmentation needed)