Give kotlin gradle syntax in error message for `checkTestedAppObfuscationRelease` [378724144]

Fixed

Bug

Status Update

No update yet.

Description

yo...@gmail.com

created issue #1

Nov 12, 2024 09:51PM

AGP 8.7.2

Use com.android.test plugin to create app tests with GMD.

run :app-tests:my-feature:cpixel2api30ReleaseAndroidTest

Actual

Error gives only groovy gradle syntax I get this error:

> Task :app-tests:my-feature:checkTestedAppObfuscationRelease FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app-tests:my-feature:checkTestedAppObfuscationRelease'.
> Mapping file found in tested application. Code shrinker must also be enabled in test plugin with:
  android {
      buildTypes {
          release {
              minifyEnabled true
          }
      }
  }

Expected

give Kotlin syntax as well.

i.e.

  android {
      buildTypes {
          register("release") {
              isMinifyEnabled = true
          }
      }
  }

Comments

ra...@google.com <ra...@google.com> Nov 13, 2024 11:06PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Nov 15, 2024 03:53PM

Reassigned to hu...@google.com.

hu...@google.com <hu...@google.com> #2Dec 11, 2024 11:54AM

Marked as fixed.

fwiw: I've seen (variations of) this very small difference in various apps:

│ │ ├── j$/util/Collection$-EL.class
│ │ │ ├── procyon -ec {}
│ │ │ │ @@ -1,14 +1,14 @@
│ │ │ │
│ │ │ │  package j$.util;
│ │ │ │
│ │ │ │  import java.util.Comparator;
│ │ │ │  import java.util.Set;
│ │ │ │ -import java.util.List;
│ │ │ │  import java.util.SortedSet;
│ │ │ │ +import java.util.List;
│ │ │ │  import java.util.LinkedHashSet;
│ │ │ │  import java.util.Iterator;
│ │ │ │  import java.util.Objects;
│ │ │ │  import j$.util.function.Consumer;
│ │ │ │  import java.util.Collection;
│ │ │ │  import java.util.OptionalLong;
│ │ │ │  import java.util.OptionalInt;
│ │ │ │ @@ -142,20 +142,20 @@
│ │ │ │              return ((j$.util.Collection)collection).spliterator();
│ │ │ │          }
│ │ │ │          if (collection instanceof LinkedHashSet) {
│ │ │ │              final LinkedHashSet obj = (LinkedHashSet)collection;
│ │ │ │              Objects.requireNonNull(obj);
│ │ │ │              return (Spliterator)new Spliterators$IteratorSpliterator((Collection)obj, 17);
│ │ │ │          }
│ │ │ │ +        if (collection instanceof List) {
│ │ │ │ +            return List$-CC.$default$spliterator((List)collection);
│ │ │ │ +        }
│ │ │ │          if (collection instanceof SortedSet) {
│ │ │ │              final SortedSet set = (SortedSet)collection;
│ │ │ │              return (Spliterator)new SortedSet$1(set, (Collection)set, 21);
│ │ │ │          }
│ │ │ │ -        if (collection instanceof List) {
│ │ │ │ -            return List$-CC.$default$spliterator((List)collection);
│ │ │ │ -        }
│ │ │ │          if (collection instanceof Set) {
│ │ │ │              return Set$-CC.$default$spliterator((Set)(SortedSet)collection);
│ │ │ │          }
│ │ │ │          return Collection$-CC.$default$spliterator(collection);
│ │ │ │      }
│ │ │ │  }

an...@google.com <an...@google.com> #3Dec 16, 2024 07:32PM

Hey Clement, do you have any ideas on producing different dex files from build to build?

da...@gmail.com <da...@gmail.com> #4Dec 29, 2024 04:21PM

The example shown above matches a non deterministic issue we had in L8 for classes ending with $-EL. This issue should be fixed on tip of tree. If you can reproduce on ToT let us know, I'll work on another fix. If the changes include something else than ordering inside the $-EL methods, let us know too, that would need to be fixed.