Status Update
No update yet.
Comments
jl...@google.com
Branch: androidx-master-dev
commit 01e6286fba92911346fa8cb2efd9bd024f18e11d
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri Oct 30 18:20:15 2020
Adds androidx.compose.material.AmbientContentColor to replace androidx.compose.foundation.AmbientContentColor
Content color is a design system specific concept, and so the foundation
AmbientContentColor will be deprecated and replaced with the new material one.
Bug:
Test: updateApi
Relnote: "Adds androidx.compose.material.AmbientContentColor to replace androidx.compose.foundation.AmbientContentColor"
Change-Id: I84f7be83a15ed02b301c3d9d0e44481ebb01ddb0
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/ContentColor.kt
ms...@ramp.com
Branch: androidx-master-dev
commit dea1c5dc2c9b8ed70e5c0c617cb9f96fa92335c1
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri Oct 30 20:56:57 2020
Deprecates foundation content color and text style ambients, replacing them with Material theming ambients
Bug:
Test: updateApi
Relnote: "The foundation AmbientTextStyle, ProvideTextStyle, and AmbientContentColor have been deprecated. Instead use the new versions available in the Material library. For non-Material applications, you should instead create your own design system specific theming ambients that can be consumed in your own components."
Change-Id: I74accf7166eaca28e9e2d14402ed08d80f8625ab
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimateContentSizeDemo.kt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/AnimationModifierSample.kt
M compose/desktop/desktop/src/jvmTest/kotlin/androidx/compose/desktop/ParagraphTest.kt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ListDemos.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionStateSample.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BaseTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/ContentColor.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Icon.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Text.kt
M compose/integration-tests/demos/src/main/java/androidx/compose/integration/demos/DemoFilter.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ListSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/AppBarTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ButtonTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/EmphasisTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MenuTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SurfaceContentColorTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AppBar.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Button.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Colors.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Emphasis.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/FloatingActionButton.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Icon.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ListItem.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/MaterialTheme.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Snackbar.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Surface.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ripple/RippleTheme.kt
jl...@google.com
Hi Matt,
Allowlist processing already accounts for subdomain matching.
Does the domain(s) having the third-party cookies issues are all under app.ramp.com or ramp.com?
Thanks
ms...@ramp.com
On Mon, Nov 25, 2024 at 9:47 AM <buganizer-system@google.com> wrote:
--
—
Matt Shalhoub
Senior Technical Program Manager, Ramp
28 W 23rd St, New York, NY 10010
ms...@ramp.com
are being impacted by the third party cookie dependency change. Can you
confirm if (1) we'd need to exempt any other domains and (2) if these
exemptions should resolve the issues we are seeing?
[image: image.png]
[image: image.png]
On Mon, Nov 25, 2024 at 9:51 AM Matthew Shalhoub <mshalhoub@ramp.com> wrote:
--
—
Matt Shalhoub
Senior Technical Program Manager, Ramp
28 W 23rd St, New York, NY 10010
jl...@google.com
Hi Matt,
I don't see the attached images.(you can also try to attach as a restricted comment - see the eye + lock icon).
Following are guidelines how to reproduce:
To help reproduce the breakage on our end, please provide us with the necessary test login credentials or a test 1P site (or a “sandbox demo” environment such as
Any sensitive details (such as test login credentials) can be shared using the “Restrict this comment/attachment” feature. Look for the eye+lock icon below the comment box when responding to the ticket on issuetracker.google.com.
If the above are not possible, please provide a single screen recording that shows all of the following steps:
- User journey with third-party cookies enabled
- Disable third-party cookies by enabling the 'test-third-party-cookie-phaseout' flag and disabling the 'tpcd-metadata-grants' flag from chrome://flags (
learn more - User journey with third-party cookies disabled
- Developer console debug output showing which third-party cookie is causing breakage using the
Chrome DevTools Issues tab
ms...@ramp.com Restricted
jl...@google.com
Hi Matt, thanks for attaching those files!
The images indicate that you may have third-party cookies related breakages.(It would be beneficial to do a proper reproduce).
In the meantime the exemptions with be relevant to any cookies related to the top-level domain(ramp.com and the relevant sub-domains).
You can find below relevant information as regarding to next steps:
ramp.com has been added to our
Explore removing third-party cookie dependencies using our purpose-built web APIs. The Google Chrome team's
Ask questions and get further guidance on the
ms...@ramp.com
Do you have an email address of a user we can invite to our platform for proper reproduction steps?
ms...@ramp.com Restricted+
ms...@ramp.com Restricted+
jl...@google.com
Thanks for providing the details, Matt!
Since this website qualifies for an exemption we don't need reproduce steps as part of this issue.
As I mentioned above. Following is the relevant information for your next steps:
ramp.com has been added to our
Explore removing third-party cookie dependencies using our purpose-built web APIs. The Google Chrome team's
Ask questions and get further guidance on the
Description
You cannot - it's behind a paywall.