ActivityNavigator does not use NavTypes to encode arguments [383616432]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Dec 11, 2024 11:21PM

Component used: Navigation

Version used: 2.8.5

When ActivityNavigator fills in the intent.data, it seems to directly call Uri.encode(args[argName].toString()), thus bypassing any of the NavType specific logic for serializing the value into a String.

Comments

jb...@google.com <jb...@google.com> Dec 13, 2024 11:16PM

Reassigned to cl...@google.com.

cl...@google.com <cl...@google.com> Jan 7, 2025 12:06AM

Accepted by cl...@google.com.

ap...@google.com <ap...@google.com> #2Jan 7, 2025 01:09AM

Hey Doris, any ideas on where this random animation could be coming from?

cl...@google.com <cl...@google.com> #3Jan 7, 2025 06:56PM

Marked as fixed.

Re comment #1,

I tried the repro project locally. I was not able to reproduce in the the tip of tree compose code base, after dozens of attempts. It's possible the issue has been fixed recently.

Could you try the latest androidx snapshot here: https://androidx.dev/snapshots/builds and let us know if you still see the issue?

na...@google.com <na...@google.com> #4Jan 29, 2025 06:12PM

Hi! Thank you for checking into it and giving it a try.

Unfortunately, the issue is still reproducible with snapshot 12123985, 2.8.0-SNAPSHOT for navigation, and 1.8.0-SNAPSHOT for compose.

I've pushed an update containing SNAPSHOT dependencies and automated reproduction attempts: https://github.com/smelfungus/NavHostAnimationIssue

Now, it's sufficient to launch the application and wait.

Here's a new video: https://drive.google.com/file/d/1q3C3ErIzPbTdfLsZH85KgPGNqmL-h1MN/view?usp=sharing

Issue 383616432