canvas node module and Google Cloud Functions [38478412]

WAI

Feature Request

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 21, 2017 07:23AM

I am trying to create a Google Cloud Function that generates an image from text.

I've used this Canvas node module

(had to install these dependencies on Mac to run it locally)

brew install pkg-config cairo pango libpng jpeg giflib
My package.json looks like this:

"dependencies": {
"canvas": "^1.6.5"
}
While trying to deploy it as a Function to Google cloud I am getting this error (seems like there are missing dependencies on the remote container)

Copying file:///var/folders/rq/jqlbr35d6gg3_bjhwgzdjm3m0000gn/T/tmpsuL8lN/fun.zip [Content-Type=application/zip]...
- [1 files][ 722.0 B/ 722.0 B]
Operation completed over 1 objects/722.0 B.
Waiting for operation to finish...failed.
Deploying function (may take a while - up to 2 minutes)...failed.
ERROR: (gcloud.beta.functions.deploy) OperationError: code=3, message=Build failed: exit status 1

> canvas@1.6.5 install /workspace/node_modules/canvas
> node-gyp rebuild

./util/has_lib.sh: 31: ./util/has_lib.sh: pkg-config: not found
gyp: Call to './util/has_lib.sh freetype' returned exit status 0 while in binding.gyp. while trying to load binding.gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack at ChildProcess.onCpExit (/nodejs/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:305:16)
gyp ERR! stack at emitTwo (events.js:106:13)
gyp ERR! stack at ChildProcess.emit (events.js:191:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Linux 4.4.0-78-generic
gyp ERR! command "/nodejs/bin/node" "/nodejs/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /workspace/node_modules/canvas
gyp ERR! node -v v6.9.1
gyp ERR! node-gyp -v v3.4.0
gyp ERR! not ok
npm WARN img@1.0.0 No description
npm WARN img@1.0.0 No repository field.
npm ERR! Linux 4.4.0-78-generic
npm ERR! argv "/nodejs/bin/node" "/nodejs/bin/npm" "--global-style" "--production" "--fetch-retries=5" "--fetch-retry-factor=2" "--fetch-retry-mintimeout=1000" "install" "/workspace"
npm ERR! node v6.9.1
npm ERR! npm v3.10.8
npm ERR! code ELIFECYCLE

npm ERR! canvas@1.6.5 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the canvas@1.6.5 install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the canvas package,

Comments

bl...@google.com <bl...@google.com> Jun 14, 2017 01:56PM

Assigned to rs...@google.com.

rs...@google.com <rs...@google.com> #2Jun 19, 2017 11:21AM

Thank you very much for reporting this issue, Jack. Looks like the issue is caused by somewhat unnecessary and contrived logic in apksigner.bat, which is special-casing -J* parameters. Unfortunately, this logic doesn't handle whitespace containing parameters, even those which aren't -J*.

I've uploaded a tentative fix

https://android-review.googlesource.com/#/c/394238/ for review. The patched apksigner.bat is attached. This fixes the issue on my Windows 10 box.

Jack, please test the fix in your environment and let us know whether it works for you too.

rs...@google.com <rs...@google.com> Jul 31, 2017 09:10AM

Status: New

ya...@google.com <ya...@google.com> Sep 1, 2017 02:10PM

Assigned to gc...@google.com.

mo...@google.com <mo...@google.com> #3Apr 12, 2018 08:34AM

Status: Won't Fix (Intended Behavior)

Confirmed, that fix works. Thank you for the quick turn-around on this.

sm...@gmail.com <sm...@gmail.com> #4Apr 16, 2018 07:09PM

Project: platform/tools/apksig
Branch: master

commit b293b2087837853e32a1cff008d58644dbbd4cc2
Author: Alex Klyubin <klyubin@google.com>
Date: Wed May 10 16:53:25 2017

Handle whitespace when removing -J* parameters in .bat

apksigner.bat contains special logic for -J* parameters. This logic
was not designed to handle parameters containing whitespace. This
commit fixes the issue. It is unclear whether this -J* logic is even
needed. So, if it keeps breaking stuff, we should probably simply
remove it.

Test: apksigner sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bug apksigner test" nonexistent.apk
Fails with FileNotFoundException instead of "a was unexpected at this time"
Bug: 38132450

Change-Id: Ice3294e9993b075533c77d94eb870cfd35a65bbc

M etc/apksigner.bat

https://android-review.googlesource.com/394238

https://goto.google.com/android-sha1/b293b2087837853e32a1cff008d58644dbbd4cc2

Issue 38478412