3PC Breakage Report: Connection breaks randomly because of AWS cookies are not accepted - handled as third party cookies [389003660]

Obsolete

Bug

Status Update

No update yet.

Description

ay...@google.com

created issue on behalf of bu...@gmail.com #1

Jan 10, 2025 08:48AM

Thank you for submitting a 3PCD Breakage Report! To help reproduce the breakage on our end, please provide us with the necessary test login credentials or a test 1P site (or a “sandbox demo” environment such as glitch.com or JS Fiddle or Project IDX).

Any sensitive details (such as test login credentials) can be shared using the “Restrict this comment/attachment” feature. Look for the eye+lock icon below the comment box.

If the above are not possible, please provide a single screen recording that shows all of the following steps:

User journey with third-party cookies enabled
Disable third-party cookies by enabling the 'test-third-party-cookie-phaseout' flag and disabling the 'tpcd-metadata-grants' flag (learn more)
User journey with third-party cookies disabled
Developer console debug output showing which third-party cookie is causing breakage using the Chrome DevTools Issues tab

Comments

bu...@gmail.com <bu...@gmail.com> #2Jan 10, 2025 09:40AM

Hi Jomo, can you take a look at this one?

olympe.mp4

22 MB

Download

bu...@gmail.com <bu...@gmail.com> #3Jan 10, 2025 04:31PM

Currently we are filtering the flags. Maybe we should just allow -C as well?

ra...@google.com <ra...@google.com> #4Jan 15, 2025 02:03PM

It would be great if -C can be allowed.

CMake is evolving. Recently support for log levels was introduced. With filtering cannot pass --log-level=VERBOSE into CMake.

Isn't blacklisting -G, -S, -B and a few others a better approach? Plugin can emit a warning/error if user try to override one of them. Message will help developers to correct script files and prevent half-baked builds from happening.

As for scope of this issue, I'm totally fine with -C being allowed.

be...@google.com <be...@google.com> #5Jan 17, 2025 09:58PM

Reassigned to bu...@gmail.com.

I would love to move forward and you're able to help me with that.

Any chance for this to be solved in near future?

pr...@google.com <pr...@google.com> #6Jan 22, 2025 07:51AM

Like in school. The best way to get a silence is to ask a question. :D

pr...@google.com <pr...@google.com> #7Jan 27, 2025 07:52AM

:D
It looks like a bug to me. I think it's related to the fact that we don't append arguments to the result here:

https://android.googlesource.com/platform/tools/base/+/studio-master-dev/build-system/gradle-core/src/main/java/com/android/build/gradle/internal/cxx/settings/CxxAbiModelCMakeSettingsRewriter.kt#246

be...@google.com <be...@google.com> #8Feb 7, 2025 10:09PM

I submitted a fix for this and it should first appear in Android Studio 4.2 beta 1. When that goes out, you may be able to just change your root build.gradle to point at that version of the Android Gradle plugin in maven and try building from the command-line. Or you can download the full Android Studio beta 1 and try it out.

All flags should be passable now, even ones like -G or -N that are likely to result in an unstable or unusable project. So, it's caveat emptor for now and I'll disallow some flags if that turns out to be too problematic.

(internal reference ag/a5f1a02d3faa4e41bacf1885efc3581c36c5c9fe)

pr...@google.com <pr...@google.com> #9Feb 12, 2025 07:55AM

I will test it on my machine and wait for full release to bump on build agents.

Thank you very much!

pr...@google.com <pr...@google.com> #10Feb 17, 2025 07:56AM

Hello. I would like to get you know than in Gradle plugin 4.2.1 -C is still removed from CMake command line.

pr...@google.com <pr...@google.com> #11Apr 21, 2025 05:10AM

Status: Won't Fix (Obsolete)

I confirmed the change didn't make it into 4.2.1 but it is in Arctic Fox Beta 3.