Status Update
No update yet.
Comments
sg...@google.com
sg...@google.com
We're seeing a similar error in our code. Appears to be a combination of AGP 8.6.0 and Kotlin 2 needed to hit it.
private fun Intent.stripUnwantedFlags() {
// Explicitly remove the new task and clear task flags (Our browser activity is a single
// task activity and we never want to start a second task here).
flags = flags and Intent.FLAG_ACTIVITY_NEW_TASK.inv()
flags = flags and Intent.FLAG_ACTIVITY_CLEAR_TASK.inv()
// IntentReceiverActivity is started with the "excludeFromRecents" flag (set in manifest). We
// do not want to propagate this flag from the intent receiver activity to the browser.
flags = flags and Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS.inv()
}
All 3 lines then hit:
Must be one or more of: Intent.FLAG_GRANT_READ_URI_PERMISSION, Intent.FLAG_GRANT_WRITE_URI_PERMISSION, Intent.FLAG_FROM_BACKGROUND, Intent.FLAG_DEBUG_LOG_RESOLUTION, Intent.FLAG_EXCLUDE_STOPPED_PACKAGES, Intent.FLAG_INCLUDE_STOPPED_PACKAGES, Intent.FLAG_GRANT_PERSISTABLE_URI_PERMISSION, Intent.FLAG_GRANT_PREFIX_URI_PERMISSION, Intent.FLAG_ACTIVITY_MATCH_EXTERNAL, Intent.FLAG_ACTIVITY_NO_HISTORY, Intent.FLAG_ACTIVITY_SINGLE_TOP, Intent.FLAG_ACTIVITY_NEW_TASK, Intent.FLAG_ACTIVITY_MULTIPLE_TASK, Intent.FLAG_ACTIVITY_CLEAR_TOP, Intent.FLAG_ACTIVITY_FORWARD_RESULT, Intent.FLAG_ACTIVITY_PREVIOUS_IS_TOP, Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS, Intent.FLAG_ACTIVITY_BROUGHT_TO_FRONT, Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED, Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NEW_DOCUMENT, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NO_USER_ACTION, Intent.FLAG_ACTIVITY_REORDER_TO_FRONT, Intent.FLAG_ACTIVITY_NO_ANIMATION, Intent.FLAG_ACTIVITY_CLEAR_TASK, Intent.FLAG_ACTIVITY_TASK_ON_HOME, Intent.FLAG_ACTIVITY_RETAIN_IN_RECENTS, Intent.FLAG_ACTIVITY_LAUNCH_ADJACENT, Intent.FLAG_ACTIVITY_REQUIRE_NON_BROWSER, Intent.FLAG_ACTIVITY_REQUIRE_DEFAULT, Intent.FLAG_RECEIVER_REGISTERED_ONLY, Intent.FLAG_RECEIVER_REPLACE_PENDING, Intent.FLAG_RECEIVER_FOREGROUND, Intent.FLAG_RECEIVER_NO_ABORT, Intent.FLAG_RECEIVER_VISIBLE_TO_INSTANT_APPS
sg...@google.com
The initial report (
However,
sg...@google.com
Thanks for fixing! What release should we be able to verify the fix in? And is there any chance of a backport for 8.6.1?
ap...@google.com
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Ladybug Feature Drop | 2024.2.2 Canary 2
- Android Gradle Plugin 8.8.0-alpha02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
ap...@google.com
The fixes for this issue are now also available in:
- Android Studio Ladybug | 2024.2.1 RC 1
- Android Gradle Plugin 8.7.0-rc01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
ap...@google.com
Project: r8
Branch: 8.9
Author: Søren Gjesse <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of b/395489597
R=christofferqa@google.com
Bug: b/395489597
Change-Id: If769fae5db93ee8e2cfc1cf9feeddd847b00832b
Files:
- A
src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java
Hash: 49cade9501045641cf63bca54ab15728ea95f16d
Date: Wed Feb 12 13:57:05 2025
ap...@google.com
Project: r8
Branch: 8.8
Author: Søren Gjesse <
Link:
Don't use aliased values when comparing values for basic block subsumption
Expand for full commit details
Don't use aliased values when comparing values for basic block subsumption
Aliased values can be defined by semantically different assume instructions and then the resulting value chosen can have
information which does not correctly represent both values.
R=christofferqa@google.com
Fixes: b/395489597
Change-Id: Ieaeb4fbf8d49cdc60d2912791cc2b701d42d2b34
Files:
- M
src/main/java/com/android/tools/r8/ir/analysis/equivalence/BasicBlockBehavioralSubsumption.java - M
src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java
Hash: e7d78e09612fe9f67730cddc22cf03798a1ddd38
Date: Wed Feb 12 15:02:14 2025
ap...@google.com
Project: r8
Branch: 8.8
Author: Søren Gjesse <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of b/395489597
R=christofferqa@google.com
Bug: b/395489597
Change-Id: If769fae5db93ee8e2cfc1cf9feeddd847b00832b
Files:
- A
src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java
Hash: 7697806c5d5f04330289dca95a11b755ed05e691
Date: Wed Feb 12 15:01:41 2025
ap...@google.com
Project: r8
Branch: 8.8
Author: Søren Gjesse <
Link:
Version 8.8.34
Expand for full commit details
Version 8.8.34
R=christofferqa@google.com
Bug: b/395489597
Change-Id: I2475873aa690ee588f913f12d21dbf16e07c0468
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: e4c4b8c78485b4b879001e60600d9ef799083345
Date: Wed Feb 12 15:02:22 2025
ap...@google.com
Project: r8
Branch: 8.7
Author: Søren Gjesse <
Link:
Version 8.7.34
Expand for full commit details
Version 8.7.34
R=christofferqa@google.com
Bug: b/395489597
Change-Id: I4946bdfc811a0211119532ed2b23f737ff5668c3
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: 44d960a65196e49153711487c3f24793ded7c057
Date: Wed Feb 12 15:03:02 2025
ap...@google.com
Project: r8
Branch: 8.7
Author: Søren Gjesse <
Link:
Don't use aliased values when comparing values for basic block subsumption
Expand for full commit details
Don't use aliased values when comparing values for basic block subsumption
Aliased values can be defined by semantically different assume instructions and then the resulting value chosen can have
information which does not correctly represent both values.
R=christofferqa@google.com
Fixes: b/395489597
Change-Id: Ieaeb4fbf8d49cdc60d2912791cc2b701d42d2b34
Files:
- M
src/main/java/com/android/tools/r8/ir/analysis/equivalence/BasicBlockBehavioralSubsumption.java - M
src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java
Hash: 57e30e3ab2df1593c339d6fafa4b9c5162dad653
Date: Wed Feb 12 15:02:55 2025
ap...@google.com
Project: r8
Branch: 8.7
Author: Søren Gjesse <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of b/395489597
R=christofferqa@google.com
Bug: b/395489597
Change-Id: If769fae5db93ee8e2cfc1cf9feeddd847b00832b
Files:
- A
src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java
Hash: ede31119cc4b72e116e3ddbf3bd6d246ee7baff8
Date: Wed Feb 12 15:02:48 2025
sg...@google.com
This fix will make it into one of the next AGP alpha versions (most likely 8.10.0-alpha06 or 8.10.0-alpha06). Until that one can use R8 version 8.10.8-dev, see
an...@google.com
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Meerkat | 2024.3.1 RC 2
- Android Gradle Plugin 8.9.0-rc02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
an...@google.com
The fixes for this issue are now also available in:
- Android Studio Ladybug Feature Drop | 2024.2.2 Patch 2
- Android Gradle Plugin 8.8.2
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Description
When minifying a project that uses Leanback (View-based) with the version of R8 that is included with AGP 8.10.0-alpha04, I get the crash that is included below.
This only happens when
minifyEnabledis set totrueanddebuggableis set tofalse.If I use AGP 8.8.0 then the app doesn't crash.
I have attached a project that can be used to reproduce the issue (it's basically the Leanback template that's in Android Studio with some small modifications).
Crash log: