Leanback crashes when minified with R8 included in AGP 8.10.0-alpha04 [395489597]

Fixed

Bug

Status Update

No update yet.

Description

st...@gmail.com

created issue #1

Feb 10, 2025 12:20PM

When minifying a project that uses Leanback (View-based) with the version of R8 that is included with AGP 8.10.0-alpha04, I get the crash that is included below.

This only happens when minifyEnabled is set to true and debuggable is set to false.

If I use AGP 8.8.0 then the app doesn't crash.

I have attached a project that can be used to reproduce the issue (it's basically the Leanback template that's in Android Studio with some small modifications).

Crash log:

FATAL EXCEPTION: main
Process: com.example.myapplication, PID: 18548
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object android.util.SparseArray.get(int)' on a null object reference
	at android.view.View.dispatchRestoreInstanceState(View.java:22249)
	at android.view.ViewGroup.dispatchRestoreInstanceState(ViewGroup.java:4028)
	at android.view.ViewGroup.dispatchRestoreInstanceState(ViewGroup.java:4034)
	at android.view.View.restoreHierarchyState(View.java:22232)
	at kotlin.properties.NotNullVar.addItem(Unknown Source:95)
	at androidx.leanback.widget.SingleRow.appendVisibleItems(Unknown Source:137)
	at androidx.leanback.widget.Grid.appendOneColumnVisibleItems(Unknown Source:11)
	at androidx.leanback.widget.GridLayoutManager.onLayoutChildren(Unknown Source:1061)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(Unknown Source:73)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayout(Unknown Source:71)
	at androidx.recyclerview.widget.RecyclerView.onLayout(Unknown Source:7)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at androidx.leanback.widget.ScaleFrameLayout.onLayout(Unknown Source:236)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
	at com.android.internal.policy.DecorView.onLayout(DecorView.java:789)
	at android.view.View.layout(View.java:24421)
	at android.view.ViewGroup.layout(ViewGroup.java:6440)
	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4258)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3583)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2465)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:9305)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1339)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1348)
	at android.view.Choreographer.doCallbacks(Choreographer.java:952)
	at android.view.Choreographer.doFrame(Choreographer.java:882)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1322)
	at android.os.Handler.handleCallback(Handler.java:958)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:205)
	at android.os.Looper.loop(Looper.java:294)
	at android.app.ActivityThread.main(ActivityThread.java:8177)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

LeanbackCrash.zip

114 KB

Download

Comments

sg...@google.com <sg...@google.com> Feb 10, 2025 12:26PM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> #2Feb 10, 2025 04:08PM

The attached Build Scan log shows that the emulator process crashed unexpectedly. Could you rerun your task with --info and -Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true to get more information about the emualtor process logs?

sg...@google.com <sg...@google.com> #3Feb 11, 2025 04:28PM

https://scans.gradle.com/s/llyxjwf4ipuzc

sg...@google.com <sg...@google.com> #4Feb 12, 2025 09:37AM

No idea why the scan does not contain log information, here you are: https://productionresultssa13.blob.core.windows.net/actions-results/3ec7e316-56eb-4f55-a7dd-511a2f3cf729/workflow-job-run-2623c0b7-dd66-5503-5665-c65c84dbf243/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-04-02T20%3A32%3A33Z&sig=Z1BPg7s513VC7nKkyGYEmknivAGxlX3Kdx0NsX%2BttW8%3D&sp=r&spr=https&sr=b&st=2024-04-02T20%3A22%3A28Z&sv=2021-12-02

sg...@google.com <sg...@google.com> #5Feb 12, 2025 10:32AM

The link in comment#4 seems not to be working for me. I got "AuthenticationFailed" error. If you run task with those --info and -Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true, the emulator process output its kernel logging to stdout. Do you see any stacktrace or segfault in the log?

ap...@google.com <ap...@google.com> #6Feb 12, 2025 11:35AM

That's strange, the repo and the build is public... But I attached the logs as file

ap...@google.com <ap...@google.com> #7Feb 12, 2025 12:27PM

Marked as fixed.

I looked into the logs and it turns out, the runner didn't have enough disk space. I guess the root cause is the Gradle update causing another Gradle major version (and its new transform-4) folder to cache was too much. Anyway, a better error message of the exit code of GMD would be helpful.

ap...@google.com <ap...@google.com> #8Feb 12, 2025 01:59PM

Thanks for uploading the log! Yes, the emulator kernel log says the issue was the insufficient disk space: 2024-04-02T18:31:45.7078429Z ERROR | Not enough space to create userdata partition. Available: 7177.027344 MB at /home/runner/.config/.android/avd/gradle-managed/dev34_aosp_atd_x86_64_Pixel_2.avd, need 7372.800000 MB.

Also, I agreed that GMD should diagnose errors and can provide better messages.

Let me rename this issue's title to improve the error message for disk space error.

ap...@google.com <ap...@google.com> #9Feb 12, 2025 01:59PM

I've added a fix that will surface all error messages from the emulator in the exception when it closes unexpectedly.

ap...@google.com <ap...@google.com> #10Feb 12, 2025 01:59PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat | 2024.3.1 Canary 2
Android Gradle Plugin 8.9.0-alpha02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ap...@google.com <ap...@google.com> #11Feb 12, 2025 03:28PM

Project: r8
Branch: 8.8
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/101502

Don't use aliased values when comparing values for basic block subsumption

Expand for full commit details

Don't use aliased values when comparing values for basic block subsumption 
 
Aliased values can be defined by semantically different assume instructions  and then the resulting value chosen can have 
information which does not correctly represent both values. 
 
R=christofferqa@google.com 
 
Fixes: b/395489597 
Change-Id: Ieaeb4fbf8d49cdc60d2912791cc2b701d42d2b34

Files:

M src/main/java/com/android/tools/r8/ir/analysis/equivalence/BasicBlockBehavioralSubsumption.java
M src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java

Hash: e7d78e09612fe9f67730cddc22cf03798a1ddd38
Date: Wed Feb 12 15:02:14 2025

ap...@google.com <ap...@google.com> #12Feb 12, 2025 03:28PM

Project: r8
Branch: 8.8
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/101484

Add reproduction of b/395489597

Expand for full commit details

Add reproduction of b/395489597 
 
R=christofferqa@google.com 
 
Bug: b/395489597 
Change-Id: If769fae5db93ee8e2cfc1cf9feeddd847b00832b

Files:

A src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java

Hash: 7697806c5d5f04330289dca95a11b755ed05e691
Date: Wed Feb 12 15:01:41 2025

ap...@google.com <ap...@google.com> #13Feb 12, 2025 03:29PM

Project: r8
Branch: 8.8
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/101503

Version 8.8.34

Expand for full commit details

Version 8.8.34 
 
R=christofferqa@google.com 
 
Bug: b/395489597 
Change-Id: I2475873aa690ee588f913f12d21dbf16e07c0468

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: e4c4b8c78485b4b879001e60600d9ef799083345
Date: Wed Feb 12 15:02:22 2025

ap...@google.com <ap...@google.com> #14Feb 12, 2025 05:28PM

Project: r8
Branch: 8.7
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/101485

Version 8.7.34

Expand for full commit details

Version 8.7.34 
 
R=christofferqa@google.com 
 
Bug: b/395489597 
Change-Id: I4946bdfc811a0211119532ed2b23f737ff5668c3

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 44d960a65196e49153711487c3f24793ded7c057
Date: Wed Feb 12 15:03:02 2025

ap...@google.com <ap...@google.com> #15Feb 12, 2025 05:28PM

Project: r8
Branch: 8.7
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/101505

Don't use aliased values when comparing values for basic block subsumption

Expand for full commit details

Don't use aliased values when comparing values for basic block subsumption 
 
Aliased values can be defined by semantically different assume instructions  and then the resulting value chosen can have 
information which does not correctly represent both values. 
 
R=christofferqa@google.com 
 
Fixes: b/395489597 
Change-Id: Ieaeb4fbf8d49cdc60d2912791cc2b701d42d2b34

Files:

M src/main/java/com/android/tools/r8/ir/analysis/equivalence/BasicBlockBehavioralSubsumption.java
M src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java

Hash: 57e30e3ab2df1593c339d6fafa4b9c5162dad653
Date: Wed Feb 12 15:02:55 2025

ap...@google.com <ap...@google.com> #16Feb 12, 2025 05:28PM

Project: r8
Branch: 8.7
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/101504

Add reproduction of b/395489597

Expand for full commit details

Add reproduction of b/395489597 
 
R=christofferqa@google.com 
 
Bug: b/395489597 
Change-Id: If769fae5db93ee8e2cfc1cf9feeddd847b00832b

Files:

A src/test/java/com/android/tools/r8/deadcode/DifferentAssumptionsOnReturnValuesTest.java

Hash: ede31119cc4b72e116e3ddbf3bd6d246ee7baff8
Date: Wed Feb 12 15:02:48 2025

sg...@google.com <sg...@google.com> #17Feb 17, 2025 02:56PM

This fix will make it into one of the next AGP alpha versions (most likely 8.10.0-alpha06 or 8.10.0-alpha06). Until that one can use R8 version 8.10.8-dev, see Replacing R8 in Android Gradle plugin for details.

an...@google.com <an...@google.com> #18Feb 18, 2025 01:59PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat | 2024.3.1 RC 2
Android Gradle Plugin 8.9.0-rc02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #19Feb 26, 2025 05:51PM

The fixes for this issue are now also available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Patch 2
Android Gradle Plugin 8.8.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Issue 395489597

Description

Issue summary

Comments

sg...@google.com <sg...@google.com> Feb 10, 2025 12:26PM

sg...@google.com <sg...@google.com> #2Feb 10, 2025 04:08PM

sg...@google.com <sg...@google.com> #3Feb 11, 2025 04:28PM

sg...@google.com <sg...@google.com> #4Feb 12, 2025 09:37AM

sg...@google.com <sg...@google.com> #5Feb 12, 2025 10:32AM

ap...@google.com <ap...@google.com> #6Feb 12, 2025 11:35AM

ap...@google.com <ap...@google.com> #7Feb 12, 2025 12:27PM

ap...@google.com <ap...@google.com> #8Feb 12, 2025 01:59PM

ap...@google.com <ap...@google.com> #9Feb 12, 2025 01:59PM

ap...@google.com <ap...@google.com> #10Feb 12, 2025 01:59PM

ap...@google.com <ap...@google.com> #11Feb 12, 2025 03:28PM

ap...@google.com <ap...@google.com> #12Feb 12, 2025 03:28PM

ap...@google.com <ap...@google.com> #13Feb 12, 2025 03:29PM

ap...@google.com <ap...@google.com> #14Feb 12, 2025 05:28PM

ap...@google.com <ap...@google.com> #15Feb 12, 2025 05:28PM

ap...@google.com <ap...@google.com> #16Feb 12, 2025 05:28PM

sg...@google.com <sg...@google.com> #17Feb 17, 2025 02:56PM

an...@google.com <an...@google.com> #18Feb 18, 2025 01:59PM

an...@google.com <an...@google.com> #19Feb 26, 2025 05:51PM

Add comment

Issue metadata