"IllegalStateException: LayoutCoordinate operations are only valid when isAttached is true" when giving focus to an EditText in an AndroidView [395661471]

Assigned

Bug

Status Update

No update yet.

Description

ct...@atlassian.com

created issue #1

Feb 10, 2025 10:01PM

Jetpack Compose version: androidx.compose.ui:ui:1.8.0-alpha02

Jetpack Compose component(s) used: ui, viewinterop

Android Studio Build: 2024.2.2

Kotlin version: 2.1.0

Steps to Reproduce or Code Sample to Reproduce:

Working on a simple repro for this issue, but it seems to be related to giving focus to an EditText in an AndroidView under certain circumstances and seems liable to happen on any device.

We shipped androidx.compose.ui:ui:1.8.0-alpha08 in our latest beta to pick up some AndroidView bug fixes and are now seeing the following crashes affecting a very significant ~3% of our users so far.

The repro is very elusive, but narrowed it down to androidx.compose.ui:ui:1.8.0-alpha02 introducing the issue - very likely this change based on the trace https://android.googlesource.com/platform/frameworks/support/+/58377bb3416cc24d342dd4e5d32e4a27247734e4.

Would greatly appreciate any suggested workarounds or fixes 🙏

Stack trace (if applicable):

java.lang.IllegalStateException: LayoutCoordinate operations are only valid when isAttached is true
    at androidx.compose.ui.internal.InlineClassHelperKt.throwIllegalStateException(InlineClassHelper.kt:28)
    at androidx.compose.ui.node.NodeCoordinator.getParentLayoutCoordinates(NodeCoordinator.kt:1801)
    at androidx.compose.ui.layout.LayoutCoordinatesKt.findRootCoordinates(LayoutCoordinates.kt:253)
    at androidx.compose.ui.focus.FocusTraversalKt.focusRect(FocusTraversal.kt:158)
    at androidx.compose.ui.platform.AndroidComposeView.focusSearch(AndroidComposeView.android.kt:1022)
    at android.view.ViewGroup.focusSearch(ViewGroup.java:1074)
    at android.view.ViewGroup.focusSearch(ViewGroup.java:1074)
    at android.view.View.focusSearch(View.java:12657)
    at android.widget.TextView.onCreateInputConnection(TextView.java:8717)
    at androidx.appcompat.widget.AppCompatEditText.onCreateInputConnection(AppCompatEditText.java:270)
    at android.view.inputmethod.InputMethodManager.startInputInner(InputMethodManager.java:1927)
    at android.view.inputmethod.InputMethodManager$DelegateImpl.startInput(InputMethodManager.java:585)
    at android.view.ImeFocusController.checkFocus(ImeFocusController.java:161)
    at android.view.inputmethod.InputMethodManager.checkFocus(InputMethodManager.java:2079)
    at android.view.inputmethod.InputMethodManager.viewClicked(InputMethodManager.java:2263)
    at android.widget.TextView.viewClicked(TextView.java:13238)
    at android.widget.TextView.onTouchEvent(TextView.java:11124)
    at android.view.View.dispatchTouchEvent(View.java:14360)
    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118)
    at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2799)
    at androidx.compose.ui.input.pointer.PointerInteropFilter_androidKt$pointerInteropFilter$3.invoke(PointerInteropFilter.android.kt:110)
    at androidx.compose.ui.input.pointer.PointerInteropFilter_androidKt$pointerInteropFilter$3.invoke(PointerInteropFilter.android.kt:102)
    at androidx.compose.ui.input.pointer.PointerInteropFilter$pointerInputFilter$1$dispatchToView$3.invoke(PointerInteropFilter.android.kt:299)
    at androidx.compose.ui.input.pointer.PointerInteropFilter$pointerInputFilter$1$dispatchToView$3.invoke(PointerInteropFilter.android.kt:283)
    at androidx.compose.ui.input.pointer.PointerInteropUtils_androidKt.toMotionEventScope-ubNVwUQ(PointerInteropUtils.android.kt:72)
    at androidx.compose.ui.input.pointer.PointerInteropUtils_androidKt.toMotionEventScope-d-4ec7I(PointerInteropUtils.android.kt:32)
    at androidx.compose.ui.input.pointer.PointerInteropFilter$pointerInputFilter$1.dispatchToView(PointerInteropFilter.android.kt:283)
    at androidx.compose.ui.input.pointer.PointerInteropFilter$pointerInputFilter$1.onPointerEvent-H0pRuoY(PointerInteropFilter.android.kt:222)
    at androidx.compose.ui.node.BackwardsCompatNode.onPointerEvent-H0pRuoY(BackwardsCompatNode.kt:349)
    at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:371)
    at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:377)
    at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:377)
    at androidx.compose.ui.input.pointer.Node.dispatchMainEventPass(HitPathTracker.kt:377)
    at androidx.compose.ui.input.pointer.NodeParent.dispatchMainEventPass(HitPathTracker.kt:230)
    at androidx.compose.ui.input.pointer.HitPathTracker.dispatchChanges(HitPathTracker.kt:154)
    at androidx.compose.ui.input.pointer.PointerInputEventProcessor.process-BIzXfog(PointerInputEventProcessor.kt:117)
    at androidx.compose.ui.platform.AndroidComposeView.sendMotionEvent-8iAsVTc(AndroidComposeView.android.kt:2351)
    at androidx.compose.ui.platform.AndroidComposeView.handleMotionEvent-8iAsVTc(AndroidComposeView.android.kt:2301)
    at androidx.compose.ui.platform.AndroidComposeView.dispatchTouchEvent(AndroidComposeView.android.kt:2172)
    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3118)

and also

androidx.compose.runtime.ComposeRuntimeError: Compose Runtime internal error. Unexpected or incorrect use of the Compose internal runtime API (pending composition has not been applied). Please report to Google or use https://goo.gle/compose-feedback
    at androidx.compose.runtime.ComposerKt.composeRuntimeError(Composer.kt:4668)
    at androidx.compose.runtime.CompositionImpl.drainPendingModificationsForCompositionLocked(Composition.kt:723)
    at androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:782)
    at androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1132)
    at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Composer.kt:4034)
    at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_release(Composer.kt:4034)
    at androidx.compose.runtime.CompositionImpl.composeInitial(Composition.kt:677)
    at androidx.compose.runtime.CompositionImpl.setContentWithReuse(Composition.kt:625)
    at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcomposeInto(SubcomposeLayout.kt:546)
    at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:514)
    at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:504)
    at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose(SubcomposeLayout.kt:490)
    at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$Scope.subcompose(SubcomposeLayout.kt:926)
    at androidx.compose.foundation.lazy.layout.LazyLayoutMeasureScopeImpl.measure-0kLqBqw(LazyLayoutMeasureScope.kt:124)
    at androidx.compose.foundation.lazy.LazyListMeasuredItemProvider.getAndMeasure-0kLqBqw(LazyListMeasuredItemProvider.kt:55)
    at androidx.compose.foundation.lazy.LazyListMeasuredItemProvider.getAndMeasure-0kLqBqw$default(LazyListMeasuredItemProvider.kt:49)
    at androidx.compose.foundation.lazy.LazyListMeasureKt.createItemsAfterList(LazyListMeasure.kt:551)
    at androidx.compose.foundation.lazy.LazyListMeasureKt.measureLazyList-LCrQqZ4(LazyListMeasure.kt:325)
    at androidx.compose.foundation.lazy.LazyListKt$rememberLazyListMeasurePolicy$1$1.invoke-0kLqBqw(LazyList.kt:352)
    at androidx.compose.foundation.lazy.LazyListKt$rememberLazyListMeasurePolicy$1$1.invoke(LazyList.kt:200)
    at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$1$2$1.invoke-0kLqBqw(LazyLayout.kt:78)
    at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$1$2$1.invoke(LazyLayout.kt:76)
    at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:754)
    at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:128)
    at androidx.compose.foundation.ScrollingContainerNode.measure-3p2s80s(ScrollingContainer.kt:234)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:190)
    at androidx.compose.foundation.lazy.layout.LazyLayoutBeyondBoundsModifierNode.measure-3p2s80s(LazyLayoutBeyondBoundsModifierLocal.kt:118)
    at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:190)
    at androidx.compose.ui.node.MeasurePassDelegate$performMeasureBlock$1.invoke(MeasurePassDelegate.kt:169)
    at androidx.compose.ui.node.MeasurePassDelegate$performMeasureBlock$1.invoke(MeasurePassDelegate.kt:168)
    at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2496)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:460)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:244)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:124)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:107)
    at androidx.compose.ui.node.MeasurePassDelegate.performMeasure-BRTryo0$ui_release(MeasurePassDelegate.kt:422)
    at androidx.compose.ui.node.MeasurePassDelegate.remeasure-BRTryo0(MeasurePassDelegate.kt:470)
    at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1212)
    at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:364)
    at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout-0kLqBqw(MeasureAndLayoutDelegate.kt:463)
    at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout-0kLqBqw(AndroidComposeView.android.kt:1553)
    at androidx.compose.ui.node.LayoutNode.forceRemeasure(LayoutNode.kt:1274)
    at androidx.compose.ui.node.LayoutModifierNodeKt.remeasureSync(LayoutModifierNode.kt:111)
    at androidx.compose.foundation.lazy.layout.LazyLayoutBeyondBoundsModifierNode.layout-o7g1Pn8(LazyLayoutBeyondBoundsModifierLocal.kt:167)
    at androidx.compose.ui.focus.BeyondBoundsLayoutKt.searchBeyondBounds--OM-vw8(BeyondBoundsLayout.kt:45)
    at androidx.compose.ui.focus.TwoDimensionalFocusSearchKt.generateAndSearchChildren-4C6V_qg(TwoDimensionalFocusSearch.kt:176)
    at androidx.compose.ui.focus.TwoDimensionalFocusSearchKt.twoDimensionalFocusSearch-sMXa3k8(TwoDimensionalFocusSearch.kt:86)
    at androidx.compose.ui.focus.TwoDimensionalFocusSearchKt.twoDimensionalFocusSearch-sMXa3k8(TwoDimensionalFocusSearch.kt:78)
    at androidx.compose.ui.focus.FocusTraversalKt.focusSearch-0X8WOeE(FocusTraversal.kt:134)
    at androidx.compose.ui.focus.FocusOwnerImpl.focusSearch-ULY8qGw(FocusOwnerImpl.kt:320)
    at androidx.compose.ui.platform.AndroidComposeView.requestFocus(AndroidComposeView.android.kt:1070)
    at android.view.ViewGroup.onRequestFocusInDescendants(ViewGroup.java:3390)
    at android.view.ViewGroup.requestFocus(ViewGroup.java:3339)
    at android.view.ViewGroup.onRequestFocusInDescendants(ViewGroup.java:3390)
    at android.view.ViewGroup.requestFocus(ViewGroup.java:3339)
    at android.view.ViewGroup.onRequestFocusInDescendants(ViewGroup.java:3390)
    at android.view.ViewGroup.requestFocus(ViewGroup.java:3339)
    at android.view.ViewGroup.onRequestFocusInDescendants(ViewGroup.java:3390)
    at android.view.ViewGroup.requestFocus(ViewGroup.java:3344)
    at android.view.View.requestFocus(View.java:15176)
    at android.view.View.requestFocus(View.java:15118)
    at android.view.View.rootViewRequestFocus(View.java:8563)
    at android.view.ViewGroup.removeAllViewsInLayout(ViewGroup.java:5833)
    at androidx.compose.ui.viewinterop.AndroidViewHolder.onDeactivate(AndroidViewHolder.android.kt:247)
    at androidx.compose.ui.node.LayoutNode.onDeactivate(LayoutNode.kt:1397)
    at androidx.compose.runtime.internal.RememberEventDispatcher.dispatchRememberObservers(RememberEventDispatcher.kt:165)
    at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:1044)
    at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:1067)
    at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke(Recomposer.kt:684)
    at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke(Recomposer.kt:591)
    at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:39)
    at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:108)
    at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
    at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1413)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1424)
    at android.view.Choreographer.doCallbacks(Choreographer.java:1024)
    at android.view.Choreographer.doFrame(Choreographer.java:949)
    at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1398)
    at android.os.Handler.handleCallback(Handler.java:991)
    at android.os.Handler.dispatchMessage(Handler.java:102)
    at android.os.Looper.loopOnce(Looper.java:232)
    at android.os.Looper.loop(Looper.java:317)
    at android.app.ActivityThread.main(ActivityThread.java:8787)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:871)

Comments

be...@google.com <be...@google.com> #2Feb 10, 2025 11:17PM

Reassigned to ra...@google.com.

Can you please double check the link to your git repository for the repro? It leads to a 404

ct...@atlassian.com <ct...@atlassian.com> #3Feb 11, 2025 05:42PM

It's my mistake.
I changed private to public.

https://github.com/DongHoon-Wooo/SplashScreen.git

Message last modified on Feb 11, 2025 09:10PM

ra...@google.com <ra...@google.com> #4Feb 20, 2025 07:34AM

After looking at the code, what surprises me is that it works on Android 12.

The correct way to achieve this is to never return false in the KeepOnScreenCondition. Otherwise, the time between the condition being false and the new activity being visible will let the splash screen activity appear

The condition is evaluated for the current view tree only, so as soon as you start the next activity, it will be ignored and the splash screen will be removed.

ct...@atlassian.com <ct...@atlassian.com> #5Feb 20, 2025 03:17PM

I'm marking this as working as intended, but please let me know if it doesn't work.

ct...@atlassian.com <ct...@atlassian.com> #6Feb 21, 2025 03:59PM

Even with the bandaid workaround we saw 1% of sessions in prod crashing with the second trace from the OP and decided to revert compose ui back to the stable BoM. Unfortunately that introduces this focus bug https://issuetracker.google.com/issues/367238588 but we decided it is the lesser evil.

Issue 395661471