Fixed
Status Update
No update yet.
Comments
pa...@google.com
Correction:
So, the end result is that usb_write() sometimes sends a ZLP when it doesn't need to
should be
So, the end result is that usb_write() sometimes sends a ZLP when it doesn't need to, and sometimes neglects to send a ZLP when it should
So, the end result is that usb_write() sometimes sends a ZLP when it doesn't need to
should be
So, the end result is that usb_write() sometimes sends a ZLP when it doesn't need to, and sometimes neglects to send a ZLP when it should
an...@google.com
an...@google.com
Note that the CHECK_LE has since been replaced with HandleError(), which causes adbd to not abort...but that stowaway amessage header is being dropped all the same...and so the behavior is pretty much undefined, I imagine. I'm not sure the switch to HandleError was a good idea, since it more or less swept the real problem under the rug.
an...@google.com
an...@google.com
an...@google.com
good bug report, thanks! i'm assuming this isn't darwin-specific either --- it looks like we have similar logic using masks in the linux and windows backends and in the libusb backend too.
I'm not sure the switch to HandleError was a good idea, since it more or less swept the real problem under the rug.
yeah, i know what you mean, but it's also hard to argue with this logic in the commit message that made that change:
These CHECKs are expected to happen if the client does the wrong thing,
so we probably shouldn't be aborting in adbd.
a CHECK in the client (as you suggested earlier) would probably have been the best idea... postel's law and all that :-)
Description
####################################################
Please provide all of the following information, otherwise we may not be able to route your bug report.
####################################################
1. Describe the bug or issue that you're seeing.
When using the "Extract String resource" editor tool, it doesn't seem to detect correct type of known functions.
Please see picture.
2. Attach log files from Android Studio
2A. In the IDE, select the Help..Collect Logs and Diagnostic Data menu option.
2B. Create a diagnostic report and save it to your local computer.
2C. Attach the report to this bug using the Add attachments button.
3. If you know what they are, write the steps to reproduce:
3A.
3B.
3C.
In addition to logs, please attach a screenshot or recording that illustrates the problem.
For more information on how to get your bug routed quickly, see
Build: AI-243.23654.117.2432.13058383, 202502130928
AS: Meerkat Feature Drop | 2024.3.2 Canary 5
AI-243.23654.117.2432.13058383, JRE 21.0.5+-13047016-b750.29x64 JetBrains s.r.o., OS Windows 11(amd64) v10.0 , screens 1920x1080 (100%), 1920x1080 (100%), 1920x1080 (100%)
Android Gradle Plugin: 8.10.0-alpha05
Gradle: 8.13
Gradle JDK: JetBrains Runtime 21.0.5
NDK: from local.properties: (not specified), latest from SDK: 28.0.13004108
CMake: from local.properties: (not specified), latest from SDK: 3.31.5, from PATH: (not found)
Source: send_feedback_icon```