Assigned
Status Update
Comments
ra...@google.com <ra...@google.com>
ra...@google.com <ra...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit d1aba6064d4c1aedfd10ec75fd8d181fcb37c947
Author: Matvei Malkov <malkov@google.com>
Date: Mon Feb 07 18:31:52 2022
Missing pieces for adaptive compose material3: drawer items
material3 provides navigation rail with items, bottom navigation with items, but the drawer without items, evven though there are specs for it.
This CL add a NavigationDrawerItem and some related APIs around it
Bug: 218286829
Test: will be added
Relnote: NavigationDrawerItem is added that represents a single destination within the drawers
Change-Id: Ic396fe99d1f26080a3e3a9d2ed505e72008c85aa
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationDrawerItemScreenshotTest.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationDrawerItemTest.kt
https://android-review.googlesource.com/1974464
Branch: androidx-main
commit d1aba6064d4c1aedfd10ec75fd8d181fcb37c947
Author: Matvei Malkov <malkov@google.com>
Date: Mon Feb 07 18:31:52 2022
Missing pieces for adaptive compose material3: drawer items
material3 provides navigation rail with items, bottom navigation with items, but the drawer without items, evven though there are specs for it.
This CL add a NavigationDrawerItem and some related APIs around it
Bug: 218286829
Test: will be added
Relnote: NavigationDrawerItem is added that represents a single destination within the drawers
Change-Id: Ic396fe99d1f26080a3e3a9d2ed505e72008c85aa
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationDrawerItemScreenshotTest.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationDrawerItemTest.kt
pr...@google.com <pr...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit ec4e83f16c8a226c381001b61679a0ff189d4dcb
Author: Matvei Malkov <malkov@google.com>
Date: Mon Feb 07 17:29:43 2022
Missing pieces for adaptive compose material3: drawers for large screens
This CL adds two different kinds of drawer specifically for large screens: permanent standard drawer and dismissible standard drawer.
Bug: 218286829
Relnote: PermanentNavigationDrawer and DismissibleNavigationDrawer have been added as experiental APIs. Those are the drawers suitable well for large screen devices.
Test: added new for new API
Change-Id: I5f8abcd6137f0819ceccae0f8cacd2a44af5ad2e
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/PermanentNavigationDrawerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/DismissibleNavigationDrawerTest.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
https://android-review.googlesource.com/1974463
Branch: androidx-main
commit ec4e83f16c8a226c381001b61679a0ff189d4dcb
Author: Matvei Malkov <malkov@google.com>
Date: Mon Feb 07 17:29:43 2022
Missing pieces for adaptive compose material3: drawers for large screens
This CL adds two different kinds of drawer specifically for large screens: permanent standard drawer and dismissible standard drawer.
Bug: 218286829
Relnote: PermanentNavigationDrawer and DismissibleNavigationDrawer have been added as experiental APIs. Those are the drawers suitable well for large screen devices.
Test: added new for new API
Change-Id: I5f8abcd6137f0819ceccae0f8cacd2a44af5ad2e
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/PermanentNavigationDrawerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/DismissibleNavigationDrawerTest.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
pr...@google.com <pr...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 7825d1e6ed228729519f9312ee73c5f4a99d5634
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 01 16:15:36 2022
Missing pieces for adaptive compose material3: drawer rename
This CL renames NavigationDrawer to ModalNavigationDrawer to better explain its modal nature, better align with the material guidelines and also leave the room for other drawers to be developeed (PermanentNavigationDrawer, Slideable/StandardNavigationDrawer).
Bug: 218286829
Test: tested demos + tested the replaceWith statemenet
Relnote: NavigationDrawer has been renamed to ModalNavigationDrawer
Change-Id: I1807d3c889c63efa7a569416daaed58d94a3b17a
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalNavigationDrawerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalNavigationDrawerScreenshotTest.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
https://android-review.googlesource.com/1966681
Branch: androidx-main
commit 7825d1e6ed228729519f9312ee73c5f4a99d5634
Author: Matvei Malkov <malkov@google.com>
Date: Tue Feb 01 16:15:36 2022
Missing pieces for adaptive compose material3: drawer rename
This CL renames NavigationDrawer to ModalNavigationDrawer to better explain its modal nature, better align with the material guidelines and also leave the room for other drawers to be developeed (PermanentNavigationDrawer, Slideable/StandardNavigationDrawer).
Bug: 218286829
Test: tested demos + tested the replaceWith statemenet
Relnote: NavigationDrawer has been renamed to ModalNavigationDrawer
Change-Id: I1807d3c889c63efa7a569416daaed58d94a3b17a
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalNavigationDrawerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalNavigationDrawerScreenshotTest.kt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
Description
Thank you for submitting a 3PCD Breakage Report! To help reproduce the breakage on our end, please provide us with the necessary test login credentials or a test 1P site (or a “sandbox demo” environment such as glitch.com or JS Fiddle or Project IDX ).
Any sensitive details (such as test login credentials) can be shared using the “Restrict this comment/attachment” feature. Look for the eye+lock icon below the comment box.
If the above are not possible, please provide a single screen recording that shows all of the following steps: