IssueTracker

I have the following code:

if (!active || points == null || points.length == 0 || z == null) {
  return;
}

After generating an apk and decoding the containing classes.dex I can see that the new code is skipping the first null check (points == null) and immediately gets the array length. That of course results in a runtime NullPointer Exception (this is how I was made aware of it).

Using com.android.tools.build:gradle:8.6.1 shows that the check is still present in the resulting final dex, however using com.android.tools.build:gradle:8.7.0 does not. I also tested com.android.tools.build:gradle:8.9.0-rc02 and the issue is still present.

Gradle wrapper for tests: https://services.gradle.org/distributions/gradle-8.11.1-bin.zip

gradle.properties contains this setting (unsure if important)

android.enableR8.fullMode=false

Here the correct dex (up to 8.6.1):

.method public final s(Ld6/n;)V
    .registers 39

    .line 1
    move-object/from16 v0, p0

    .line 2
    .line 3
    move-object/from16 v1, p1

    .line 4
    .line 5
    iget-boolean v2, v0, Ld6/m;->q:Z   --> variable 'active'


    .line 6
    .line 7
    if-eqz v2, :cond_1e0

    .line 8
    .line 9
    iget-object v2, v0, Ld6/m;->p:[Ld6/n;  --> variable 'points'

    .line 10
    .line 11
    if-eqz v2, :cond_1e0  --> variable 'points' null check is here

    .line 12
    .line 13
    array-length v3, v2

    .line 14
    if-eqz v3, :cond_1e0

Here the INCORRECT dex (8.7.0 and greater):

.method public final s(Lc6/n;)V
    .registers 40

    .line 1
    move-object/from16 v0, p0

    .line 2
    .line 3
    move-object/from16 v1, p1

    .line 4
    .line 5
    iget-boolean v2, v0, Lc6/m;->q:Z   --> variable 'active'

    .line 6
    .line 7
    if-eqz v2, :cond_1cb

    .line 8
    .line 9
    iget-object v2, v0, Lc6/m;->p:[Lc6/n;  --> variable 'points'

--> missing check if points is NULL

    .line 10
    .line 11
    array-length v3, v2   --> getting .length!

    .line 12
    if-eqz v3, :cond_1cb