Fix __validate step passing for missing direct intra-package deps [400952169]

Fixed

Task

Status Update

No update yet.

Description

wn...@google.com

created issue #1

Mar 5, 2025 03:22PM

Context from: http://b/397396295#comment25

I can confirm $ autoninja -C out/cronet-x64 base:sys_utils_java__validate does succeed. My understanding is it shouldn't, because //base:sys_utils_java is missing a direct dep on //base:log_java.

Wow, thanks for finding this. I dug into this and found that we were passing -verbose:class to jdeps which excludes dependencies within the same package by default. We needed the extra flag -filter:none to get intra-package dependencies to show up in the dep graph as understood by check_for_missing_direct_deps.py. Once that parameter is passed, then the step fails with:

============================== Dependency Checks Failed ==============================
Target: //base:sys_utils_java
Direct classpath is incomplete. To fix, add deps on:
 * //base:base_switches_java
     ** org.chromium.base.BaseSwitches (needed by org.chromium.base.SysUtils)
 * One of //base:command_line_java, //base:command_line_jni_java
     ** org.chromium.base.CommandLine (needed by org.chromium.base.SysUtils)
 * //base:log_java
     ** org.chromium.base.Log (needed by org.chromium.base.SysUtils)

Hint: Run the following command to add the missing deps:
    build/gn_editor add --quiet --file base/BUILD.gn --target //base:sys_utils_java --deps //base:base_switches_java //base:command_line_java //base:log_java

I think previously when jdeps was added and -verbose:class was used we assumed each package would be entirely within a single target, and this assumption was wrong.

This should be fixed.

Comments

ap...@google.com <ap...@google.com> #2Mar 5, 2025 09:51PM

We’ve shared this with our product and engineering team and will continue to provide updates as more information becomes available.

ed...@google.com <ed...@google.com> #3Mar 6, 2025 10:33AM

Thank you, Google! Check out my other issues as well! :P

ag...@google.com <ag...@google.com> #4Mar 6, 2025 03:01PM

Hey guys,

for some reason you've changed the status of this

https://issuetracker.google.com/issues/210474563

issue to "Duplicate". But that issue is unrelated to this thread's issue 😅

wn...@google.com <wn...@google.com> #5Mar 6, 2025 06:02PM

- Build Number: google/sargo/sargo:12/S2B1.211112.006/7934767:user/release-keys
(Note: It is the build when sending this report. For exact build reference, please see the attached bugreport.)

I'm also facing same issue

Debugging information
Google Play services
com.google.android.gms
Version 214516044 (21.45.16 (190400-414021728))
System App (Updated)

Android System WebView
com.google.android.webview
Version 466410433 (96.0.4664.104)
System App (Updated)

Network operator: airtel
SIM operator: airtel

Filed by Android Beta Feedback. Version (Updated): 2.22-betterbug.external_20211027_RC01
To learn more about our feedback process, please visit

https://developer.android.com/preview/feedback#feedback-app.

dx...@google.com <dx...@google.com> #6Mar 6, 2025 07:06PM

Dear Google,

You marked

https://issuetracker.google.com/issues/210462358 as a duplicate of my issue.

But it's not! Please change the status of

issue 210462358

back again.

ap...@google.com <ap...@google.com> #7Mar 6, 2025 07:13PM

- Build Number: google/coral/coral:12/S2B1.211112.006/7934767:user/release-keys
(Note: It is the build when sending this report. For exact build reference, please see the attached bugreport.)

I also experience similar ones.Pixel 4xl

Debugging information
Google Play-szolgáltatások
com.google.android.gms
Version 214815044 (21.48.15 (190400-414534850))
System App (Updated)

Android System WebView
com.google.android.webview
Version 466410433 (96.0.4664.104)
System App (Updated)

Network operator: Telekom HU
SIM operator: Telekom HU

Filed by Android Beta Feedback. Version (Updated): 2.22-betterbug.external_20211027_RC01
To learn more about our feedback process, please visit

https://developer.android.com/preview/feedback#feedback-app.

ap...@google.com <ap...@google.com> #8Mar 6, 2025 10:12PM

- Build Number: google/sunfish/sunfish:12/S2B1.211112.006/7934767:user/release-keys
(Note: It is the build when sending this report. For exact build reference, please see the attached bugreport.)

Whe i switched landscape screen mood to potarit sreen mood the landscape screen was show in potarit sreen

Debugging information
Google Play services
com.google.android.gms
Version 214813044 (21.48.13 (190400-413462841))
System App (Updated)

Android System WebView
com.google.android.webview
Version 466410433 (96.0.4664.104)
System App (Updated)

Network operator: Jio 4G
SIM operator: Jio 4G

Filed by Android Beta Feedback. Version (Updated): 2.22-betterbug.external_20211027_RC01
To learn more about our feedback process, please visit

https://developer.android.com/preview/feedback#feedback-app.

ap...@google.com <ap...@google.com> #9Mar 10, 2025 04:05PM

Marked as fixed.

- Build Number: google/redfin/redfin:12/S2B1.211112.006/7934767:user/release-keys
(Note: It is the build when sending this report. For exact build reference, please see the attached bugreport.)

The clock on the lock screen is overlaping the ubber right digital clock!!

Debugging information
Google Play services
com.google.android.gms
Version 214815044 (21.48.15 (190400-414534850))
System App (Updated)

Android System WebView
com.google.android.webview
Version 469207034 (97.0.4692.70)
System App (Updated)

Network operator: Telekom.de
SIM operator: Telekom.de

Filed by Android Beta Feedback. Version (Updated): 2.23-betterbug.external_20211208a_RC01
To learn more about our feedback process, please visit

https://developer.android.com/preview/feedback#feedback-app.

IssueTracker

This issue is a part of the Chromium tracker.