BackgroundTaskSchedulerJobService calling N API before API check [40125814]

Fixed

Bug

Status Update

No update yet.

Description

wn...@chromium.org

created issue #1

Apr 8, 2020 08:36PM

[56 processes, 383/710 @ 4.5/s : 85.649s ] ACTION //components/background_task_scheduler/internal:internal_java__lint(//build/toolchain/android:android_clang_arm)

../SRC_ROOT1/components/background_task_scheduler/internal/android/java/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerJobService.java:71 Call requires API level 24 (current min is 22): `android.app.job.JobInfo#getMinPeriodMillis`: NewApi [warning]
if (intervalTimeMs < JobInfo.getMinPeriodMillis()) {
~~~~~~~~~~~~~~~~~~
../SRC_ROOT1/components/background_task_scheduler/internal/android/java/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerJobService.java:72 Call requires API level 24 (current min is 22): `android.app.job.JobInfo#getMinPeriodMillis`: NewApi [warning]
intervalTimeMs = JobInfo.getMinPeriodMillis();
~~~~~~~~~~~~~~~~~~

Lint found 2 new issues.
- For full explanation, please refer to out/Debug/obj/components/background_task_scheduler/internal/internal_java__lint/result.xml
- For more information about lint and how to fix lint issues, please refer to

https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md

I found this during lint update

https://crbug.com/chromium/1069186

Comments

wn...@chromium.org <wn...@chromium.org> #2Apr 8, 2020 08:41PM

Hi Google, this is very important for a company that makes product like we do

http://carbyne911.com/

We deliver a life saving platform for 911 centers around the world, making it easier to emergency services for all kinds to get faster to citizens, including indoor and outdoor location and we're relaying in some case on the admin area to help us direct the forces

Please consider adding it to Singapore and other missing countries

ny...@chromium.org <ny...@chromium.org> #3Apr 14, 2020 05:49PM

Thanks for your suggestion!
We have passed the suggestion on to the product team for further consideration.
Please star to add your vote and receive further updates, and feel free to add any comments to discuss your use case.

*********************************************************
For developers viewing this issue: please click the 'star' icon to be
notified of future changes, and to let us know how many of you are
interested in seeing it resolved.
*********************************************************

wn...@chromium.org <wn...@chromium.org> #4Jun 15, 2020 05:43PM

Accepted by wn...@chromium.org.

I've transitioned from this team. Thanks!

wn...@chromium.org <wn...@chromium.org> #5Jun 15, 2020 05:43PM

[Empty comment from Monorail migration]

[Monorail components: UI>Browser>Downloads]

bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #6Jun 17, 2020 05:29AM

Marked as fixed.

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/4fea6b927b88423c642ebd726c9f1add24f8843f

commit 4fea6b927b88423c642ebd726c9f1add24f8843f
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jun 17 05:25:27 2020

Android: Update cmdline-tools to 2.0

Since cmdline-tools is now 2.0, it can be updated with DEPS changes
according to the bot output:

https://luci-scheduler.appspot.com/jobs/chromium/android-sdk-packager

Fix NewApi issue in BackgroundTaskSchedulerJobService that was blocking
this roll.

Ignore two new lint errors: Instantiatable and MissingClass. Both of
these checks require passing the transitive classpath, which we do not
currently pass. Although we can consider turning these on, they do not
seem to provide much value since if classes were missing then our
compiles would already have failed (not to mention we have our bytecode
checks). Thus ignore these two checks in favour of not slowing down
lint any further.

Bug: 1093896, 1069201
Change-Id: I14b59b18bb14de346a5cde5609caaad6c28826cd
Fixed: 1093896, 1069201
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/2246187
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779189}

[modify]

https://crrev.com/4fea6b927b88423c642ebd726c9f1add24f8843f/DEPS
[modify]

https://crrev.com/4fea6b927b88423c642ebd726c9f1add24f8843f/build/android/gyp/merge_manifest.py
[modify]

https://crrev.com/4fea6b927b88423c642ebd726c9f1add24f8843f/build/android/lint/suppressions.xml
[modify]

https://crrev.com/4fea6b927b88423c642ebd726c9f1add24f8843f/components/background_task_scheduler/internal/android/java/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerJobService.java

na...@chromium.org <na...@chromium.org> #7Jun 17, 2020 06:11AM

Thanks for fixing this, Peter!

wn...@chromium.org <wn...@chromium.org> #8Jun 17, 2020 02:16PM

No problem! Glad it wasn't a real bug, just lint wasn't able to figure out our code.

is...@google.com <is...@google.com> #9Jun 17, 2020 02:16PM

This issue was migrated from

crbug.com/chromium/1069201?no_tracker_redirect=1

[Monorail components added to Component Tags custom field.]

IssueTracker

This issue is a part of the Chromium tracker.