Fixed
Status Update
No update yet.
Comments
wn...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1
commit 9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Oct 19 19:09:23 2020
Android: Remove 15 lint suppressions
- CustomViewStyleable
- DefaultLocale
- DrawAllocation
- EllipsizeMaxLines
- ExportedContentProvider
- ExportedService
- HandlerLeak
- IconColors
- IconLauncherFormat
- IconLauncherShape
- Instantiatable
- InconsistentLayout
- InflateParams (Permanently skipped)
- InlinedApi (Permanently skipped)
- JobSchedulerService
Bug: 1116130,1081240
Fixed: 1081240
Change-Id: I37dfb048198cbbed198408f74ecce1d0876d6dfc
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2429808
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818559}
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/android_webview/expectations/system_webview_bundle.AndroidManifest.expected
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/android_webview/expectations/trichrome_webview_bundle.AndroidManifest.expected
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/android_webview/nonembedded/java/AndroidManifest.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/build/android/BUILD.gn
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/build/android/gyp/lint.py
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/build/android/java/test/LintTest.java
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/expectations/lint-suppressions.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/expectations/monochrome_public_bundle.AndroidManifest.expected
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/expectations/trichrome_chrome_bundle.AndroidManifest.expected
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceMediator.java
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/java/AndroidManifest.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/java/res/layout-sw600dp/location_bar.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/browser/privacy/java/res/layout/secure_dns_provider_spinner_item.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/components/browser_ui/settings/android/java/res/layout/preference_spinner_single_line_item.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/components/browser_ui/widget/android/java/res/values/attrs.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/BoundedLinearLayout.java
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/components/payments/content/android/java/res/layout/payment_request_header.xml
commit 9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Oct 19 19:09:23 2020
Android: Remove 15 lint suppressions
- CustomViewStyleable
- DefaultLocale
- DrawAllocation
- EllipsizeMaxLines
- ExportedContentProvider
- ExportedService
- HandlerLeak
- IconColors
- IconLauncherFormat
- IconLauncherShape
- Instantiatable
- InconsistentLayout
- InflateParams (Permanently skipped)
- InlinedApi (Permanently skipped)
- JobSchedulerService
Bug: 1116130,1081240
Fixed: 1081240
Change-Id: I37dfb048198cbbed198408f74ecce1d0876d6dfc
Reviewed-on:
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818559}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
Description
cale is a common source of bugs: Use `String.format(Locale, ...)` instead: DefaultLocale [warning]
: String.format("Cannot handle action for item in the menu with id %d", itemId);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is found after fixing lint (CL in progress), so you won't be able to repro until my CL lands, but my CL cannot land without suppressing it. So I will link to this bug in suppressions.xml.