Fixed
Status Update
No update yet.
Comments
wn...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/f38090f17f379dfc848137118f4aebb298421d7c
commit f38090f17f379dfc848137118f4aebb298421d7c
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Jun 11 19:01:44 2020
Android: Add cmdline-tools to android-sdk-packager
Similar tohttps://crrev.com/c/1803895 , now that cmdline-tools is no
longer in canary channel, we can add it to the rest of the sdk packages.
Updated instructions for updating and adding new packages.
Fix android-sdk-packager build since it was broken by android releasing
bugs starting early May.
Bug: 1093896
Change-Id: I800b285a4e03193f4b9c3c67a44f55eb4b77fd6d
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2241994
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777426}
[modify]https://crrev.com/f38090f17f379dfc848137118f4aebb298421d7c/infra/config/generated/cr-buildbucket.cfg
[modify]https://crrev.com/f38090f17f379dfc848137118f4aebb298421d7c/infra/config/subprojects/chromium/master-only/ci.star
[modify]https://crrev.com/f38090f17f379dfc848137118f4aebb298421d7c/third_party/android_sdk/README.chromium
commit f38090f17f379dfc848137118f4aebb298421d7c
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Jun 11 19:01:44 2020
Android: Add cmdline-tools to android-sdk-packager
Similar to
longer in canary channel, we can add it to the rest of the sdk packages.
Updated instructions for updating and adding new packages.
Fix android-sdk-packager build since it was broken by android releasing
bugs starting early May.
Bug: 1093896
Change-Id: I800b285a4e03193f4b9c3c67a44f55eb4b77fd6d
Reviewed-on:
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777426}
[modify]
[modify]
[modify]
wn...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/4fea6b927b88423c642ebd726c9f1add24f8843f
commit 4fea6b927b88423c642ebd726c9f1add24f8843f
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jun 17 05:25:27 2020
Android: Update cmdline-tools to 2.0
Since cmdline-tools is now 2.0, it can be updated with DEPS changes
according to the bot output:
https://luci-scheduler.appspot.com/jobs/chromium/android-sdk-packager
Fix NewApi issue in BackgroundTaskSchedulerJobService that was blocking
this roll.
Ignore two new lint errors: Instantiatable and MissingClass. Both of
these checks require passing the transitive classpath, which we do not
currently pass. Although we can consider turning these on, they do not
seem to provide much value since if classes were missing then our
compiles would already have failed (not to mention we have our bytecode
checks). Thus ignore these two checks in favour of not slowing down
lint any further.
Bug: 1093896, 1069201
Change-Id: I14b59b18bb14de346a5cde5609caaad6c28826cd
Fixed: 1093896, 1069201
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2246187
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779189}
[modify]https://crrev.com/4fea6b927b88423c642ebd726c9f1add24f8843f/DEPS
[modify]https://crrev.com/4fea6b927b88423c642ebd726c9f1add24f8843f/build/android/gyp/merge_manifest.py
[modify]https://crrev.com/4fea6b927b88423c642ebd726c9f1add24f8843f/build/android/lint/suppressions.xml
[modify]https://crrev.com/4fea6b927b88423c642ebd726c9f1add24f8843f/components/background_task_scheduler/internal/android/java/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskSchedulerJobService.java
commit 4fea6b927b88423c642ebd726c9f1add24f8843f
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jun 17 05:25:27 2020
Android: Update cmdline-tools to 2.0
Since cmdline-tools is now 2.0, it can be updated with DEPS changes
according to the bot output:
Fix NewApi issue in BackgroundTaskSchedulerJobService that was blocking
this roll.
Ignore two new lint errors: Instantiatable and MissingClass. Both of
these checks require passing the transitive classpath, which we do not
currently pass. Although we can consider turning these on, they do not
seem to provide much value since if classes were missing then our
compiles would already have failed (not to mention we have our bytecode
checks). Thus ignore these two checks in favour of not slowing down
lint any further.
Bug: 1093896, 1069201
Change-Id: I14b59b18bb14de346a5cde5609caaad6c28826cd
Fixed: 1093896, 1069201
Reviewed-on:
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779189}
[modify]
[modify]
[modify]
[modify]
wn...@chromium.org
[Empty comment from Monorail migration]
Description