Fixed
Status Update
No update yet.
Comments
bu...@chops-service-accounts.iam.gserviceaccount.com
I guess hidden should just be defined. Meaning, right now, hidden should just defined as "whether this fragment was hidden as part of a transaction". Hidden is not equivalent with visibility. I think that's where the confusion comes from.
bu...@chops-service-accounts.iam.gserviceaccount.com
We have passed this to the development team and will update this issue with more information as it becomes available.
bu...@chops-service-accounts.iam.gserviceaccount.com
Yeah, I'm seeing this issue as well, currently this is the workaround that I've come up with:
// This method is called when hide()/show() methods are called on the transaction. Unfortunately Android doesn't
// propagate it to the child fragments (even though their visibility is affected by the parent visibility), so we
// do it manually.
override fun onHiddenChanged(hidden: Boolean) {
super.onHiddenChanged(hidden)
childFragmentManager.fragments.forEach { it.onHiddenChanged(hidden) }
}
// This method is called when hide()/show() methods are called on the transaction. Unfortunately Android doesn't
// propagate it to the child fragments (even though their visibility is affected by the parent visibility), so we
// do it manually.
override fun onHiddenChanged(hidden: Boolean) {
super.onHiddenChanged(hidden)
childFragmentManager.fragments.forEach { it.onHiddenChanged(hidden) }
}
wn...@chromium.org
@4 That actually won't technically fix as isHidden() will technically mismatch with the state passed into the child fragment. Each child fragment legitimately needs to have their state set to hidden.
bu...@chops-service-accounts.iam.gserviceaccount.com
Yeah, I realized that as I kept working further on it. Nevermind that solution, it doesn't work.
bu...@chops-service-accounts.iam.gserviceaccount.com
@6 I don't know what the ramifications are, but when you iterate, you can save the "currentState" and then hide them all via a transaction. When restoring to visible, restore to the original state.
bu...@chops-service-accounts.iam.gserviceaccount.com
Project: platform/frameworks/support
Branch: androidx-main
commit 02290cddca3d5e4dc94e2c5f77a6728ad970b204
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Oct 07 13:11:45 2021
Dispatch onHiddenChanged to child fragments
When a parent fragment is hidden all of its children will automatically
be hidden, but we never call onHiddenChanged on any of the children.
We should dispatch onHiddenChanged down parent's entire hierarchy and
ensure that `isHidden()` also considers the parent's state.
RelNote: "Parent fragments will now dispatch `onHiddenChanged()` down
their entire hierarchy before launching their own call back."
Test: added test
Bug: 77504618
Change-Id: Iedc201ab435cb963e81bc02d203d4d37ff827e01
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
https://android-review.googlesource.com/1850016
Branch: androidx-main
commit 02290cddca3d5e4dc94e2c5f77a6728ad970b204
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Oct 07 13:11:45 2021
Dispatch onHiddenChanged to child fragments
When a parent fragment is hidden all of its children will automatically
be hidden, but we never call onHiddenChanged on any of the children.
We should dispatch onHiddenChanged down parent's entire hierarchy and
ensure that `isHidden()` also considers the parent's state.
RelNote: "Parent fragments will now dispatch `onHiddenChanged()` down
their entire hierarchy before launching their own call back."
Test: added test
Bug: 77504618
Change-Id: Iedc201ab435cb963e81bc02d203d4d37ff827e01
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
bu...@chops-service-accounts.iam.gserviceaccount.com
This has been fixed internally and will be available in the Fragment 1.4.0-beta01 release.
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/be53a1593c068076ebccf50c63fac70878d43447
commit be53a1593c068076ebccf50c63fac70878d43447
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Aug 31 18:43:12 2020
Android: Remove unused suppressions and fix some
Remove test-specific suppressions. If and when we enable lint on test
targets again, blanket testonly suppressions should be added to lint.py
instead.
Fix some WrongConstant issues. These are useful to understand and make
sure we are passing the right @IntDef and @StringDef variables to
android APIs.
Bug: 1116130
Change-Id: I43bea517bca2436f2063829fe74d280b5df6bca5
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2375700
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803198}
[modify]https://crrev.com/be53a1593c068076ebccf50c63fac70878d43447/chrome/android/expectations/lint-suppressions.xml
[modify]https://crrev.com/be53a1593c068076ebccf50c63fac70878d43447/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
[modify]https://crrev.com/be53a1593c068076ebccf50c63fac70878d43447/components/browser_ui/client_certificate/android/java/src/org/chromium/components/browser_ui/client_certificate/SSLClientCertificateRequest.java
[modify]https://crrev.com/be53a1593c068076ebccf50c63fac70878d43447/media/base/android/java/src/org/chromium/media/MediaCodecEncoder.java
commit be53a1593c068076ebccf50c63fac70878d43447
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Aug 31 18:43:12 2020
Android: Remove unused suppressions and fix some
Remove test-specific suppressions. If and when we enable lint on test
targets again, blanket testonly suppressions should be added to lint.py
instead.
Fix some WrongConstant issues. These are useful to understand and make
sure we are passing the right @IntDef and @StringDef variables to
android APIs.
Bug: 1116130
Change-Id: I43bea517bca2436f2063829fe74d280b5df6bca5
Reviewed-on:
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803198}
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/4f91a35325e50a0f2f4a26966fbed3460484d0a8
commit 4f91a35325e50a0f2f4a26966fbed3460484d0a8
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Sep 14 18:48:29 2020
Android: Fix many WrongConstant errors
Add WebviewErrorCode @IntDef.
Bug: 1116130
Change-Id: I740ad5b03eb2c03effd16413b57640d872b00a0a
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2401813
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806706}
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/BUILD.gn
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/java/src/org/chromium/android_webview/ErrorCodeConversionHelper.java
[add]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/java/src/org/chromium/android_webview/WebviewErrorCode.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsStaticsTest.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedError2Test.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnReceivedErrorTest.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/build/android/gyp/lint.py
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/expectations/lint-baseline.xml
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabManagementDelegate.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/library/api/internal/modelprovider/ModelError.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUmaRecorder.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/java/src/org/chromium/chrome/browser/tab/TabThemeColorHelper.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/java/src/org/chromium/chrome/browser/tab/TabUma.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/dialogs/DownloadLaterDialogChoice.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/dialogs/DownloadLaterDialogHelper.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/browser/safety_check/android/java/src/org/chromium/chrome/browser/safety_check/SafetyCheckProperties.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/state/CriticalPersistedTabData.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/chrome/browser/test_dummy/internal/android/java/src/org/chromium/chrome/browser/test_dummy/TestDummyImpl.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/components/background_task_scheduler/internal/android/java/src/org/chromium/components/background_task_scheduler/internal/BackgroundTaskBroadcastReceiver.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/components/browser_ui/media/android/java/src/org/chromium/components/browser_ui/media/MediaSessionHelper.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/components/browser_ui/media/android/java/src/org/chromium/components/browser_ui/media/MediaSessionUma.java
[modify]https://crrev.com/4f91a35325e50a0f2f4a26966fbed3460484d0a8/weblayer/browser/java/org/chromium/weblayer_private/ContentViewRenderView.java
commit 4f91a35325e50a0f2f4a26966fbed3460484d0a8
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Sep 14 18:48:29 2020
Android: Fix many WrongConstant errors
Add WebviewErrorCode @IntDef.
Bug: 1116130
Change-Id: I740ad5b03eb2c03effd16413b57640d872b00a0a
Reviewed-on:
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806706}
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
wn...@chromium.org
[Empty comment from Monorail migration]
wn...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/ffc8e33216fe9c526d47de57045852eaaef82be4
commit ffc8e33216fe9c526d47de57045852eaaef82be4
Author: Peter Wen <wnwen@chromium.org>
Date: Tue Sep 22 16:33:52 2020
Android: Remove some lint suppressions
Add ignores for EditText elements that do not need autofillHints.
Remove ButtonOrder suppression as it's no longer needed.
Bug: 1073966,1116130
Fixed: 1073966
Change-Id: I80c97528c3558379d43677b78bbbc2f290d5105e
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2419593
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809369}
[modify]https://crrev.com/ffc8e33216fe9c526d47de57045852eaaef82be4/chrome/android/expectations/lint-suppressions.xml
[modify]https://crrev.com/ffc8e33216fe9c526d47de57045852eaaef82be4/chrome/android/features/tab_ui/java/res/layout/bottom_tab_grid_toolbar.xml
[modify]https://crrev.com/ffc8e33216fe9c526d47de57045852eaaef82be4/chrome/android/java/res/layout/password_entry_editor.xml
[modify]https://crrev.com/ffc8e33216fe9c526d47de57045852eaaef82be4/components/browser_ui/widget/android/java/res/layout/radio_button_with_edit_text.xml
commit ffc8e33216fe9c526d47de57045852eaaef82be4
Author: Peter Wen <wnwen@chromium.org>
Date: Tue Sep 22 16:33:52 2020
Android: Remove some lint suppressions
Add ignores for EditText elements that do not need autofillHints.
Remove ButtonOrder suppression as it's no longer needed.
Bug: 1073966,1116130
Fixed: 1073966
Change-Id: I80c97528c3558379d43677b78bbbc2f290d5105e
Reviewed-on:
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809369}
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3
commit 9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Sep 23 18:06:51 2020
Android: Remove blanket suppressions
Previously, blanket suppressions were added due to lint not working. Now
that android lint is working well again, we no longer need these blanket
suppressions. They have been removed/fixed/or moved to the specific
files that require them.
Bug: 1044658,1116130
Change-Id: I249afb500c49c13f35880311d04c51391ed8cbfa
Fixed: 1044658
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2424543
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809858}
[modify]https://crrev.com/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3/chrome/android/expectations/lint-suppressions.xml
[modify]https://crrev.com/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3/chrome/android/java/res/layout/sheet_tab_toolbar.xml
[modify]https://crrev.com/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3/chrome/android/java/res/menu/main_menu.xml
[modify]https://crrev.com/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3/chrome/android/java/res/menu/main_menu_regroup.xml
[modify]https://crrev.com/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3/chrome/android/java/res/values/dimens.xml
[modify]https://crrev.com/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3/chrome/android/java/res/values/styles.xml
[modify]https://crrev.com/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3/components/browser_ui/contacts_picker/android/java/res/layout/contacts_list_item_view.xml
[modify]https://crrev.com/9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3/components/browser_ui/photo_picker/android/java/res/layout/photo_picker_dialog.xml
commit 9f91a88a72e2eec6bc53b8bc8220f9ee43741dc3
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Sep 23 18:06:51 2020
Android: Remove blanket suppressions
Previously, blanket suppressions were added due to lint not working. Now
that android lint is working well again, we no longer need these blanket
suppressions. They have been removed/fixed/or moved to the specific
files that require them.
Bug: 1044658,1116130
Change-Id: I249afb500c49c13f35880311d04c51391ed8cbfa
Fixed: 1044658
Reviewed-on:
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809858}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/172503b944b51d05562436bdc465a7845ed4b61e
commit 172503b944b51d05562436bdc465a7845ed4b61e
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Sep 23 20:58:37 2020
Android: Remove seven lint suppressions
Removing lint suppressions allows our new code to benefit from these
lint checks.
Regenerate lint-baseline.xml to account for UseCompoundDrawables moving
from lint-suppressions.xml to lint-baseline.xml.
Removed from lint-suppressions.xml:
- UseCompoundDrawables
- UselessParent
- UseMinSdkAttributes
- ValidFragment
- VisibleForTests
- WebViewApiAvailability
- WrongCall
Bug: 1116130
Change-Id: I89623b3f2c448b2332c39147892dff9d0d2b6001
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2422466
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809950}
[modify]https://crrev.com/172503b944b51d05562436bdc465a7845ed4b61e/android_webview/nonembedded/java/src/org/chromium/android_webview/devui/util/WebViewPackageHelper.java
[modify]https://crrev.com/172503b944b51d05562436bdc465a7845ed4b61e/chrome/android/expectations/lint-baseline.xml
[modify]https://crrev.com/172503b944b51d05562436bdc465a7845ed4b61e/chrome/android/expectations/lint-suppressions.xml
[modify]https://crrev.com/172503b944b51d05562436bdc465a7845ed4b61e/chrome/android/java/res/layout/data_usage_breakdown.xml
[modify]https://crrev.com/172503b944b51d05562436bdc465a7845ed4b61e/chrome/android/java/src/org/chromium/chrome/browser/infobar/TextViewEllipsizerSafe.java
[modify]https://crrev.com/172503b944b51d05562436bdc465a7845ed4b61e/media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java
commit 172503b944b51d05562436bdc465a7845ed4b61e
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Sep 23 20:58:37 2020
Android: Remove seven lint suppressions
Removing lint suppressions allows our new code to benefit from these
lint checks.
Regenerate lint-baseline.xml to account for UseCompoundDrawables moving
from lint-suppressions.xml to lint-baseline.xml.
Removed from lint-suppressions.xml:
- UseCompoundDrawables
- UselessParent
- UseMinSdkAttributes
- ValidFragment
- VisibleForTests
- WebViewApiAvailability
- WrongCall
Bug: 1116130
Change-Id: I89623b3f2c448b2332c39147892dff9d0d2b6001
Reviewed-on:
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809950}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chrome-internal.googlesource.com/chrome/src-internal.git/+/7bb039318b3e3f7c18489696d17561d15cf7ca75
commit 7bb039318b3e3f7c18489696d17561d15cf7ca75
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Thu Sep 24 18:34:47 2020
commit 7bb039318b3e3f7c18489696d17561d15cf7ca75
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Thu Sep 24 18:34:47 2020
wn...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/0392956126f72a8ea5a4ca01ef54b1de1e6f96ad
commit 0392956126f72a8ea5a4ca01ef54b1de1e6f96ad
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Sat Sep 26 00:02:42 2020
Roll src-internal from faa49d773432 to 76b5fbb58db7 (58 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/faa49d773432..76b5fbb58db7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jam@google.com,fdoray@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1084659,chromium:1093383,chromium:1099917,chromium:1099982,chromium:1105096,chromium:1116130,chromium:1128599,chromium:1128653,chromium:1128747,chromium:1130677,chromium:1130962,chromium:1131230,chromium:912681
Tbr: jam@google.com,fdoray@google.com
Change-Id: I4fe3ba9beff57593fa125e390802a546b97e8819
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2432786
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810848}
[modify]https://crrev.com/0392956126f72a8ea5a4ca01ef54b1de1e6f96ad/DEPS
commit 0392956126f72a8ea5a4ca01ef54b1de1e6f96ad
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Sat Sep 26 00:02:42 2020
Roll src-internal from faa49d773432 to 76b5fbb58db7 (58 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
Please CC jam@google.com,fdoray@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
Documentation for the AutoRoller is here:
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1084659,chromium:1093383,chromium:1099917,chromium:1099982,chromium:1105096,chromium:1116130,chromium:1128599,chromium:1128653,chromium:1128747,chromium:1130677,chromium:1130962,chromium:1131230,chromium:912681
Tbr: jam@google.com,fdoray@google.com
Change-Id: I4fe3ba9beff57593fa125e390802a546b97e8819
Reviewed-on:
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810848}
[modify]
wn...@chromium.org
[Empty comment from Monorail migration]
bu...@chops-service-accounts.iam.gserviceaccount.com
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chrome-internal.googlesource.com/chrome/src-internal.git/+/8c475b5754feb329aa9ad9c260979f9bb6fa91e0
commit 8c475b5754feb329aa9ad9c260979f9bb6fa91e0
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Mon Sep 28 17:36:45 2020
commit 8c475b5754feb329aa9ad9c260979f9bb6fa91e0
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Mon Sep 28 17:36:45 2020
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/11e880d97645aa8de6dacd4bc433fcc0b23c95cb
commit 11e880d97645aa8de6dacd4bc433fcc0b23c95cb
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Wed Sep 30 14:34:56 2020
Roll src-internal from 8b16441c661b to 2494f4964a64 (44 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b16441c661b..2494f4964a64
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sinhak@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1073476,chromium:1080853,chromium:1080854,chromium:1099917,chromium:1105693,chromium:1109276,chromium:1116130,chromium:1126509,chromium:1127088,chromium:1128767,chromium:1130343,chromium:1131852,chromium:1132482,chromium:1132930,chromium:1132961,chromium:1132967,chromium:3289230,chromium:912681,chromium:989569
Tbr: sinhak@google.com
Change-Id: I58082fb0271747c474ee800a383ce922a38f2fb4
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2439105
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812017}
[modify]https://crrev.com/11e880d97645aa8de6dacd4bc433fcc0b23c95cb/DEPS
commit 11e880d97645aa8de6dacd4bc433fcc0b23c95cb
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Wed Sep 30 14:34:56 2020
Roll src-internal from 8b16441c661b to 2494f4964a64 (44 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
Please CC sinhak@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
Documentation for the AutoRoller is here:
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1073476,chromium:1080853,chromium:1080854,chromium:1099917,chromium:1105693,chromium:1109276,chromium:1116130,chromium:1126509,chromium:1127088,chromium:1128767,chromium:1130343,chromium:1131852,chromium:1132482,chromium:1132930,chromium:1132961,chromium:1132967,chromium:3289230,chromium:912681,chromium:989569
Tbr: sinhak@google.com
Change-Id: I58082fb0271747c474ee800a383ce922a38f2fb4
Reviewed-on:
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812017}
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1
commit 9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Oct 19 19:09:23 2020
Android: Remove 15 lint suppressions
- CustomViewStyleable
- DefaultLocale
- DrawAllocation
- EllipsizeMaxLines
- ExportedContentProvider
- ExportedService
- HandlerLeak
- IconColors
- IconLauncherFormat
- IconLauncherShape
- Instantiatable
- InconsistentLayout
- InflateParams (Permanently skipped)
- InlinedApi (Permanently skipped)
- JobSchedulerService
Bug: 1116130,1081240
Fixed: 1081240
Change-Id: I37dfb048198cbbed198408f74ecce1d0876d6dfc
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2429808
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818559}
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/android_webview/expectations/system_webview_bundle.AndroidManifest.expected
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/android_webview/expectations/trichrome_webview_bundle.AndroidManifest.expected
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/android_webview/nonembedded/java/AndroidManifest.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/build/android/BUILD.gn
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/build/android/gyp/lint.py
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/build/android/java/test/LintTest.java
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/expectations/lint-suppressions.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/expectations/monochrome_public_bundle.AndroidManifest.expected
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/expectations/trichrome_chrome_bundle.AndroidManifest.expected
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSurfaceMediator.java
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/java/AndroidManifest.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/android/java/res/layout-sw600dp/location_bar.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/chrome/browser/privacy/java/res/layout/secure_dns_provider_spinner_item.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/components/browser_ui/settings/android/java/res/layout/preference_spinner_single_line_item.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/components/browser_ui/widget/android/java/res/values/attrs.xml
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/components/browser_ui/widget/android/java/src/org/chromium/components/browser_ui/widget/BoundedLinearLayout.java
[modify]https://crrev.com/9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1/components/payments/content/android/java/res/layout/payment_request_header.xml
commit 9bf6c5007cd0de2063d0aca7b3ea7df3a7b7bac1
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Oct 19 19:09:23 2020
Android: Remove 15 lint suppressions
- CustomViewStyleable
- DefaultLocale
- DrawAllocation
- EllipsizeMaxLines
- ExportedContentProvider
- ExportedService
- HandlerLeak
- IconColors
- IconLauncherFormat
- IconLauncherShape
- Instantiatable
- InconsistentLayout
- InflateParams (Permanently skipped)
- InlinedApi (Permanently skipped)
- JobSchedulerService
Bug: 1116130,1081240
Fixed: 1081240
Change-Id: I37dfb048198cbbed198408f74ecce1d0876d6dfc
Reviewed-on:
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818559}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/1c425dede5cf1eac9b3e617737250ad9cb4b30ee
commit 1c425dede5cf1eac9b3e617737250ad9cb4b30ee
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Nov 19 16:37:53 2020
Android: Reduce lint suppressions
Most of these suppressions no longer matter after switching to linting
monochrome bundle only.
Bug: 1116130
Change-Id: I0e675603ccb2ecdd056c6a3b8f9e995e1c0108d2
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2546994
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829251}
[modify]https://crrev.com/1c425dede5cf1eac9b3e617737250ad9cb4b30ee/chrome/android/expectations/lint-suppressions.xml
commit 1c425dede5cf1eac9b3e617737250ad9cb4b30ee
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Nov 19 16:37:53 2020
Android: Reduce lint suppressions
Most of these suppressions no longer matter after switching to linting
monochrome bundle only.
Bug: 1116130
Change-Id: I0e675603ccb2ecdd056c6a3b8f9e995e1c0108d2
Reviewed-on:
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829251}
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/397a12c28a57dc8f450d8f87a669c7afa6aeb196
commit 397a12c28a57dc8f450d8f87a669c7afa6aeb196
Author: Peter Wen <wnwen@chromium.org>
Date: Sat Nov 21 01:52:08 2020
Android: Use lint-baseline.xml for old todos
As recommended in the lint README, lint-suppressions.xml should only be
used for temporary and permanent ignores, not for old code that should
be fixed at some point:
https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md
Thus, bulk-moving ignores for old code into lint-baseline.xml.
The one exception is for UnusedResources, since having these checks in
lint-baseline.xml causes a lot of bloat in terms of lines since each
language's xml file is listed on a separate line for every resource.
Bug: 1069186, 1077861, 1116130, 1085410, 1039415
Fixed: 1069186, 1085410
Change-Id: Iac10f4dc087e12b43595aae154dc7ffb821f2325
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2552853
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829920}
[modify]https://crrev.com/397a12c28a57dc8f450d8f87a669c7afa6aeb196/build/android/docs/lint.md
[modify]https://crrev.com/397a12c28a57dc8f450d8f87a669c7afa6aeb196/chrome/android/expectations/lint-baseline.xml
[modify]https://crrev.com/397a12c28a57dc8f450d8f87a669c7afa6aeb196/chrome/android/expectations/lint-suppressions.xml
commit 397a12c28a57dc8f450d8f87a669c7afa6aeb196
Author: Peter Wen <wnwen@chromium.org>
Date: Sat Nov 21 01:52:08 2020
Android: Use lint-baseline.xml for old todos
As recommended in the lint README, lint-suppressions.xml should only be
used for temporary and permanent ignores, not for old code that should
be fixed at some point:
Thus, bulk-moving ignores for old code into lint-baseline.xml.
The one exception is for UnusedResources, since having these checks in
lint-baseline.xml causes a lot of bloat in terms of lines since each
language's xml file is listed on a separate line for every resource.
Bug: 1069186, 1077861, 1116130, 1085410, 1039415
Fixed: 1069186, 1085410
Change-Id: Iac10f4dc087e12b43595aae154dc7ffb821f2325
Reviewed-on:
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829920}
[modify]
[modify]
[modify]
wn...@chromium.org
We are not quite at document "all" suppressions, but 90% of the actionable ones have been dealt with. Many remaining suppressed ones are because Chrome has its own localization team and they should not be blocked on android lint. Good enough to call this done.
Description
Now that we use target-specific lint-suppressions.xml and lint-baseline.xml files, we can enable more of these checks and put the existing failures into the baseline.