Status Update
Comments
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #3
th...@chromium.org <th...@chromium.org> #4
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #6
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #7
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #8
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #9
ts...@chromium.org <ts...@chromium.org> #10
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #11
ts...@chromium.org <ts...@chromium.org> #12
As some help... looking at forums online made it look like it was past a Droid problem and that all Verizon CDMA phones have this issue and it may not be possible to fix it (although you're Google, I've got my confidence in you!).
With a little more research, it looks like that's not true because iPhones (possible AT&T? but don't think so) can elegantly play the ringtones however the user wishes (like the majority of posts are requesting)
On the contrary... many people said they had it playing through the headphones AND the speaker, which does not happen for me (although I've only tried on vibrate... but still it would be nice for the notification/ringtone to be played through the headset even with the phone on vibrate)
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #13
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #14
as...@chromium.org <as...@chromium.org> #15
ts...@chromium.org <ts...@chromium.org> #16
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #17
Very annoying bug indeed!!
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #18
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #19
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #20
di...@chromium.org <di...@chromium.org> #21
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #22
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #23
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #24
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #25
Maybe the headphone port is designed to work only with the stock hands-free headset that comes with the phone. A different connection could mean that regular headphones would not disable the speakers (as I think this is done by the hardware). However, surely the software could fix this too?
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #26
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #27
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #28
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #29
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #30
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #31
da...@chromium.org <da...@chromium.org> #32
da...@chromium.org <da...@chromium.org> #33
da...@chromium.org <da...@chromium.org> #34
Unfortunately, the bug is still present as of the current latest version (4.0.1).
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #35
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #36
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #37
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #38
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #39
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #40
gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #41
Minimally, this should be user configurable.
is...@google.com <is...@google.com> #42
ap...@google.com <ap...@google.com> #43
Please fix this - that is a very big bug in the android system! I don't understand what take so long - the I-Net is full of reports about this bug from android users all around the globe - not the best sign of quality, or?
ap...@google.com <ap...@google.com> #44
ap...@google.com <ap...@google.com> #45
This also happens using a stereo Bluetooth headset (LG HBS-700):
Most sounds and music come out the BT Headset. However, Phone Ringtones, Notifications and the messaging Text-to-Speech (reads Texts to you) all come out both the BT Headset and the tablet Speakers.
There should be an option to send ALL sound to a) Bluetooth/Wired Headphone (default), b) Speakers or c) Both.
ap...@google.com <ap...@google.com> #46
ap...@google.com <ap...@google.com> #47
I hope it helps some of you out a bit at least.
ap...@google.com <ap...@google.com> #48
ap...@google.com <ap...@google.com> #49
Comment 32 by steve.ro...@gmail.com, Dec 10, 2011
On my Thunderbolt I experience this with both wired and bluetooth headphones. When I use round timer on one of my exercises, the alert tones are playing LOUDLY out of the back speaker in addition to through my bluetooth headphones. This is a MUST FIX.
So I gave you a fix to the LOUDLY problem which seemed to be your biggest concern. I also said it MAY help SOMEWHAT, not that I had fixed Android's problem. I would also hope that it can be used to at least improve things for those who may not know about "Setting Profiles".
You can also use this to turn the speaker off completely and turn vibration on - one assumes that if you are wearing headphones that one will be in reasonably close proximity to the other end of the ear pieces.
Anyway, sorry for trying to help - I'll butt out in future.
ap...@google.com <ap...@google.com> #50
I suggest you direct your attention towards CyanogenMod where developers are trying to (and apparently in some cases have succeeded to) solve this issue by having an option for allowing notifications on speaker when headphones are plugged in.
The option mostly appeared to be broken on my previous phone (ZTE Blade) but I think it worked at least once. Your mileage may vary.
ap...@google.com <ap...@google.com> #51
I happily used CyanogenMod when I had a Motorola Droid, but I have an HTC Thunderbolt now which I'm much happier with (as the Droid seemed to keep getting slower and less stable over time). And I would love to run CyanogenMod on my Thunderbolt.
Unfortunately CM7 for the Thunderbolt is still experimental (apparently not even alpha). My understanding is there are still a couple of issues that haven't been resolved. I've also read that the main developer on that port has been deployed overseas so development is not proceeding forward on it.
So CyanogenMod is unfortunately not an option for me.
This is really a fundamental issue that Google should address. It isn't unique to the Thunderbolt -- I had the same problem on the Droid until Cyanogenmod fixed it.
And Djhg2 (comment 49) -- I'm not sure what you mean by "@47" but I made comment # 47 and I've just re-read it 4 times and there is nothing offensive in it.
ap...@google.com <ap...@google.com> #52
It's just that the author of #48 was obviously offended, I'd guess because it seemed like you were annoyed by his suggested workaround for not disturbing others.
I think we're more likely to find a solution if we stay calm and friendly so that we can collaborate and bring as much info as possible to the table for the developers.
My apologies if you find any of my messages offensive, I can assure you that being offensive is not my intention.
ap...@google.com <ap...@google.com> #53
ap...@google.com <ap...@google.com> #54
ap...@google.com <ap...@google.com> #55
ap...@google.com <ap...@google.com> #56
ap...@google.com <ap...@google.com> #57
ap...@google.com <ap...@google.com> #58
Steam Mobile plays notifications through the headphones just fine, whereas Handcent SMS plays them through the speaker.
(accidentally sent through friend's Google account before, wanted to attribute to the right person)
ap...@google.com <ap...@google.com> #59
I wake earlier than my wife, and I am willing to go to sleep with headphones on so the alarm won't wake her. Unfortunately, as all these posters have noted, that is not possible with my HTC 4G, and obviously on other machines.
My workarount (a.k.a kluge). My alarm app (Alarm Clock Plus) has the option of launching an app for the alarm. I set it to launch Angry Birds, which plays its theme song when it launches.
Kludgy, but it works.
(BTW, Alarm Clock Plus is awesome)
ap...@google.com <ap...@google.com> #60
ap...@google.com <ap...@google.com> #61
ap...@google.com <ap...@google.com> #62
GSM US Galaxy Nexus running stock ICS 4.0.4 (TAKJU).
ap...@google.com <ap...@google.com> #63
ap...@google.com <ap...@google.com> #64
ap...@google.com <ap...@google.com> #65
ap...@google.com <ap...@google.com> #66
Arc S
ap...@google.com <ap...@google.com> #67
ap...@google.com <ap...@google.com> #68
ap...@google.com <ap...@google.com> #69
ap...@google.com <ap...@google.com> #70
ap...@google.com <ap...@google.com> #71
ap...@google.com <ap...@google.com> #72
ap...@google.com <ap...@google.com> #73
ap...@google.com <ap...@google.com> #74
ap...@google.com <ap...@google.com> #75
ap...@google.com <ap...@google.com> #76
Unfortunately CM7 for the Thunderbolt is still alpha so I'm not currently using it.
ap...@google.com <ap...@google.com> #77
ap...@google.com <ap...@google.com> #78
I am having this problem with using Bluetooth too. I can connect to to my Bluetooth devices but the sound is still coming from the phone speakers and with Bluetooth delay is very annoying. I have tried many things to rectify this, like using a cable connection from phone into the cars Bluetooth and it still speaks from the phone as well. I have played with the volumes on the phone and that just turns everything down. I have tried muting or putting the phone on silent and it still gives sound from the phone speakers. And to make it worse I accidently minimized the app when I was in Church and it started giving me directions out loud even though the phone was on silent??
Hope you can help me with the issue by telling me how to stop it or if this is a known issue and you are working on it.
ap...@google.com <ap...@google.com> #79
ap...@google.com <ap...@google.com> #80
I, however, do not wish to purchase an app only to find out whether or not a specific script works -- if anybody is on an Evo 4G running ICS, has Tasker, and is willing to try it out, please let me know how it goes.
I agree with the OP that this is most certainly a bug, not a feature, and should be fixed. Unfortunately, with this thread being a year old and the enhancement thread being 2 years old, I don't know what to expect.
ap...@google.com <ap...@google.com> #81
I used to not like music being interrupter with notifications, but now I miss it.
ap...@google.com <ap...@google.com> #82
ap...@google.com <ap...@google.com> #83
ap...@google.com <ap...@google.com> #84
ap...@google.com <ap...@google.com> #85
It also exhibits the same bug when bluetooth headphones are connected.
Clearly NOT fixed in 4.1.1 Jellybean.
ap...@google.com <ap...@google.com> #86
ap...@google.com <ap...@google.com> #87
However, I suppose if you're that worried about it, you could put it on vibrate.
ap...@google.com <ap...@google.com> #88
plugged in, then the notifications do not play through the external
speakers. I find that odd. There should be a configurable option to control
this behavior.
ap...@google.com <ap...@google.com> #89
ap...@google.com <ap...@google.com> #90
ap...@google.com <ap...@google.com> #91
ap...@google.com <ap...@google.com> #92
ap...@google.com <ap...@google.com> #93
phone still plays notification sounds *through the speaker* while you're
wearing headphones? Because you need the whole room to know when you get a
text? How stupid! My iPhone has never done that - not even in it's first
version!"
And now we've gone through two software updates and still no resolution.
Shouldn't this be a simple fix?
ap...@google.com <ap...@google.com> #94
ap...@google.com <ap...@google.com> #95
ap...@google.com <ap...@google.com> #96
We MUST be missing something.
ap...@google.com <ap...@google.com> #97
android. Please fix it.
ap...@google.com <ap...@google.com> #98
ap...@google.com <ap...@google.com> #99
Repair, factory reset, clean reset, reinstall OS, nope, nada, nothing..
ap...@google.com <ap...@google.com> #100
HEADPHONES PLUGGED IN = NO EXTERNAL SOUND
Should be a simple concept!
ap...@google.com <ap...@google.com> #101
ap...@google.com <ap...@google.com> #102
ap...@google.com <ap...@google.com> #103
ap...@google.com <ap...@google.com> #104
ap...@google.com <ap...@google.com> #105
ap...@google.com <ap...@google.com> #106
ap...@google.com <ap...@google.com> #107
ap...@google.com <ap...@google.com> #108
ap...@google.com <ap...@google.com> #109
ap...@google.com <ap...@google.com> #110
ap...@google.com <ap...@google.com> #111
ap...@google.com <ap...@google.com> #112
ap...@google.com <ap...@google.com> #113
ap...@google.com <ap...@google.com> #114
ap...@google.com <ap...@google.com> #115
ap...@google.com <ap...@google.com> #116
Can't believe this has been an issue for 1.5 yrs . . .
ap...@google.com <ap...@google.com> #117
ap...@google.com <ap...@google.com> #118
ap...@google.com <ap...@google.com> #119
ap...@google.com <ap...@google.com> #120
ap...@google.com <ap...@google.com> #121
ap...@google.com <ap...@google.com> #122
ap...@google.com <ap...@google.com> #123
ap...@google.com <ap...@google.com> #124
ap...@google.com <ap...@google.com> #125
Also, sidenote, wtf is up with the long delay between pausing the music, playing the notification, then restarting the music. There is seriously a 1-2 second fade in and fade out along with some silence...
ap...@google.com <ap...@google.com> #126
ap...@google.com <ap...@google.com> #127
ap...@google.com <ap...@google.com> #128
ap...@google.com <ap...@google.com> #129
ap...@google.com <ap...@google.com> #130
DEFINITELY NEEDS A FIX.
ap...@google.com <ap...@google.com> #131
Even as a die hard Mac user I've been actively avoiding the iPhone since it's birth due to the fact that as a phone, it's crap (until the 4s) and I refused to pay AT&T. But the basic pros are now FAR outweighing the cons. The minute I can upgrade I'm getting an iPhone.
ap...@google.com <ap...@google.com> #132
ap...@google.com <ap...@google.com> #133
ap...@google.com <ap...@google.com> #134
Also confirmed on a Galaxy Nexus S running Android 4.1.1
Notes:
1. Some people claim this can be fixed if music is played first then headphones plugged in. This did not work for me.. notifications still end up being played through headphones and speaker.
2. There is talk about the jack sensing being incorrect due to the different standards OMTP and CTIA.. where lots of headphones are Apple (OMTP) and the Nexus 4 supposedly having a CITA standard hence the issue. My two cents is: it is acceptable for headphone/set features such as volume control and call answering to not work if you do not have the correct headset, however it is not acceptable for the phone to not sense that a headset is plugged in and not cut audio to the speaker. Any Google developer who thinks this is by design or a feature without having a configurable option to turn it off should be fired. Do laptops still play notifications through the speaker when headphones are plugged in? No.
3. There is a chance of reporting a false positive of it working when testing.. You need to change the ringer volume or actually call the phone, do not change the ringtone as it will properly get piped through to the headset (with a weird split second play to the speaker first).
4. I tried a few different pairs of headphones to see if any would make the phone push notifications to headphones only, none worked, sounds was still coming out of headphones and speaker for ringtone/calls and notifications.
- Apple iPod headphones
- Aftermarket headset
- Samsung Galaxy S3 headset (I was surprised they still didn't work)
Workaround:
SoundAbout works for me.. thanks to comment 127 who sneakingly pitched his own app.
I wonder how many more apps will be developed to band-aid bugs in the core OS.
ap...@google.com <ap...@google.com> #135
ap...@google.com <ap...@google.com> #136
ap...@google.com <ap...@google.com> #137
ap...@google.com <ap...@google.com> #138
ap...@google.com <ap...@google.com> #139
ap...@google.com <ap...@google.com> #140
ap...@google.com <ap...@google.com> #141
ap...@google.com <ap...@google.com> #142
ap...@google.com <ap...@google.com> #143
ap...@google.com <ap...@google.com> #144
ap...@google.com <ap...@google.com> #145
ap...@google.com <ap...@google.com> #146
Very counterintuitive behavior and contrary to pretty much any portable device ever manufactured since the beginning of the 1/8" jack. (and probably before.)
ap...@google.com <ap...@google.com> #147
ap...@google.com <ap...@google.com> #148
ap...@google.com <ap...@google.com> #149
ap...@google.com <ap...@google.com> #150
I would really like more customizable bluetooth sound options.
I have a bluetooth speaker at home and would like the phone to plug in to that to play alarms, notifications, ringtones and media. Media playback works fine as is but everything else is played twice (once through phones speader and a fraction of a second later through bluetooth speaker) which is really disturbing.
ap...@google.com <ap...@google.com> #151
ap...@google.com <ap...@google.com> #152
ap...@google.com <ap...@google.com> #153
ap...@google.com <ap...@google.com> #154
ap...@google.com <ap...@google.com> #155
ap...@google.com <ap...@google.com> #156
ap...@google.com <ap...@google.com> #157
ap...@google.com <ap...@google.com> #158
ap...@google.com <ap...@google.com> #159
ap...@google.com <ap...@google.com> #160
And it's the first phone I have purchased that comes with no headset included in the package!
ap...@google.com <ap...@google.com> #161
Bought a Samsung Galaxy Note 2 and now get this bug. Running stock Android form Samsung (4.1.2).
Incredibly annoying, since a) I'm used to not experiencing this behavior and b) it sometimes causes music to briefly play from external speaker whilst headphones are connected!
Please fix ASAP.
ap...@google.com <ap...@google.com> #162
Please fix this BUG.
ap...@google.com <ap...@google.com> #163
ap...@google.com <ap...@google.com> #164
What the hell Google?
ap...@google.com <ap...@google.com> #165
ap...@google.com <ap...@google.com> #166
Like a bad twilight zone episode..
ap...@google.com <ap...@google.com> #167
ap...@google.com <ap...@google.com> #168
ap...@google.com <ap...@google.com> #169
Same problem.
ap...@google.com <ap...@google.com> #170
ap...@google.com <ap...@google.com> #171
my opinion when headphones are attached all sound goes through headphones... Bluetooth or other wise...
ap...@google.com <ap...@google.com> #172
ap...@google.com <ap...@google.com> #173
ap...@google.com <ap...@google.com> #174
ap...@google.com <ap...@google.com> #175
ap...@google.com <ap...@google.com> #176
ap...@google.com <ap...@google.com> #177
ap...@google.com <ap...@google.com> #178
ap...@google.com <ap...@google.com> #179
ap...@google.com <ap...@google.com> #180
ap...@google.com <ap...@google.com> #181
ap...@google.com <ap...@google.com> #182
ap...@google.com <ap...@google.com> #183
ap...@google.com <ap...@google.com> #184
PD: Thank u guys for the SoundAbout post!
ap...@google.com <ap...@google.com> #185
ap...@google.com <ap...@google.com> #186
This issue was logged 2 years, 5 months, and 14 days ago and it's STILL not fixed. Absolutely ridiculous. This is how you choose to treat your users Google?!
ap...@google.com <ap...@google.com> #187
ap...@google.com <ap...@google.com> #188
now I have the choice of letting everyone in the office hear my notifications or no one hearing them.
ap...@google.com <ap...@google.com> #189
Thank you for contacting Samsung Telecommunications America.
After reviewing your E-Mail, we understand that you are able to hear the notification sounds through both speaker and headphones when a headset is connected.
We are sorry to inform you that there are no configurable options or settings available to turn on/off the ability to hear the ringtones only through the headset, they are heard through the handset also. This is a matter of safety, as the decibel level for a normal call is much lower than that of a ringtone. Due to the decibel level of a ringtone being much louder than the human voice, the ringtones are not audible through the headset to protect against possible hearing loss. You can also find the same information on the Samsung website, please access the weblink below.
Link:
Please feel free to get back to us if you have any further queries. We will be glad to assist you.
Should you have more questions regarding your Samsung Mobile Phone, you can also reach out to our chat support team by accessing the following link. Live Chat is available 24 hours a day. 7 days a week
Link:
Thank you for your continued interest in Samsung products.
Sincerely,
Allen
Technical Support
ap...@google.com <ap...@google.com> #190
ap...@google.com <ap...@google.com> #191
ap...@google.com <ap...@google.com> #192
Sorry, but that seems to me an absurd justification, on their part. It would be trivial to limit the pressure range to what would be output as a sound with a safe decibel level for all normal headphones. Even if the headphones are amplified, if the user can be trusted to choose a safe output pressure range for voice/music, then you can limit the voltage variation to the same range for the notification.
Moreover, even if there's a concern that the envelopes for sounds used in notifications tend to brush the pressure range limits more than conversation audio or music (doubtful, for some music genres): Fine, the OS could dynamically limit notification volume over earphones to somelthing like 2/3 or 1/2 of whatever the current "Music & Video" audio level is set to. That should be quite adequate, as a safety precaution.
ap...@google.com <ap...@google.com> #193
ap...@google.com <ap...@google.com> #194
ap...@google.com <ap...@google.com> #195
ap...@google.com <ap...@google.com> #196
For your viewing pleasure:
ap...@google.com <ap...@google.com> #197
ap...@google.com <ap...@google.com> #198
ap...@google.com <ap...@google.com> #199
I can't believe that this is a bug that has such long legs as it does. This behavior is reproducible on my Galaxy S (GT-I9000). And I have no idea why?
ap...@google.com <ap...@google.com> #200
But recently have this issue, strange !
ap...@google.com <ap...@google.com> #201
Same issue on galaxy s2 plus
ap...@google.com <ap...@google.com> #202
ap...@google.com <ap...@google.com> #203
ap...@google.com <ap...@google.com> #204
ap...@google.com <ap...@google.com> #205
At night I love listening music but I don't want to wake up anyone so I use my mlp rainbow dash headphones last night I plugged in my headphones in my tablet I played music but I didn't hear music even my volume is up all the way so I unplugged them then turned the volume very low and play music but it worked someone please help.
ap...@google.com <ap...@google.com> #206
ap...@google.com <ap...@google.com> #207
ap...@google.com <ap...@google.com> #208
ap...@google.com <ap...@google.com> #209
ap...@google.com <ap...@google.com> #210
ap...@google.com <ap...@google.com> #211
ap...@google.com <ap...@google.com> #212
ap...@google.com <ap...@google.com> #213
i had android 4.1.2 on my galaxy S2 and that worked as stated as "BUG" but as a feature for me.
Now i rooted my phone to get KitKat 4.4.4 and now the "bug" is gone.
Also this "BUG" is critical to my phone cause the phoneplug is broken so even if i remove my earphones it still thinks they are connected, So i ALWAYS have my earphones connected, and due to my broken earplug i miss ALOT of calls when no sound comes thru speaker.
how about some options to make us choose what we want?
ap...@google.com <ap...@google.com> #214
ap...@google.com <ap...@google.com> #215
ap...@google.com <ap...@google.com> #216
ap...@google.com <ap...@google.com> #217
and HTC one M7
ap...@google.com <ap...@google.com> #218
Happens both on
Samsung galaxy note 8, Software version android 4.4.2 .
HTC one m7 Software version android 4.4.3 on htc one m7.
ap...@google.com <ap...@google.com> #219
ap...@google.com <ap...@google.com> #220
ap...@google.com <ap...@google.com> #221
ap...@google.com <ap...@google.com> #222
ap...@google.com <ap...@google.com> #223
ap...@google.com <ap...@google.com> #224
ap...@google.com <ap...@google.com> #225
ap...@google.com <ap...@google.com> #226
ap...@google.com <ap...@google.com> #227
ap...@google.com <ap...@google.com> #228
ap...@google.com <ap...@google.com> #229
ap...@google.com <ap...@google.com> #230
ap...@google.com <ap...@google.com> #231
ap...@google.com <ap...@google.com> #232
ap...@google.com <ap...@google.com> #233
Keep the comments coming, eventually they will get tired of us! Or a serious competitor to Android that isn't Apple will come along and then we won't have to put up with this nonsense any more.
ap...@google.com <ap...@google.com> #234
ap...@google.com <ap...@google.com> #235
ap...@google.com <ap...@google.com> #236
ap...@google.com <ap...@google.com> #237
ap...@google.com <ap...@google.com> #238
ap...@google.com <ap...@google.com> #239
ap...@google.com <ap...@google.com> #240
"When I am at work, I want everyone else to know how popular I am even when I have my headphones in." This has to be the thought process.
ap...@google.com <ap...@google.com> #241
SoundAbout app is broken with Lollypop so there is NO way to fix this. Come on, Google. What's so hard about this?
ap...@google.com <ap...@google.com> #242
We should have at least some options.
ap...@google.com <ap...@google.com> #243
I read Samsung's answer in post 189... but I thought the purpose of an Android device was that it was MORE customizable. And now it looks like SoundAbout isn't available as a workaround...
ap...@google.com <ap...@google.com> #244
ap...@google.com <ap...@google.com> #245
ap...@google.com <ap...@google.com> #246
ap...@google.com <ap...@google.com> #247
ap...@google.com <ap...@google.com> #248
ap...@google.com <ap...@google.com> #249
ap...@google.com <ap...@google.com> #250
ap...@google.com <ap...@google.com> #251
ap...@google.com <ap...@google.com> #252
ap...@google.com <ap...@google.com> #253
Please allow the USER to decide how they want notifications to behave! That's normally where Android shines.
ap...@google.com <ap...@google.com> #254
ap...@google.com <ap...@google.com> #255
Please Google, do something ! It's not that complicated.
ap...@google.com <ap...@google.com> #256
ap...@google.com <ap...@google.com> #257
ap...@google.com <ap...@google.com> #258
ap...@google.com <ap...@google.com> #259
ap...@google.com <ap...@google.com> #260
ap...@google.com <ap...@google.com> #261
ap...@google.com <ap...@google.com> #262
ap...@google.com <ap...@google.com> #263
ap...@google.com <ap...@google.com> #264
ap...@google.com <ap...@google.com> #265
ap...@google.com <ap...@google.com> #266
ap...@google.com <ap...@google.com> #267
ap...@google.com <ap...@google.com> #268
Audio comes both from device speaker and headphones
ap...@google.com <ap...@google.com> #269
ap...@google.com <ap...@google.com> #270
And having the phone silenced is even worse because when I go around in the city and listen to music, I have two options:
1. let everyone know that my mobile phone did something
2. let no one know (including myself) that there are any notifications
It should be fixed already, at least make it an option to turn off!!!
ap...@google.com <ap...@google.com> #271
On HTC this was NOT the case. HTC made things properly on Android 4.2: Earphones IN, Speakers OFF. Apearently other HTC-users report the same issue.
What is the matter with this? It is very disapointing not to have this function working.
ap...@google.com <ap...@google.com> #272
ap...@google.com <ap...@google.com> #273
ap...@google.com <ap...@google.com> #274
ap...@google.com <ap...@google.com> #275
ap...@google.com <ap...@google.com> #276
ap...@google.com <ap...@google.com> #277
ap...@google.com <ap...@google.com> #278
ap...@google.com <ap...@google.com> #279
It's absolutely insane that the default behavour when headphones are plugged in is to play rings and notifications through the external speaker and not the headphones.
The other day while commuting on a train my phone was ringing on max volume while I was listening to a podcast and the only reason I knew was because it was also vibrating...meanwhile half the train is staring at me wondering WTF?
At the very least there should be an option to pick how you want your phone to behave.
ap...@google.com <ap...@google.com> #280
ap...@google.com <ap...@google.com> #281
ap...@google.com <ap...@google.com> #282
ap...@google.com <ap...@google.com> #283
Google has guidelines on material for UX, but hundred dollars smart phones cannot do that, this is purely software related.
ap...@google.com <ap...@google.com> #284
Why we use headphones, or also in my case bluetooth-to-hearing-aids, is to shield others around us and protect ourselves from advertising every interrupt.
Sigh.
ap...@google.com <ap...@google.com> #285
ap...@google.com <ap...@google.com> #286
ap...@google.com <ap...@google.com> #287
ap...@google.com <ap...@google.com> #288
this issue.
On Mon, Aug 28, 2017 at 3:56 PM, <buganizer-system@google.com> wrote:
ap...@google.com <ap...@google.com> #289
ap...@google.com <ap...@google.com> #290
ap...@google.com <ap...@google.com> #291
ap...@google.com <ap...@google.com> #292
ap...@google.com <ap...@google.com> #293
ap...@google.com <ap...@google.com> #294
ap...@google.com <ap...@google.com> #295
Also, with headphones plugged in, add me in to the list of the notifications coming over phone speakers and not headphones.
ap...@google.com <ap...@google.com> #296
ap...@google.com <ap...@google.com> #297
ap...@google.com <ap...@google.com> #298
ap...@google.com <ap...@google.com> #299
This WAS an issue for me when I used PowerAmp. Recently, I switched to Black Player and I stopped having issues. The difference was I didn't use fade-out for stopping music playback.
ap...@google.com <ap...@google.com> #300
ap...@google.com <ap...@google.com> #301
ap...@google.com <ap...@google.com> #302
On Sat, Jan 26, 2019, 8:35 PM <buganizer-system@google.com> wrote:
ap...@google.com <ap...@google.com> #304
Branch: main
commit e2a260e0c57527793747cdca5546de3a5ac5e12a
Author: Matt Mueller <mattm@chromium.org>
Date: Wed Aug 14 16:20:16 2024
net/cert/x509_certificate spanification fixes
Bug: 40284755
Change-Id: Ifcd0e32d85354fe56779ddef0c5fe645f71e41a4
Reviewed-on:
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1341713}
M net/cert/x509_certificate.cc
M net/cert/x509_certificate_unittest.cc
ap...@google.com <ap...@google.com> #305
Branch: main
commit 58bfcc525abee92abce83078a14519cf86142e49
Author: Jan Keitel <jkeitel@google.com>
Date: Fri Aug 16 16:43:55 2024
Fix unsafe buffer warnings in memory_infra_background_allowlist.cc.
Bug: 40284755
Change-Id: Ie9fda863e8070d44bf3b8b085d38bbdd3b2ec4b3
Reviewed-on:
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Auto-Submit: Jan Keitel <jkeitel@google.com>
Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1342872}
M base/trace_event/memory_dump_manager_unittest.cc
M base/trace_event/memory_infra_background_allowlist.cc
M base/trace_event/memory_infra_background_allowlist.h
M base/trace_event/process_memory_dump_unittest.cc
M services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
ap...@google.com <ap...@google.com> #306
Branch: main
commit 615c47f4a1756ef2bdf378e7cf3b66147f5f5441
Author: Matt Mueller <mattm@chromium.org>
Date: Mon Aug 19 20:56:02 2024
net/cert/x509_util_win spanification fixes
Bug: 40284755
Change-Id: Ib18df38b96ae851558b9f1e3379a2c1c87e1d3af
Reviewed-on:
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1343749}
M net/cert/x509_util_win.cc
M net/cert/x509_util_win.h
ap...@google.com <ap...@google.com> #307
Branch: main
commit a22501dd13553556b1d91b9711b0e5d11fe2044d
Author: Matt Mueller <mattm@chromium.org>
Date: Mon Aug 19 21:06:35 2024
cert_net_fetcher spanification fixes
Also fix bug in calculating vector::reserve() amount in
net/cert_net/cert_net_fetcher_url_request.cc
Bug: 40284755
Change-Id: Ieb1bba2edbf057cdf62119570ee8082fc9acef45
Reviewed-on:
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1343758}
M net/cert_net/cert_net_fetcher_url_request.cc
M services/cert_verifier/cert_net_url_loader/cert_net_fetcher_url_loader.cc
ap...@google.com <ap...@google.com> #308
Branch: main
commit 4e6b0489c2f04bae643fb8cc9f747ee3c6e86be3
Author: kelsen liu <kelsenliu21@gmail.com>
Date: Tue Aug 20 03:19:19 2024
Spanify MaskWebSocketFramePayload method to avoid unsafe buffer usage
This CL spanifies the `MaskWebSocketFramePayload` and
`MaskWebSocketFramePayloadByBytes` methods, replaces unchecked pointers
with `base::span`, and enables unsafe-buffer-usage warnings in
`websocket_frame`.
Bug: 40284755,354307327
Change-Id: I98710ab69174ef6d2049a7deaf6d203c528101ab
Reviewed-on:
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: kelsen liu <kelsenliu21@gmail.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1343917}
M chrome/test/chromedriver/net/websocket.cc
M net/server/http_server_unittest.cc
M net/websockets/websocket_basic_stream.cc
M net/websockets/websocket_frame.cc
M net/websockets/websocket_frame.h
M net/websockets/websocket_frame_parser_test.cc
M net/websockets/websocket_frame_perftest.cc
M net/websockets/websocket_frame_test.cc
M services/network/public/cpp/server/http_server_unittest.cc
ap...@google.com <ap...@google.com> #309
Branch: main
commit 407ffd9d02238e21b381a56cc946fb264dfb34b8
Author: kelsen liu <kelsenliu21@gmail.com>
Date: Wed Aug 21 09:12:39 2024
Spanify EncodeChunk method to avoid unsafe buffer usage
This CL spanifies the `HttpStreamParser::EncodeChunk` method, replaces
unchecked pointers with `base::span<uint8_t>`, and enables
unsafe-buffer-usage warnings in `http_stream_parser`.
Bug: 40284755,354307327
Change-Id: I2047a97288cdc4ab06f1a38e49fa6a388c889b98
Reviewed-on:
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: kelsen liu <kelsenliu21@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1344655}
M net/http/http_stream_parser.cc
M net/http/http_stream_parser.h
M net/http/http_stream_parser_unittest.cc
ap...@google.com <ap...@google.com> #310
Branch: main
commit 557e5626f3c8ca00f9608b5f6ddf9b4f54f5721e
Author: Tom Sepez <tsepez@chromium.org>
Date: Fri Aug 30 21:50:12 2024
Avoid calling unsafe RefCountedBytes and RefCountedStaticMemory ctors.
Callers all have data that is easily convertible to spans. A
subsequent CL will then remove the unsafe forms.
Bug: 40284755
Change-Id: I157bb4e5475fb22023bf37bff3f91dc75f41caf9
Reviewed-on:
Owners-Override: Lei Zhang <thestig@chromium.org>
Auto-Submit: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1349443}
M ash/webui/web_applications/webui_test_prod_util.cc
M chrome/browser/ash/login/users/avatar/user_image_loader.cc
M chrome/browser/ash/os_feedback/chrome_os_feedback_delegate_browsertest.cc
M chrome/browser/ash/os_feedback/os_feedback_screenshot_manager_unittest.cc
M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_user_provider_impl.cc
M chrome/browser/ash/system_web_apps/apps/personalization_app/personalization_app_user_provider_impl_unittest.cc
M chrome/browser/devtools/device/usb/android_usb_device.cc
M chrome/browser/enterprise/data_protection/print_utils_unittest.cc
M chrome/browser/extensions/api/printer_provider/printer_provider_apitest.cc
M chrome/browser/printing/pwg_raster_converter_browsertest.cc
M chrome/browser/ui/views/web_apps/web_app_integration_test_driver.cc
M chrome/browser/ui/webui/devtools/devtools_ui_data_source.cc
M chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc
M chrome/browser/ui/webui/print_preview/pdf_printer_handler_posix_unittest.cc
M chrome/browser/ui/webui/print_preview/print_preview_handler_unittest.cc
M chrome/browser/ui/webui/print_preview/print_preview_ui_untrusted_unittest.cc
M content/browser/webui/web_ui_data_source_unittest.cc
M mojo/public/cpp/base/ref_counted_memory_mojom_traits.cc
M remoting/host/linux/x11_util.cc
M remoting/host/linux/x_server_clipboard.cc
M services/device/public/cpp/test/mock_hid_connection.cc
M services/device/public/cpp/test/mock_hid_service.cc
M services/network/web_bundle/web_bundle_chunked_buffer_unittest.cc
M ui/base/resource/resource_data_dll_win.cc
M ui/base/x/selection_utils.cc
M ui/base/x/x11_util.cc
ap...@google.com <ap...@google.com> #311
Branch: main
commit 0562217b969cfde4f7f138a720ad004cff0cdb8f
Author: kelsen liu <kelsenliu21@gmail.com>
Date: Sat Aug 31 03:05:34 2024
Spanify UploadBytesElementReader to avoid unsafe buffer usage
This CL spanifies the `UploadBytesElementReader` constructor, replaces
unchecked pointers with `base::span<uint8_t>`, updates related test
cases, and enables unsafe-buffer-usage warnings in
`upload_bytes_element_reader`.
Bug: 40284755, 354307327
Change-Id: I17112dba82de596a3c3477e0bbbda3ecb501ea5c
Reviewed-on:
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: kelsen liu <kelsenliu21@gmail.com>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1349521}
M extensions/browser/api/web_request/upload_data_presenter_unittest.cc
M ios/net/
M net/base/elements_upload_data_stream_unittest.cc
M net/base/upload_bytes_element_reader.cc
M net/base/upload_bytes_element_reader.h
M net/base/upload_bytes_element_reader_unittest.cc
M net/dns/dns_transaction.cc
M net/dns/dns_transaction_unittest.cc
M net/http/http_cache_unittest.cc
M net/http/http_network_transaction_unittest.cc
M net/http/http_stream_parser_unittest.cc
M net/quic/quic_end_to_end_unittest.cc
M net/quic/quic_http_stream_test.cc
M net/spdy/spdy_network_transaction_unittest.cc
M net/test/embedded_test_server/embedded_test_server_unittest.cc
M net/url_request/url_request_unittest.cc
M services/device/test/usb_test_gadget_impl.cc
M services/network/url_loader.cc
ap...@google.com <ap...@google.com> #312
Branch: main
commit eb504b0fdbc7e93e56ea844ff29954325865e3a8
Author: Tom Sepez <tsepez@chromium.org>
Date: Wed Sep 04 21:02:40 2024
Convert unsafe RefCountedBytes / RefCountedStaticMemory ctors, part 2
A previous CL has removed most callers of the unsafe forms. This one
remove more cases missed in that patch.
Bug: 40284755
Change-Id: I52ea6d4d059e4d46aa128cea4f74ec28cf3e4909
Reviewed-on:
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Owners-Override: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351051}
M ash/webui/media_app_ui/media_app_guest_ui.cc
M chrome/browser/printing/pdf_to_emf_converter_browsertest.cc
M chrome/browser/printing/print_view_manager_unittest.cc
M chromecast/browser/cast_resource_bundle_unittest.cc
M components/favicon/core/favicon_database_unittest.cc
M components/history/core/browser/expire_history_backend_unittest.cc
M ios/chrome/app/spotlight/
M ios/chrome/app/spotlight/
M ios/chrome/app/spotlight/
M mojo/public/cpp/base/ref_counted_memory_unittest.cc
M third_party/inspector_protocol/crdtp/chromium/protocol_traits.cc
M ui/base/resource/data_pack.cc
M ui/base/resource/data_pack_with_resource_sharing_lacros.cc
M ui/base/resource/resource_bundle.cc
M ui/base/resource/resource_bundle_unittest.cc
M ui/base/resource/resource_data_dll_win.cc
M ui/gfx/icon_util.cc
ap...@google.com <ap...@google.com> #313
Branch: main
commit 0864e61788db17c2a4c3ed5dfd2c288956a2b03e
Author: Tom Sepez <tsepez@chromium.org>
Date: Thu Sep 05 20:14:36 2024
Remove unsafe forms of RefCountedBytes / RefCountedStaticMemory ctors
Previous CLs have removed callers; this CL removes the code itself.
Bug: 40284755
Change-Id: I39c9f5798c9a4a74f0223063d6b96a8eb1879b0c
Reviewed-on:
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1351657}
M base/memory/ref_counted_memory.cc
M base/memory/ref_counted_memory.h
M base/memory/ref_counted_memory_unittest.cc
ap...@google.com <ap...@google.com> #314
Branch: main
commit ccf6613682a24413db28656da6f9c52948331bad
Author: danakj <danakj@chromium.org>
Date: Thu Sep 05 16:59:38 2024
Pass crdtp::span to Binary::fromSpan.
In chromium it will be received as a base::span, which can construct
from crdtp::span because the latter has .data() and .size() members.
Bug: 40284755
Change-Id: I8a57f80d36ec07bc00661589dac9cc6cf7d11029
M lib/Values_cpp.template
ap...@google.com <ap...@google.com> #315
Branch: main
commit a4c24b985517def52f143bdc597bf0bef1a7dfde
Author: danakj <danakj@chromium.org>
Date: Fri Sep 06 13:45:08 2024
Remove RefCountedBytes unsafe ctor, use spans in devtools fromSpan
Bug: 40284755
Low-Coverage-Reason: changing types in existing code
Change-Id: Ifcd1248c45e631df7f78bc3637538fdf597dabce
Reviewed-on:
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1352005}
M content/browser/devtools/protocol/network_handler.cc
M content/browser/devtools/protocol/webauthn_handler.cc
M third_party/blink/renderer/DEPS
M third_party/blink/renderer/core/inspector/inspector_network_agent.cc
M third_party/blink/renderer/core/inspector/v8_inspector_string.cc
M third_party/blink/renderer/core/inspector/v8_inspector_string.h
M third_party/inspector_protocol/crdtp/chromium/protocol_traits.cc
M third_party/inspector_protocol/crdtp/chromium/protocol_traits.h
M third_party/inspector_protocol/crdtp/chromium/protocol_traits_test.cc
M third_party/inspector_protocol/lib/Values_cpp.template
ap...@google.com <ap...@google.com> #316
Branch: main
commit 2a6d29d17fc80214174f795f14cfde4b96198904
Author: kelsen liu <kelsenliu21@gmail.com>
Date: Mon Sep 09 07:58:47 2024
Spanify ImageResource::MultipartDataReceived
This CL replaces the raw pointer and size parameters in the
`MultipartDataReceived` method with `base::span<const uint8_t>` to
avoid unsafe buffer usage, and enables unsafe-buffer-usage warnings in
`multipart_image_resource_parser`.
Using `span<const uint8_t>` clarifies that the data is binary and
should be treated as a sequence of bytes, not necessarily as text.
Bug: 40284755
Change-Id: I6e9e7cc94f51245c555929acf6fb6edaca7f714b
Reviewed-on:
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: kelsen liu <kelsenliu21@gmail.com>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1352587}
M third_party/blink/renderer/core/loader/resource/image_resource.cc
M third_party/blink/renderer/core/loader/resource/image_resource.h
M third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.cc
M third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.h
M third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser_test.cc
ap...@google.com <ap...@google.com> #317
Branch: main
commit 38a04b856f0a6435b709098f42640daa0df0d86c
Author: danakj <danakj@chromium.org>
Date: Mon Sep 09 20:02:49 2024
Remove deprecated pointer-based methods for JNI Arrays
Change all callers to construct and pass in span safely instead.
Bug: 40284755
Change-Id: I9296dea6dc0365434d9797133afd92f1e891a66c
Reviewed-on:
Commit-Queue: danakj <danakj@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1352950}
M base/android/jni_array.cc
M base/android/jni_array.h
M chrome/browser/feedback/android/process_id_feedback_source.cc
M chrome/browser/ui/android/hats/survey_client_android.cc
M components/omnibox/browser/omnibox_url_emphasizer.cc
M components/segmentation_platform/public/android/input_context_android_unittest.cc
M components/signin/public/identity_manager/account_capabilities.cc
M components/translate/content/android/translate_message.cc
M content/browser/accessibility/web_contents_accessibility_android.cc
M media/base/android/media_codec_bridge_impl.cc
M mojo/public/java/system/core_impl.cc
ap...@google.com <ap...@google.com> #318
Branch: main
commit 9ee550154bbfab6859d91a985fb822ef098e23d2
Author: Matt Mueller <mattm@chromium.org>
Date: Tue Sep 10 19:58:31 2024
TrustStoreWin spanification fixes
Bug: 40284755
Change-Id: I43ca83f1f573c5a9a90b90c0a8742040d1b7a550
Reviewed-on:
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1353552}
M net/cert/internal/trust_store_win.cc
ap...@google.com <ap...@google.com> #319
Branch: main
commit bcf75393afa3be2e1a5edc8fe5ffffe6e894c690
Author: danakj <danakj@chromium.org>
Date: Tue Sep 10 21:52:24 2024
Remove unsafe buffer usage warnings in flat_tree.h
The insert(iter, iter) method is where things go bad if the inputs are
pointers. Add an overload for pointers that makes a span from them and
mark it as UNSAFE_BUFFER_USAGE.
The insert(iter, iter) method then assumes the iterator checks to be
from the same container when comparing, and no UNSAFE_BUFFERS is needed
internally.
Add insert_range() member to insert objects without dealing with
iterator pairs.
Bug: 40284755
Change-Id: I83273ce0c17d8420e09d58520b8f050fb562269c
Reviewed-on:
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1353599}
M base/containers/flat_tree.h
M base/containers/flat_tree_unittest.cc
M base/containers/id_map.h
ap...@google.com <ap...@google.com> #320
Branch: main
commit b572cb934ba42b8df85c264780cc18f909d2bc65
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date: Wed Sep 11 18:03:56 2024
Spanify //codelabs.
Remove the //codelabs directory from the exclusion list. Use
base::CommandLine to solve argv bound checking problems.
Bug: 40284755
Change-Id: I20021cba9039d436f798e60dd4db223d94b35b71
Reviewed-on:
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354073}
M build/config/unsafe_buffers_paths.txt
M codelabs/cpp101/solutions/factor.cc
M codelabs/cpp101/solutions/fibonacci.cc
M codelabs/cpp101/solutions/mojo.cc
M codelabs/cpp101/solutions/sleep.cc
ap...@google.com <ap...@google.com> #321
Branch: main
commit addee8b268ffd06aca26745b57b09b289eb956f8
Author: kelsen liu <kelsenliu21@gmail.com>
Date: Sat Sep 21 03:20:56 2024
Spanify net::HttpUtil
This CL spanifies some methods in `HttpUtil`, replaces unchecked
pointers with `base::span<uint8_t>`, and updates related test cases.
Bug: 40284755, 354307327
Change-Id: I70402cbc4e4c2a9be3afce3775ce16f7e73e1a71
Reviewed-on:
Commit-Queue: kelsen liu <kelsenliu21@gmail.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Vladimir Nechaev <nechaev@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1358510}
M chrome/browser/media/router/discovery/dial/dial_service_impl.cc
M chrome/services/cups_proxy/proxy_manager.cc
M chrome/services/cups_proxy/public/cpp/type_conversions.cc
M chrome/services/cups_proxy/public/cpp/type_conversions.h
M chrome/services/cups_proxy/socket_manager.cc
M chrome/services/ipp_parser/ipp_parser.cc
M chrome/test/chromedriver/net/websocket.cc
M content/browser/devtools/protocol/network_handler.cc
M net/http/http_stream_parser.cc
M net/http/http_util.cc
M net/http/http_util.h
M net/http/http_util_unittest.cc
M net/server/http_server_unittest.cc
M third_party/blink/renderer/core/fetch/multipart_parser.cc
M third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.cc
M third_party/blink/renderer/platform/network/http_parsers.cc
M third_party/blink/renderer/platform/network/http_parsers.h
M third_party/blink/renderer/platform/network/http_parsers_fuzzer.cc
M third_party/blink/renderer/platform/network/http_parsers_test.cc
ap...@google.com <ap...@google.com> #322
Project: chromium/src
Branch: main
Author: danakj <
Link:
Remove unsafe-buffers warnings in the stack trace code
Expand for full commit details
Remove unsafe-buffers warnings in the stack trace code
Add strlcpy, u16cstrlcpy, and wcslcpy variants that work with span
and basic_string_view. Leave a TODO to mark the old pointer-based ones
as UNSAFE_BUFFER_USAGE.
While adding tests for them, we determined that span's operator<<
will allow itself to be called when it will fail to compile internally.
To avoid that, add a requires clause on it that the input can be
converted to a string_view or that it can be printed with base::ToString
and then fix base::ToString to not fail to compile if given a char-like
type like char16_t.
R=dcheng@chromium.org
Bug: 40284755
Change-Id: Ic3c763991670d09ff2d2268739a5b82577980dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5902358
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366129}
Files:
- M
base/containers/span.h
- M
base/debug/stack_trace.h
- M
base/debug/stack_trace_android.cc
- M
base/debug/stack_trace_posix.cc
- M
base/debug/stack_trace_unittest.cc
- M
base/debug/stack_trace_win.cc
- M
base/strings/string_util.cc
- M
base/strings/string_util.h
- M
base/strings/string_util_impl_helpers.h
- M
base/strings/string_util_unittest.cc
- M
base/strings/to_string.h
Hash: d53babfe4b33ba45398bbd3543ab09ccc187a5ec
Date: Wed Oct 09 14:04:16 2024
ap...@google.com <ap...@google.com> #323
Project: chromium/src
Branch: main
Author: danakj <
Link:
Allow printing of spans and single multi-byte chars
Expand for full commit details
Allow printing of spans and single multi-byte chars
Add support for printing char16_t, wchar_t and char32_t to
base::ToString instead of printing the address of each char.
Add support for as_string_view of spans of char16_t or wchar_t.
Add support for printing spans of char16_t or wchar_t with the
operator<< overloads in base/strings/utf_ostream_operators.h for
basic_string_view<char16_t> and basic_string_view<wchar_t>.
R=dcheng@chromium.org
Bug: 40284755
Change-Id: I80e6e0d5189ec7c7f67ca541ebc94bf9ff80abbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5916947
Commit-Queue: danakj <danakj@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366160}
Files:
- M
base/containers/span.h
- M
base/containers/span_unittest.cc
- M
base/strings/string_util_unittest.cc
- M
base/strings/to_string.h
- M
base/strings/to_string_unittest.cc
Hash: a406f1c0918f4817025c2a919cdca4391bcf3cd5
Date: Wed Oct 09 14:46:53 2024
ap...@google.com <ap...@google.com> #324
Project: chromium/src
Branch: main
Author: Jérôme Lebel <
Link:
Add back allow_unsafe_buffers in stack_trace_posix.cc
Expand for full commit details
Add back allow_unsafe_buffers in stack_trace_posix.cc
In crrev.com/c/5902358 `allow_unsafe_buffers` was removed from
`base/debug/stack_trace_posix.cc`.
This is generate an error to build Canary for iOS:
https://ci.chromium.org/ui/p/chrome/builders/official/ios-dcheck/1411/overview
With in line 269:
const char* basename = last_sep ? last_sep + 1 : dl_info.dli_fname
This patch adds back `allow_unsafe_buffers`. The original patch cannot
be reverted without conflicts.
Bug: 40284755
Fixed: 372584479
Change-Id: I862e0a3e360810964c7976895c4b20e9b00b6f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5922814
Reviewed-by: danakj <danakj@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1366811}
Files:
- M
base/debug/stack_trace_posix.cc
Hash: 3a702f76b1ec619f5ff6aad9aededd493fd601c1
Date: Thu Oct 10 14:15:10 2024
ap...@google.com <ap...@google.com> #325
Project: chromium/src
Branch: refs/branch-heads/6769
Author: Jérôme Lebel <
Link:
Add back allow_unsafe_buffers in stack_trace_posix.cc
Expand for full commit details
Add back allow_unsafe_buffers in stack_trace_posix.cc
In crrev.com/c/5902358 `allow_unsafe_buffers` was removed from
`base/debug/stack_trace_posix.cc`.
This is generate an error to build Canary for iOS:
https://ci.chromium.org/ui/p/chrome/builders/official/ios-dcheck/1411/overview
With in line 269:
const char* basename = last_sep ? last_sep + 1 : dl_info.dli_fname
This patch adds back `allow_unsafe_buffers`. The original patch cannot
be reverted without conflicts.
(cherry picked from commit 3a702f76b1ec619f5ff6aad9aededd493fd601c1)
Bug: 40284755
Fixed: 372584479
Change-Id: I862e0a3e360810964c7976895c4b20e9b00b6f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5922814
Reviewed-by: danakj <danakj@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1366811}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5922809
Commit-Queue: Harry Souders <harrysouders@google.com>
Owners-Override: Harry Souders <harrysouders@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6769@{#3}
Cr-Branched-From: f9e443b8ef9a292052773fde35516581924f9177-refs/heads/main@{#1366779}
Files:
- M
base/debug/stack_trace_posix.cc
Hash: b92c99cd0ce63aa0fcbae19627bcce894e089e82
Date: Thu Oct 10 15:52:42 2024
ap...@google.com <ap...@google.com> #326
Project: chromium/src
Branch: main
Author: danakj <
Link:
Remove unsafe pointer arithmetic in iOS official build
Expand for full commit details
Remove unsafe pointer arithmetic in iOS official build
The stack trace code has a path that is only used in iOS official which
was doing strrchr and then pointer arithmetic. Replace that with a
cstring_view that safely do the same operations.
Add a `cstring_view` ctor from a `char*` so that callers don't need to
call `strlen()` on their pointer. They already need to know the pointer
is NUL-terminated to run strlen() so forcing extra stuff on them isn't
helping anybody. The ctor is UNSAFE_BUFFER_USAGE still, as you need to
actually verify the pointer would always be NUL-terminated. This comes
from most C apis though, as they don't come with a paired size.
Bug: 40284755, 372584479
Change-Id: Icacedea2ab6939f821e75a77136528cf9ae38480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5923755
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1367496}
Files:
- M
base/debug/stack_trace_posix.cc
- M
base/strings/cstring_view.h
- M
base/strings/cstring_view_nocompile.nc
- M
base/strings/cstring_view_unittest.cc
Hash: cd2391a3ccc1da3251780d95a25e3bf42dbb943e
Date: Fri Oct 11 13:56:17 2024
ap...@google.com <ap...@google.com> #327
Project: chromium/src
Branch: main
Author: Kelsen Liu <
Link:
Spanify HttpChunkedDecoder
Expand for full commit details
Spanify HttpChunkedDecoder
This CL spanifies three methods in `HttpChunkedDecoder`, replaces
unchecked pointers with `base::span<uint8_t>`, and enables
unsafe-buffer-usage warnings.
Bug: 40284755,354307327
Change-Id: I1f633359fcf6b2a072b6a77c4210d6d715472088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953204
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: kelsen liu <kelsenliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373723}
Files:
- M
net/http/http_chunked_decoder.cc
- M
net/http/http_chunked_decoder.h
- M
net/http/http_chunked_decoder_fuzzer.cc
- M
net/http/http_chunked_decoder_unittest.cc
- M
net/http/http_stream_parser.cc
- M
net/test/embedded_test_server/http_request.cc
Hash: 9228eeff63e8d3cfe4efba1d5da071d695986471
Date: Fri Oct 25 04:14:18 2024
ap...@google.com <ap...@google.com> #328
Project: chromium/src
Branch: main
Author: danakj <
Link:
Provide aligned allocation methods that return HeapArray
Expand for full commit details
Provide aligned allocation methods that return HeapArray
There are two methods. The basic one returns a HeapArray<T> that
is allocated with a runtime alignment. The complex one returns a
HeapArray<char> that is allocated with a runtime alignment, along
with a span<T> for accessing the buffer as T*. This is used for
code that wants to control the lifetime of objects in the buffer
with in-place construction.
An AlignedHeapArray<T> alias is provided to avoid having to write
out the aligned deleter in the type name.
R=tsepez@chromium.org
Bug: 40284755
Change-Id: Ibe03c817732bc04976a1ce15868d61a2751275c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994775
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379225}
Files:
- M
base/memory/aligned_memory.h
- M
base/memory/aligned_memory_unittest.cc
- M
docs/unsafe_buffers.md
Hash: b4705079f2ccb991e1785d58b61c4d5b05f70f53
Date: Wed Nov 06 20:54:09 2024
ap...@google.com <ap...@google.com> #329
Project: chromium/src
Branch: main
Author: danakj <
Link:
Spanify the LazilyDeallocatedDeque::Ring
Expand for full commit details
Spanify the LazilyDeallocatedDeque::Ring
Use HeapArray and the new aligned allocation methods to avoid unsafe
allocations or span construction. Convert DCHECKs that protect against
memory safety bugs into CHECKs. Avoid UB by constructing references
to uninitialized memory in order to do in-place construction.
R=tsepez@chromium.org
Bug: 40284755
Change-Id: I3b59067173f70f66eae0a80ebaac81372165055d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000133
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379234}
Files:
- M
base/task/sequence_manager/lazily_deallocated_deque.h
- M
base/task/sequence_manager/lazily_deallocated_deque_unittest.cc
Hash: ed88d0b66cf32b7019fe112078de05febd59a9aa
Date: Wed Nov 06 21:07:18 2024
ap...@google.com <ap...@google.com> #330
Project: chromium/src
Branch: main
Author: danakj <
Link:
Add span::get_at(idx) -> T*, remove UNSAFE_BUFFERS at construct_at()s
Expand for full commit details
Add span::get_at(idx) -> T*, remove UNSAFE_BUFFERS at construct_at()s
In-place construction into a span means the element at the given
index is uninitialized, so it's not valid to construct a reference to
it. Old code often would do `construct_at(&span[index])` which does
make a reference and then take the address, and this is UB.
We converted some of these into doing constuct_at(span.data() + index)
instead to only work with a pointer, but this is unsafe pointer
arithmetic and thus needs complicated SAFETY comments.
Instead, provide span::get_at(size_t) which acts like operator[] but
does not make a reference to the element. It returns a pointer but
still requires the index to be _in bounds_, so it will not return the
pointer at end(). Thus, it is a safe way to get a pointer from the
span with which to call construct_at(). Change some construct_at()
calls to use get_at() instead and remove the UNSAFE_BUFFERS() there.
Also forward the get_at() through VectorBuffer.
The accessor is called get_at() in homage to unique_ptr::get() which
returns a pointer to its single object, but with an index to get a
a pointer to a specific single object in the span.
R=tsepez@chromium.org
Bug: 40284755
Change-Id: I9b24a79358076095a1a9c71ee9db6f9e9bfb4c68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5995751
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1379260}
Files:
- M
base/containers/circular_deque.h
- M
base/containers/span.h
- M
base/containers/span_unittest.cc
- M
base/containers/vector_buffer.h
- M
base/task/sequence_manager/lazily_deallocated_deque.h
Hash: 26ede22a2d1326c61a9c051a17c3d2b2fd3da94a
Date: Wed Nov 06 21:36:34 2024
ap...@google.com <ap...@google.com> #331
Project: chromium/src
Branch: main
Author: Kelsen Liu <
Link:
Spanify WebSocketFrame to avoid unsafe buffer usage
Expand for full commit details
Spanify WebSocketFrame to avoid unsafe buffer usage
This CL refactors the `WebSocketFrame` struct to use `base::raw_span`
for `payload`, and enables unsafe-buffer-usage warnings in
`websocket_basic_stream`.
Bug: 40284755, 354307327
Change-Id: Ia367e4f6a0c9c1f44f250946801ea355574a80c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5968473
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: kelsen liu <kelsenliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1381624}
Files:
- M
net/test/embedded_test_server/websocket_connection.cc
- M
net/websockets/websocket_basic_stream.cc
- M
net/websockets/websocket_basic_stream.h
- M
net/websockets/websocket_basic_stream_test.cc
- M
net/websockets/websocket_channel.cc
- M
net/websockets/websocket_channel_test.cc
- M
net/websockets/websocket_chunk_assembler.cc
- M
net/websockets/websocket_deflate_stream.cc
- M
net/websockets/websocket_deflate_stream_fuzzer.cc
- M
net/websockets/websocket_deflate_stream_test.cc
- M
net/websockets/websocket_frame.h
- M
net/websockets/websocket_stream_test.cc
Hash: 590687cf208780f116a67d82ac26832d5ffaddc8
Date: Tue Nov 12 07:48:29 2024
ap...@google.com <ap...@google.com> #332
Project: chromium/src
Branch: main
Author: Maks Orlovich <
Link:
Spanify CacheTestFillBuffer
Expand for full commit details
Spanify CacheTestFillBuffer
...which removes unsafe_buffers from disk_cache_test_util, and generally
looks nicer since it makes it obvious when the fill is not to the full
buffer, but rather is doing something unusual.
Fixing {backend,entry}_unittest.cc to not have unsafe_buffers will be a
bunch more work (and, arguably, the entire disk_cache API doesn't really
fit spans).
Bug: 40284755
Change-Id: I1f41f63c28499ee5e55c1476d367a7abe187f087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6032183
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1385650}
Files:
- M
net/disk_cache/backend_unittest.cc
- M
net/disk_cache/blockfile/mapped_file_unittest.cc
- M
net/disk_cache/disk_cache_fuzzer.cc
- M
net/disk_cache/disk_cache_perftest.cc
- M
net/disk_cache/disk_cache_test_util.cc
- M
net/disk_cache/disk_cache_test_util.h
- M
net/disk_cache/entry_unittest.cc
- M
net/tools/stress_cache/stress_cache.cc
Hash: b1647d265f771c011696d1be02237c584be6fc21
Date: Wed Nov 20 14:56:35 2024
ap...@google.com <ap...@google.com> #333
Project: chromium/src
Branch: main
Author: Peter Kasting <
Link:
Formally ban std::span.
Expand for full commit details
Formally ban std::span.
This has been true in practice forever, but for a while it wasn't clear
if we would someday migrate to it (bug 40256238). At this point that's
not plausibly feasible due to the API additions in base::span (split_at,
copy_from, to_fixed_extent, etc.), so clarify the status.
Bug: 40284755
Change-Id: Icc3669dae5e309611bb916088f8229f9ffca5442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6050662
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388397}
Files:
- M
PRESUBMIT.py
- M
styleguide/c++/c++-features.md
Hash: e73b89d584a104a734c89b6835977737eafe9a62
Date: Tue Nov 26 19:35:52 2024
ap...@google.com <ap...@google.com> #334
Project: chromium/src
Branch: refs/branch-heads/6834
Author: Kelsen Liu <
Link:
[M132 Merge] Spanify WebSocketFrame to avoid unsafe buffer usage
Expand for full commit details
[M132 Merge] Spanify WebSocketFrame to avoid unsafe buffer usage
This CL refactors the `WebSocketFrame` struct to use `base::raw_span`
for `payload`, and enables unsafe-buffer-usage warnings in
`websocket_basic_stream`.
(cherry picked from commit 590687cf208780f116a67d82ac26832d5ffaddc8)
Bug: 40284755, 354307327, 379672544
Change-Id: Ia367e4f6a0c9c1f44f250946801ea355574a80c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5968473
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: kelsen liu <kelsenliu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1381624}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6055061
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/branch-heads/6834@{#1168}
Cr-Branched-From: 47a3549fac11ee8cb7be6606001ede605b302b9f-refs/heads/main@{#1381561}
Files:
- M
net/test/embedded_test_server/websocket_connection.cc
- M
net/websockets/websocket_basic_stream.cc
- M
net/websockets/websocket_basic_stream.h
- M
net/websockets/websocket_basic_stream_test.cc
- M
net/websockets/websocket_channel.cc
- M
net/websockets/websocket_channel_test.cc
- M
net/websockets/websocket_chunk_assembler.cc
- M
net/websockets/websocket_deflate_stream.cc
- M
net/websockets/websocket_deflate_stream_fuzzer.cc
- M
net/websockets/websocket_deflate_stream_test.cc
- M
net/websockets/websocket_frame.h
- M
net/websockets/websocket_stream_test.cc
Hash: 1234610fdb5db3b68e2277c3ffeddb91163fbe07
Date: Thu Nov 28 05:58:03 2024
ap...@google.com <ap...@google.com> #335
Project: chromium/src
Branch: main
Author: Elly <
Link:
media: migrate to new AES-CTR API for CENC
Expand for full commit details
media: migrate to new AES-CTR API for CENC
This change migrates the CENC decryptor from the crypto/encryptor API to
the crypto/aes_ctr API. Since the new API allows for decryption into a
buffer, this lets us avoid one buffer copy in the no-subsamples path.
Since I was already editing this code, I also spanified
CopySubsamples(), which makes it easier to check that the logic there is
correct. That change in turn allows turning on unsafe buffer warnings
for the CENC decryptor code.
Bug: 372283556
Change-Id: Ieacce52a62cc8ed3b594b4ac6a5743ed1ad954e0
Fixed: 40284755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6055944
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Sangbaek Park <sangbaekpark@chromium.org>
Auto-Submit: Elly FJ <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1392555}
Files:
- M
media/cdm/cenc_decryptor.cc
Hash: bc3843d4bb606808670823c767eead7f9d919cd6
Date: Thu Dec 05 21:56:17 2024
ap...@google.com <ap...@google.com> #336
Project: chromium/src
Branch: main
Author: Zhibo Wang <
Link:
Make H26xAnnexBBitstreamBuilder::data() return base::span
Expand for full commit details
Make H26xAnnexBBitstreamBuilder::data() return base::span
Bug: 40284755
Change-Id: I20208156ccb1290ff8b9bdf5a0e41a588d7b1fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6073676
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Commit-Queue: Zhibo Wang <zhibo1.wang@intel.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1406558}
Files:
- M
media/filters/h26x_annex_b_bitstream_builder.cc
- M
media/filters/h26x_annex_b_bitstream_builder.h
- M
media/filters/h26x_annex_b_bitstream_builder_unittest.cc
- M
media/gpu/h264_builder_unittest.cc
- M
media/gpu/vaapi/h264_vaapi_video_encoder_delegate.cc
Hash: bdaa078b87154367977867065aee9481fabce2de
Date: Wed Jan 15 00:12:36 2025
ap...@google.com <ap...@google.com> #337
Project: chromium/src
Branch: main
Author: Tom Sepez <
Link:
Remove android_webview from unsafe_buffers_paths.txt
Expand for full commit details
Remove android_webview from unsafe_buffers_paths.txt
Instead, add a #pragma to the affected files.
Bug: 40284755
Change-Id: Ia258afb6beb18a256c4eaa308ceb025e3c3b224a
Cq-Include-Trybots: luci.chromium.try:android-webview-10-x86-rel-tests,android-webview-13-x64-dbg,android-webview-13-x64-hostside-rel,android-webview-13-x64-wpt-android-specific,android-webview-oreo-arm64-dbg,android-webview-pie-arm64-dbg,android-webview-pie-x86-wpt-fyi-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6204008
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1412488}
Files:
- M
android_webview/browser/aw_feature_entries_unittest.cc
- M
android_webview/browser/cookie_manager.cc
- M
android_webview/browser/gfx/aw_draw_fn_impl.cc
- M
android_webview/browser/gfx/aw_gl_functor.cc
- M
android_webview/browser/gfx/aw_vulkan_context_provider.cc
- M
android_webview/browser/gfx/browser_view_renderer_unittest.cc
- M
android_webview/browser/lifecycle/aw_contents_lifecycle_notifier.cc
- M
android_webview/browser/lifecycle/aw_contents_lifecycle_notifier_unittest.cc
- M
android_webview/browser/metrics/visibility_metrics_logger.cc
- M
android_webview/browser/tracing/aw_trace_event_args_allowlist.cc
- M
android_webview/js_sandbox/service/js_sandbox_isolate.cc
- M
android_webview/test/shell/src/draw_fn/context_manager.cc
- M
build/config/unsafe_buffers_paths.txt
Hash: 8d493cc4a7000cbf61a2b38ccc9c8be142db6c41
Date: Tue Jan 28 12:19:38 2025
ap...@google.com <ap...@google.com> #338
Project: chromium/src
Branch: main
Author: Matt Menke <
Link:
Address some allow_unsafe_buffers issues in net/dns.
Expand for full commit details
Address some allow_unsafe_buffers issues in net/dns.
This CL only addresses a small number of self-contained issues. This
directory in general has a lot of cases that are based around platform
APIs (sockaddrs, res_init()), and reading buffers from the network,
which this CL does not touch.
Bug: 40284755
Change-Id: I64a95f86cab8d1ca63bfb25653ea2612754d3687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237135
Commit-Queue: mmenke <mmenke@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417039}
Files:
- M
net/dns/dns_hosts.cc
- M
net/dns/dns_hosts_unittest.cc
- M
net/dns/host_resolver_manager_job.h
- M
net/dns/stale_host_resolver_unittest.cc
Hash: ca6a3c3e501b041b214194c4e6fc0284360a3b0a
Date: Thu Feb 06 15:03:39 2025
ap...@google.com <ap...@google.com> #339
Project: chromium/src
Branch: main
Author: Matt Menke <
Link:
Remove unsafe buffers pragmas from some files in net/base.
Expand for full commit details
Remove unsafe buffers pragmas from some files in net/base.
Of these files, only priority_queue_unittest.cc still needed its
pragma, and it was a one-line fix.
Bug: 390223051, 40284755
Change-Id: Id5e7783efba7306307c91148d304c9f7ddda07f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237321
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417046}
Files:
- M
net/base/datagram_buffer.cc
- M
net/base/datagram_buffer_unittest.cc
- M
net/base/filename_util.cc
- M
net/base/host_mapping_rules_unittest.cc
- M
net/base/ip_endpoint_unittest.cc
- M
net/base/lookup_string_in_fixed_set_unittest.cc
- M
net/base/priority_queue_unittest.cc
Hash: 0c93886ce747c5382c17ce8f8375aaa9b0feed7a
Date: Thu Feb 06 15:15:44 2025
ap...@google.com <ap...@google.com> #340
Project: chromium/src
Branch: main
Author: Matt Menke <
Link:
Remove allow_unsafe_buffers
from websocket_channel.cc.
Expand for full commit details
Remove `allow_unsafe_buffers` from websocket_channel.cc.
And clean up the code that required it. Also remove an unused
IOBuffer subclass.
Bug: 40284755
Change-Id: I847b2cff7b97ce5b29286331db79b46558417c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6244379
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1417797}
Files:
- M
net/websockets/websocket_channel.cc
Hash: 2aa70eb0522e07fa3a2a654f1f6d00dafbdfa45d
Date: Sat Feb 08 12:14:32 2025
ap...@google.com <ap...@google.com> #341
Project: chromium/src
Branch: main
Author: Matt Menke <
Link:
Fix unsafe buffer usage in http_network_transaction.cc.
Expand for full commit details
Fix unsafe buffer usage in http_network_transaction.cc.
Bug: 40284755
Change-Id: I862db6e0c7174c10d6407bf86eed17319b63f04d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6254679
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418973}
Files:
- M
net/http/http_network_transaction.cc
- M
net/http/http_network_transaction.h
Hash: 47b6b55954bdb4aec9a8e68cae2c038b551d110b
Date: Tue Feb 11 16:02:37 2025
ap...@google.com <ap...@google.com> #342
Project: chromium/src
Branch: main
Author: Matt Menke <
Link:
Spanify GzipHeader.
Expand for full commit details
Spanify GzipHeader.
Also make it take uint8_ts rather than chars, since it's dealing with
binary data.
Additionally, introduce a HasGZipHeader() helper, which is what all
but one of its consumers actually want, and migrate consumers to the
new helper.
Bug: 40284755
Change-Id: Icb36a225752e8c56eace06f6e1e4d46c95e45339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6253892
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421987}
Files:
- M
chromeos/printing/ppd_line_reader.cc
- M
content/public/test/browser_test_utils.cc
- M
net/filter/gzip_header.cc
- M
net/filter/gzip_header.h
- M
net/filter/gzip_source_stream.cc
- M
net/filter/gzip_source_stream_unittest.cc
- M
ui/base/resource/data_pack.cc
- M
ui/base/resource/resource_bundle.cc
Hash: f5aaa19a4889c12a521a65d6a787f1ec5fed7760
Date: Wed Feb 19 08:45:50 2025
ap...@google.com <ap...@google.com> #343
Project: chromium/src
Branch: main
Author: Matt Menke <
Link:
Spanify HttpConnection::ReadIOBuffer
Expand for full commit details
Spanify HttpConnection::ReadIOBuffer
ReadIOBuffer provided StartOfBuffer() and GetSize() methods, which effectively returned a span. This replaces them with a single
readable_bytes() method that returns a span. ReadIOBuffer wraps a
GrowableIOBuffer, and readable_bytes() is logically the same as
GrowableIOBuffers::span_before_offset(), so the new method calls
that. The new method is not called span_before_offset() because
focusing on what's readable is more consistent with other method
ReadIOBuffer documentation and method names.
Using a span adds safety checks not present on raw buffers, and this
simplifies the code a bit as well. Also, ReadableIOBuffers had
GetSize() and size() methods, which return sizes of different halves
of the managed buffer, so removing GetSize() will hopefully reduce
confusion.
Bug: 396621713, 40284755
Change-Id: I1d9c769f2c2e3e3892982d0c002e7fd1f092c08d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282326
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422880}
Files:
- M
content/browser/devtools/devtools_pipe_handler.cc
- M
net/server/http_connection.cc
- M
net/server/http_connection.h
- M
net/server/http_connection_unittest.cc
- M
net/server/http_server.cc
- M
net/server/web_socket.cc
Hash: e6c7e7c0fdac254ed32d38d09a5d741e7dd57860
Date: Thu Feb 20 17:15:24 2025
dx...@google.com <dx...@google.com> #344
Project: chromium/src
Branch: main
Author: Matt Menke
Link:
Spanify (string_view-ify?) HttpContentDisposition.
Expand for full commit details
Bug: 40284755
Change-Id: I5de008dc91fe6730fa7bf47d540c943f6c7b9cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6384435
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436864}
Files:
- M
net/http/http_content_disposition.cc
- M
net/http/http_content_disposition.h
- M
net/http/http_content_disposition_unittest.cc
Hash: 4f32f0719aebc8495e2020c4b0f9d9e68aa5bce0
Date: Mon Mar 24 15:29:35 2025
dx...@google.com <dx...@google.com> #345
Project: chromium/src
Branch: main
Author: Matt Menke
Link:
Spanify HttpCacheTransaction.
Expand for full commit details
Migrate HttpCacheTransaction values from using pointers and C-style
arrays to using std::arrays, std::optionals, std::string_views, and
base::spans.
Bug: 40284755
Change-Id: I6cda696c4f14e8a0b5d85758ecd43cca2771f625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6381843
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436952}
Files:
- M
net/http/http_cache_transaction.cc
- M
net/http/http_cache_transaction.h
Hash: 7e03f81e2f59ed5e00db9db4e9ea07ac0f1520e7
Date: Mon Mar 24 17:42:32 2025
dx...@google.com <dx...@google.com> #346
Project: chromium/src
Branch: main
Author: Matt Menke
Link:
Spanify spdy_session.cc and http2_priority_dependencies.cc.
Expand for full commit details
This does add two UNSAFE_TODO() calls around calls to quiche APIs.
It's unclear whether or not those will be migrated to to use safer
options (albeit not ones that use base::span()).
Bug: 40284755
Change-Id: If0cc180f16abb21299c94a14ace622c8266a4f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6387022
Commit-Queue: mmenke <mmenke@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437929}
Files:
- M
net/spdy/http2_priority_dependencies.cc
- M
net/spdy/http2_priority_dependencies.h
- M
net/spdy/spdy_session.cc
- M
net/spdy/spdy_session.h
Hash: 251372c3b63ef2a0e1d94e244f2df83b86cd496d
Date: Wed Mar 26 04:18:43 2025
dx...@google.com <dx...@google.com> #347
Project: chromium/src
Branch: main
Author: Matt Menke
Link:
Remove allow_unsafe_buffers from HTTP auth code.
Expand for full commit details
This does unfortunately add an UNSAFE_BUFFERS() call to
http_auth_sspi_win, as it calls a Windows API that expects an input
data buffer of variable size to immediately follow a
SEC_CHANNEL_BINDINGS object.
Bug: 40284755
Change-Id: I4e0ef78dfeaa9d3ac8c180bfbd1a20619b4aab9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6386746
Commit-Queue: mmenke <mmenke@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1438415}
Files:
- M
net/http/http_auth_gssapi_posix.cc
- M
net/http/http_auth_handler_digest.cc
- M
net/http/http_auth_sspi_win.cc
Hash: ee8af1f4e4d4b5feac2bc35d329fa806fcd7f662
Date: Wed Mar 26 21:45:16 2025
Description
Plan for progress here:
- Rewrite base APIs and their users and base implementations to use span.
- At some point start to verify that some parts of //base can be built with -Wunsafe-buffer-usage
- To do that we can pull some .cc files out of base into a source_set and apply the warning to them.
- This will show how to prevent backsliding, and we can do this until all of //base cc files pass, and apply the warning to base but not to things that depend on it yet (in GN configs but not all_dependent_configs)