IssueTracker

Bug Report: AutofillService onSaveRequest Never Being Called

Device & Android Version:

• Device Model: Nething Phone 2, Pixel 8 (emulation)
• Android Version: Android 15

Issue Summary: The onSaveRequest method of AutofillService is never called when implementing an autofill service for an external apps. Autofill suggestions appear correctly, and selecting a suggestion fills the field, but mentioned function is never triggered when submitting the form.

Steps to Reproduce:

1. Implement an AutofillService subclass.
2. Override onFillRequest to provide autofill suggestions.
3. Override onSaveRequest to handle data saving.
4. Install and set the custom Autofill service as the default Autofill provider in Android settings.
5. Open an external app with an email input field.
6. Tap the email field and select an autofill suggestion.
7. Submit the form (e.g., clicking a login button).
8. Observe that onSaveRequest is never called.

Expected Behavior:

• The onSaveRequest method should be triggered after the user submits the form where an autofill field was used.

Actual Behavior:

• The onSaveRequest method is never called, preventing data from being saved.
• Adding explicit SaveInfo in FillResponse does not resolve the issue
• The issue occurs in multiple external apps, tested with TikTok and Facebook

Code

  
import android.app.assist.AssistStructure
import android.os.CancellationSignal
import android.service.autofill.AutofillService
import android.service.autofill.Dataset
import android.service.autofill.FillCallback
import android.service.autofill.FillRequest
import android.service.autofill.FillResponse
import android.service.autofill.SaveCallback
import android.service.autofill.SaveInfo
import android.service.autofill.SaveRequest
import android.text.InputType
import android.view.View
import android.view.autofill.AutofillId
import android.view.autofill.AutofillValue
import android.widget.RemoteViews
import com.quikmail.R.id.hint_text
import com.quikmail.R.layout.hint_autofill
import com.quikmail.util.Logger

class TestAutofillService : AutofillService() {

    override fun onFillRequest(
        request: FillRequest,
        cancellationSignal: CancellationSignal,
        callback: FillCallback
    ) {
        Logger.i("Fill request received")
        // Check if the request is coming from your own app
        val structure = request.fillContexts.last().structure
        if (structure.activityComponent.packageName == packageName) {
            callback.onFailure("Autofill not supported for this app")
            return
        }

        val emailField = findFocusedEmailField(structure)
        emailField?.autofillId?.let {
            val emailAddressExisting = "abcde@test.pro"
            val emailAddressNewGenerated = "abcdef1234@test.pro"
            val response =
                showHintForField(it, emailAddressExisting, emailAddressNewGenerated)
            callback.onSuccess(response)
        } ?: callback.onFailure("No email field found")
    }

    private fun findFocusedEmailField(structure: AssistStructure): AssistStructure.ViewNode? {
        for (i in 0 until structure.windowNodeCount) {
            val window = structure.getWindowNodeAt(i)
            val rootNode = window.rootViewNode
            rootNode?.let {
                return traverseStructure(it)
            }
        }
        return null
    }

    private fun traverseStructure(node: AssistStructure.ViewNode): AssistStructure.ViewNode? {
        if (node.isFocused && isEmailField(node)) {
            return node
        }

        for (i in 0 until node.childCount) {
            val child = node.getChildAt(i)
            child?.let {
                val result = traverseStructure(it)
                if (result != null) return result
            }
        }
        return null
    }

    private fun isEmailField(node: AssistStructure.ViewNode): Boolean {
        return when {
            // Check for standard email hints
            node.autofillHints?.any {
                it.equals(
                    View.AUTOFILL_HINT_EMAIL_ADDRESS,
                    true
                )
            } == true -> true

            // Check for email input type
            (node.inputType and InputType.TYPE_TEXT_VARIATION_EMAIL_ADDRESS) != 0 -> true

            // Check for common email field IDs
            node.idEntry?.lowercase()?.let { id ->
                id.contains("email") || id.contains("e_mail") || id.contains("username")
            } == true -> true

            // Check for HTML email fields in WebViews
            node.htmlInfo?.attributes?.any { attr ->
                attr.first.equals("type", true) && attr.second.equals("email", true)
            } == true -> true

            else -> false
        }
    }

    private fun showHintForField(
        fieldId: AutofillId,
        emailAddressExisting: String,
        emailAddressNewGenerated: String?
    ): FillResponse {
        val datasetExisting = createDataSet(fieldId, emailAddressExisting)
        val datasetNewGenerated = emailAddressNewGenerated
            ?.let { createDataSet(fieldId, emailAddressNewGenerated) }

        val info = SaveInfo.Builder(SaveInfo.SAVE_DATA_TYPE_EMAIL_ADDRESS, arrayOf(fieldId))
            .setTriggerId(fieldId)
            .build()

        return FillResponse.Builder()
            .addDataset(datasetExisting)
            .addDataset(datasetNewGenerated)
            .setSaveInfo(info)
            .build()
    }

    private fun createDataSet(
        fieldId: AutofillId,
        emailAddress: String
    ): Dataset {
        val hintView = RemoteViews(packageName, hint_autofill).apply {
            setTextViewText(hint_text, emailAddress)
        }

        return Dataset.Builder(hintView)
            .setValue(fieldId, AutofillValue.forText(emailAddress))
            .build()
    }

    override fun onSaveRequest(request: SaveRequest, callback: SaveCallback) {
        Logger.i("onSaveRequest")
        callback.onSuccess()
    }
}

Security-Related Issue: No