The issue here is that the 'partial fix' for https://github.com/google/dagger/issues/4423 does not fully address the defect in the plugin where it checks all configurations trying to validate that the Hilt compiler and runtime are part of the deps during configuration phase. Hilt needs to change validation strategy here and specifically move the validation to a task, where it is safer to resolve and inspect dependencies.

Minimized repro:

1. Upgrade to hilt 2.66
2. PROJECT_PREFIX=:hilt:hilt-navigation ALLOW_PUBLIC_REPOS=true ./gradlew bOS --dry-run -Pandroidx.constraints=false

It still loads 122 projects, so i'll look a bit further to reduce it

Reduced it further.

1. Apply https://r.android.com/3560439
2. PROJECT_PREFIX=:hilt:hilt-navigation-compose ALLOW_PUBLIC_REPOS=true ./gradlew bOS --dry-run -Pandroidx.constraints=false

it is down to loading only 34 projects.

Narrowed it down even further, it seems that the thing that breaks us is the upgrade of com.google.dagger:hilt-android:2.55 -> com.google.dagger:hilt-android:2.56.

Something about the dependencies is causing our build to be unhappy.

It seems that 2.56 added <type>aar</type> that didnt exist before

https://diff.googleplex.com/#key=apWKceuwCgKh

It seems to be either https://github.com/gradle/gradle/issues/5174 or https://github.com/gradle/gradle/issues/7594

I added a workaround, but it quite ugly and i'm not sure we want to land it as-is https://r.android.com/3552204

Just so I understand, is this something that should be fixed in Dagger, or is this just a bug in Gradle?

To add some context from our side, I think those artifact type identifiers were added when upgrading Dagger to Bazel 7.5 (CL/722877920), for example I had to add :aar here:

https://critique.corp.google.com/cl/722877920/depot/google3/third_party/java_src/dagger/project/java/dagger/hilt/android/BUILD

Note that I didn't upgrade any of those artifacts in that CL, so my best guess is that the extra :aar identifiers is coming from the implementation of maven.install usages which was upgraded via the rules_jvm_external library.

See this link instead:

https://github.com/google/dagger/commit/e39cbf645a470e8870e31787ffd03f23413d7939#diff-ae9238a064a97d31ea60bb0f245b05c1414c7a5b725a12a71555a92f0564ccaa

I think your artifacts are correct, but due to the Gradle bug in androidx context where we get dependencies that are androidx dependencies and we try to swap it with a project, it fails.

I'm trying to figure out a clean way to work around it.

ok, i think I have a cleaner workaround. r.android.com/3562739

Thanks for the investigation Aurimas. It seems like the plugin's dependency check is not the root cause even though it could still be improved, something I think we should still do.

FWIW we are working on building Dagger / Hilt with Gradle which will allow us to publish Gradle metadata that could have maybe prevented this issue (just a theory).