Fixed
Status Update
No update yet.
Comments
xi...@chromium.org
I guess hidden should just be defined. Meaning, right now, hidden should just defined as "whether this fragment was hidden as part of a transaction". Hidden is not equivalent with visibility. I think that's where the confusion comes from.
xi...@chromium.org
We have passed this to the development team and will update this issue with more information as it becomes available.
xi...@chromium.org
Yeah, I'm seeing this issue as well, currently this is the workaround that I've come up with:
// This method is called when hide()/show() methods are called on the transaction. Unfortunately Android doesn't
// propagate it to the child fragments (even though their visibility is affected by the parent visibility), so we
// do it manually.
override fun onHiddenChanged(hidden: Boolean) {
super.onHiddenChanged(hidden)
childFragmentManager.fragments.forEach { it.onHiddenChanged(hidden) }
}
// This method is called when hide()/show() methods are called on the transaction. Unfortunately Android doesn't
// propagate it to the child fragments (even though their visibility is affected by the parent visibility), so we
// do it manually.
override fun onHiddenChanged(hidden: Boolean) {
super.onHiddenChanged(hidden)
childFragmentManager.fragments.forEach { it.onHiddenChanged(hidden) }
}
bu...@chromium.org
@4 That actually won't technically fix as isHidden() will technically mismatch with the state passed into the child fragment. Each child fragment legitimately needs to have their state set to hidden.
da...@chromium.org
Yeah, I realized that as I kept working further on it. Nevermind that solution, it doesn't work.
xi...@chromium.org
@6 I don't know what the ramifications are, but when you iterate, you can save the "currentState" and then hide them all via a transaction. When restoring to visible, restore to the original state.
bu...@chromium.org
Project: platform/frameworks/support
Branch: androidx-main
commit 02290cddca3d5e4dc94e2c5f77a6728ad970b204
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Oct 07 13:11:45 2021
Dispatch onHiddenChanged to child fragments
When a parent fragment is hidden all of its children will automatically
be hidden, but we never call onHiddenChanged on any of the children.
We should dispatch onHiddenChanged down parent's entire hierarchy and
ensure that `isHidden()` also considers the parent's state.
RelNote: "Parent fragments will now dispatch `onHiddenChanged()` down
their entire hierarchy before launching their own call back."
Test: added test
Bug: 77504618
Change-Id: Iedc201ab435cb963e81bc02d203d4d37ff827e01
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
https://android-review.googlesource.com/1850016
Branch: androidx-main
commit 02290cddca3d5e4dc94e2c5f77a6728ad970b204
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Oct 07 13:11:45 2021
Dispatch onHiddenChanged to child fragments
When a parent fragment is hidden all of its children will automatically
be hidden, but we never call onHiddenChanged on any of the children.
We should dispatch onHiddenChanged down parent's entire hierarchy and
ensure that `isHidden()` also considers the parent's state.
RelNote: "Parent fragments will now dispatch `onHiddenChanged()` down
their entire hierarchy before launching their own call back."
Test: added test
Bug: 77504618
Change-Id: Iedc201ab435cb963e81bc02d203d4d37ff827e01
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
bu...@chromium.org
This has been fixed internally and will be available in the Fragment 1.4.0-beta01 release.
xi...@chromium.org
[Empty comment from Monorail migration]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/302e0653717ecec2fa09985e055aa6f8b08a847e
commit 302e0653717ecec2fa09985e055aa6f8b08a847e
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Apr 27 18:23:08 2018
Download: Implement media parser to get media metadata.
This CL hooks android download code to media gallery util service, which
provides the functionality to safely parse media metadata in an utility
process. Also includes necessary change to build media gallery util
service on Android.
Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie76992ed65b746b784374b5acefcdebe4e26fe50
Reviewed-on:https://chromium-review.googlesource.com/1028614
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554427}
[modify]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/app/BUILD.gn
[modify]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/app/generated_resources.grd
[modify]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/BUILD.gn
[add]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/android/download/download_media_parser.cc
[add]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/android/download/download_media_parser.h
[add]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/android/download/local_media_data_source_factory.cc
[add]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/android/download/local_media_data_source_factory.h
[modify]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/browser/chrome_content_browser_client.cc
[modify]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/utility/BUILD.gn
[modify]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/chrome/utility/chrome_content_utility_client.cc
[modify]https://crrev.com/302e0653717ecec2fa09985e055aa6f8b08a847e/media/filters/BUILD.gn
commit 302e0653717ecec2fa09985e055aa6f8b08a847e
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Apr 27 18:23:08 2018
Download: Implement media parser to get media metadata.
This CL hooks android download code to media gallery util service, which
provides the functionality to safely parse media metadata in an utility
process. Also includes necessary change to build media gallery util
service on Android.
Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie76992ed65b746b784374b5acefcdebe4e26fe50
Reviewed-on:
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554427}
[modify]
[modify]
[modify]
[add]
[add]
[add]
[add]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87
commit 38cfb4d63291bd1f58e3c80484cb8370dd3e4f87
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Jul 16 18:40:37 2018
Download Media: Adds a JNI bridge for download media parser.
This CL adds a JNI bridge for DownloadMediaParser. Since Android
currently doesn't support browser test, a high level java test needs
this bridge. Also the UI code may call through this routine.
Bug: 826021
Change-Id: I58dfb770fc03bcc567b55a98eb0a8c51d0f02052
Reviewed-on:https://chromium-review.googlesource.com/1136523
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575362}
[add]https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify]https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/android/java_sources.gni
[modify]https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/browser/BUILD.gn
[add]https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/browser/android/download/download_media_parser_bridge.cc
[add]https://crrev.com/38cfb4d63291bd1f58e3c80484cb8370dd3e4f87/chrome/browser/android/download/download_media_parser_bridge.h
commit 38cfb4d63291bd1f58e3c80484cb8370dd3e4f87
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Jul 16 18:40:37 2018
Download Media: Adds a JNI bridge for download media parser.
This CL adds a JNI bridge for DownloadMediaParser. Since Android
currently doesn't support browser test, a high level java test needs
this bridge. Also the UI code may call through this routine.
Bug: 826021
Change-Id: I58dfb770fc03bcc567b55a98eb0a8c51d0f02052
Reviewed-on:
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575362}
[add]
[modify]
[modify]
[add]
[add]
xi...@chromium.org
Video thumbnail out of process prototype is basically working.
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/f0a0fb97befa1021400e97910c637712d8f07789
commit f0a0fb97befa1021400e97910c637712d8f07789
Author: Xing Liu <xingliu@chromium.org>
Date: Wed Sep 05 18:33:50 2018
Video thumbnail: Extract video frame on Android.
This CL implements the functionality to extract one encoded video key
frame in utility process with ffmpeg for video thumbnail retrieval.
The decoding will be done in later CLs with MojoVideoDecoder.
TBR=dtrainor@chromium.org
Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia36ffe5ab4bb6fc32e55f1de089f07046e72a1bd
Reviewed-on:https://chromium-review.googlesource.com/1145780
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588946}
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/android/BUILD.gn
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/android/java_sources.gni
[add]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/download_media_parser.cc
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/download_media_parser.h
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/download_media_parser_bridge.cc
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/download_media_parser_bridge.h
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/browser/android/download/local_media_data_source_factory.h
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/BUILD.gn
[add]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/media_parser_android.cc
[add]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/media_parser_android.h
[add]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/media_parser_android_unittest.cc
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/media_parser_factory.cc
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/public/mojom/BUILD.gn
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/services/media_gallery_util/public/mojom/media_parser.mojom
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/chrome/test/BUILD.gn
[modify]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/media/filters/BUILD.gn
[add]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/media/filters/android/video_frame_extractor.cc
[add]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/media/filters/android/video_frame_extractor.h
[add]https://crrev.com/f0a0fb97befa1021400e97910c637712d8f07789/media/filters/android/video_frame_extractor_unittest.cc
commit f0a0fb97befa1021400e97910c637712d8f07789
Author: Xing Liu <xingliu@chromium.org>
Date: Wed Sep 05 18:33:50 2018
Video thumbnail: Extract video frame on Android.
This CL implements the functionality to extract one encoded video key
frame in utility process with ffmpeg for video thumbnail retrieval.
The decoding will be done in later CLs with MojoVideoDecoder.
TBR=dtrainor@chromium.org
Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia36ffe5ab4bb6fc32e55f1de089f07046e72a1bd
Reviewed-on:
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588946}
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/e57733325074452402b2f56fc392c8c16201fae6
commit e57733325074452402b2f56fc392c8c16201fae6
Author: Xing Liu <xingliu@chromium.org>
Date: Tue Sep 11 19:08:00 2018
Video Thumbnail: Decode the video frame on Android.
This CL does the following things:
1. Implements a GpuVideoAcceleratorFactories for browser process in
content/ to create MojoVideoDecoder in the browser process.
2. Decodes video frame with MojoVideoDecoder in browser process in
DownloadMediaParser. The actual decoding happens in GPU process with
Android MediaCodec, which is same as other usages for MediaCodec based
decoders.
Test is covered in DownloadMediaParserTest.
TBR=dtrainor@chromium.org
Bug: 826021
Change-Id: I242ff31ba8f205af3b03709fb78bd14f5bc33e45
Reviewed-on:https://chromium-review.googlesource.com/1212343
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590431}
[modify]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/chrome/browser/BUILD.gn
[modify]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/chrome/browser/android/DEPS
[modify]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/chrome/browser/android/download/download_media_parser.cc
[modify]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/chrome/browser/android/download/download_media_parser.h
[modify]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/browser/BUILD.gn
[add]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/browser/media/android/browser_gpu_video_accelerator_factories.cc
[add]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/browser/media/android/browser_gpu_video_accelerator_factories.h
[modify]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/public/browser/BUILD.gn
[add]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/content/public/browser/android/gpu_video_accelerator_factories_provider.h
[modify]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/media/mojo/clients/BUILD.gn
[modify]https://crrev.com/e57733325074452402b2f56fc392c8c16201fae6/media/video/gpu_video_accelerator_factories.h
commit e57733325074452402b2f56fc392c8c16201fae6
Author: Xing Liu <xingliu@chromium.org>
Date: Tue Sep 11 19:08:00 2018
Video Thumbnail: Decode the video frame on Android.
This CL does the following things:
1. Implements a GpuVideoAcceleratorFactories for browser process in
content/ to create MojoVideoDecoder in the browser process.
2. Decodes video frame with MojoVideoDecoder in browser process in
DownloadMediaParser. The actual decoding happens in GPU process with
Android MediaCodec, which is same as other usages for MediaCodec based
decoders.
Test is covered in DownloadMediaParserTest.
TBR=dtrainor@chromium.org
Bug: 826021
Change-Id: I242ff31ba8f205af3b03709fb78bd14f5bc33e45
Reviewed-on:
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590431}
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
[add]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/9f529e3a26deeb24f21508d77b9ebb7c96bc226f
commit 9f529e3a26deeb24f21508d77b9ebb7c96bc226f
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Sep 14 18:28:18 2018
Android Video Thumbnail: Render video frame to bitmap.
This CL finishes the video thumbnail pipeline for most codec except
vp8, vp9. Now it's ready to hook to the UI frontend. It does following:
1. Render the video frame with existing media toolkit, which can read
back pixel data from a texture in GPU process.
2. Plumbs a few metadata fields and thumbnail bitmap to Java layer.
Bug: 826021
Change-Id: Id6635975726f4b12ab51e01cb6b3e78a198632f4
Reviewed-on:https://chromium-review.googlesource.com/1222694
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591406}
[add]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaData.java
[modify]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/android/java_sources.gni
[modify]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/BUILD.gn
[modify]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/download_media_parser.cc
[modify]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/download_media_parser.h
[modify]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/download_media_parser_bridge.cc
[add]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/video_frame_thumbnail_converter.cc
[add]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/chrome/browser/android/download/video_frame_thumbnail_converter.h
[modify]https://crrev.com/9f529e3a26deeb24f21508d77b9ebb7c96bc226f/content/browser/media/android/browser_gpu_video_accelerator_factories.cc
commit 9f529e3a26deeb24f21508d77b9ebb7c96bc226f
Author: Xing Liu <xingliu@chromium.org>
Date: Fri Sep 14 18:28:18 2018
Android Video Thumbnail: Render video frame to bitmap.
This CL finishes the video thumbnail pipeline for most codec except
vp8, vp9. Now it's ready to hook to the UI frontend. It does following:
1. Render the video frame with existing media toolkit, which can read
back pixel data from a texture in GPU process.
2. Plumbs a few metadata fields and thumbnail bitmap to Java layer.
Bug: 826021
Change-Id: Id6635975726f4b12ab51e01cb6b3e78a198632f4
Reviewed-on:
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591406}
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/4679a2dc1ed0db5c5a98e019880d4030181ca6f3
commit 4679a2dc1ed0db5c5a98e019880d4030181ca6f3
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Oct 01 19:57:33 2018
Android video thumbnail: Generate thumbnails for vp8, vp9 videos.
This CL does the following:
1. Use VpxVideoDecoder in utility process to do software decoding for
vp8, vp9 video files.
2. Simplify the class to render media::VideoFrame into bitmap, since
PaintCanvasVideoRenderer works for all kind of VideoFrames.
3. Do not retrieve poster image from metadata. The mime type of the
poster image is inferred from mime sniffer, and needs to be
processed in sandbox process.
Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I91c9cf72a75be4bc3a95203a40633647e079a40a
Reviewed-on:https://chromium-review.googlesource.com/1234859
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595523}
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/android/BUILD.gn
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/browser/BUILD.gn
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/browser/android/download/download_media_parser.cc
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/browser/android/download/download_media_parser.h
[delete]https://crrev.com/888b9a2fcfd57b1d235d60c26fe204ebe8ebb533/chrome/browser/android/download/video_frame_thumbnail_converter.cc
[delete]https://crrev.com/888b9a2fcfd57b1d235d60c26fe204ebe8ebb533/chrome/browser/android/download/video_frame_thumbnail_converter.h
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/BUILD.gn
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/media_parser_android.cc
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/media_parser_android.h
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/media_parser_android_unittest.cc
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/chrome/services/media_gallery_util/public/mojom/media_parser.mojom
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/base/BUILD.gn
[add]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/base/video_thumbnail_decoder.cc
[add]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/base/video_thumbnail_decoder.h
[add]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/base/video_thumbnail_decoder_unittest.cc
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/filters/android/video_frame_extractor.cc
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/filters/android/video_frame_extractor.h
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/filters/android/video_frame_extractor_unittest.cc
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/mojo/common/mojo_shared_buffer_video_frame.cc
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/mojo/common/mojo_shared_buffer_video_frame.h
[modify]https://crrev.com/4679a2dc1ed0db5c5a98e019880d4030181ca6f3/media/mojo/common/mojo_shared_buffer_video_frame_unittest.cc
commit 4679a2dc1ed0db5c5a98e019880d4030181ca6f3
Author: Xing Liu <xingliu@chromium.org>
Date: Mon Oct 01 19:57:33 2018
Android video thumbnail: Generate thumbnails for vp8, vp9 videos.
This CL does the following:
1. Use VpxVideoDecoder in utility process to do software decoding for
vp8, vp9 video files.
2. Simplify the class to render media::VideoFrame into bitmap, since
PaintCanvasVideoRenderer works for all kind of VideoFrames.
3. Do not retrieve poster image from metadata. The mime type of the
poster image is inferred from mime sniffer, and needs to be
processed in sandbox process.
Bug: 826021
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I91c9cf72a75be4bc3a95203a40633647e079a40a
Reviewed-on:
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595523}
[modify]
[modify]
[modify]
[modify]
[modify]
[delete]
[delete]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/25a3837ec57a6dea8ba52776728542e00f0f0f74
commit 25a3837ec57a6dea8ba52776728542e00f0f0f74
Author: Xing Liu <xingliu@chromium.org>
Date: Tue Oct 02 02:50:51 2018
Android Video Thumbnail: Hook video thumbnail backend to UI.
This CL hooks the video thumbnail backend to the UI layer of new
download home.
Bug: 826021
Change-Id: I190ad09e8231d94d7546128bd1d22dc39f4d5f35
Reviewed-on:https://chromium-review.googlesource.com/1247529
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595706}
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/res_download/layout/download_manager_video_item.xml
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/download/home/glue/ThumbnailRequestGlue.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/UiUtils.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ImageFetcher.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailGenerator.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailProvider.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadMediaParserTest.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailProviderImplTest.java
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/BUILD.gn
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/download/download_media_parser.cc
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/download/download_media_parser.h
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/download/download_media_parser_bridge.cc
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/download/download_media_parser_bridge.h
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/widget/thumbnail_generator.cc
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/android/widget/thumbnail_generator.h
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/download/image_thumbnail_request.cc
[modify]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/download/image_thumbnail_request.h
[add]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/download/thumbnail_util.cc
[add]https://crrev.com/25a3837ec57a6dea8ba52776728542e00f0f0f74/chrome/browser/download/thumbnail_util.h
commit 25a3837ec57a6dea8ba52776728542e00f0f0f74
Author: Xing Liu <xingliu@chromium.org>
Date: Tue Oct 02 02:50:51 2018
Android Video Thumbnail: Hook video thumbnail backend to UI.
This CL hooks the video thumbnail backend to the UI layer of new
download home.
Bug: 826021
Change-Id: I190ad09e8231d94d7546128bd1d22dc39f4d5f35
Reviewed-on:
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595706}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[add]
bu...@chromium.org
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/23c98a65baed441b3418ef542d8e4d86bb18f485
commit 23c98a65baed441b3418ef542d8e4d86bb18f485
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Oct 11 18:51:35 2018
Download media: Adds metrics for download media parser.
This CL adds the metrics for download media parser, so we can
understand the overall reliability of the feature.
TBR=jwd@chormium.org
Bug: 826021
Change-Id: I2f556b3ab206c2a2cdbca9bd8d7d99979cd385a9
Reviewed-on:https://chromium-review.googlesource.com/c/1257859
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598871}
[modify]https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/chrome/browser/android/download/download_media_parser.cc
[modify]https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/chrome/browser/android/download/download_media_parser.h
[modify]https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/chrome/browser/download/download_stats.cc
[modify]https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/chrome/browser/download/download_stats.h
[modify]https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/tools/metrics/histograms/enums.xml
[modify]https://crrev.com/23c98a65baed441b3418ef542d8e4d86bb18f485/tools/metrics/histograms/histograms.xml
commit 23c98a65baed441b3418ef542d8e4d86bb18f485
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Oct 11 18:51:35 2018
Download media: Adds metrics for download media parser.
This CL adds the metrics for download media parser, so we can
understand the overall reliability of the feature.
TBR=jwd@chormium.org
Bug: 826021
Change-Id: I2f556b3ab206c2a2cdbca9bd8d7d99979cd385a9
Reviewed-on:
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598871}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
bu...@chops-service-accounts.iam.gserviceaccount.com
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/e45d35a3bb5c064d0d1e5ee9da4619497e2e1cce
commit e45d35a3bb5c064d0d1e5ee9da4619497e2e1cce
Author: Xing Liu <xingliu@chromium.org>
Date: Thu May 23 19:10:19 2019
Download media parser: Fix a typo.
This CL fixed a typo in DownloadMediaParserBridge.
Bug: 826021
Change-Id: Ied207ea958a0302e09e244466221e6f67b150771
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1625961
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662751}
[modify]https://crrev.com/e45d35a3bb5c064d0d1e5ee9da4619497e2e1cce/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadMediaParserBridge.java
[modify]https://crrev.com/e45d35a3bb5c064d0d1e5ee9da4619497e2e1cce/chrome/browser/android/download/download_media_parser_bridge.cc
[modify]https://crrev.com/e45d35a3bb5c064d0d1e5ee9da4619497e2e1cce/chrome/browser/android/download/download_media_parser_bridge.h
commit e45d35a3bb5c064d0d1e5ee9da4619497e2e1cce
Author: Xing Liu <xingliu@chromium.org>
Date: Thu May 23 19:10:19 2019
Download media parser: Fix a typo.
This CL fixed a typo in DownloadMediaParserBridge.
Bug: 826021
Change-Id: Ied207ea958a0302e09e244466221e6f67b150771
Reviewed-on:
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662751}
[modify]
[modify]
[modify]
is...@google.com
This issue was migrated from crbug.com/chromium/826021?no_tracker_redirect=1
[Multiple monorail components: Internals>Media, UI>Browser>Downloads]
[Monorail components added to Component Tags custom field.]
[Multiple monorail components: Internals>Media, UI>Browser>Downloads]
[Monorail components added to Component Tags custom field.]
Description
OS: Android
Implement code to parse media metadata and get the thumbnail from certain frame of the media file.
Currently we have media parse interface, a mojo service in media_gallery_util. It will call into ffmpeg lib in an utility process. We can try to use this API.