IssueTracker

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Hey Paul, can you give input on how important this is?

Doesn't this already exist? Or is this different from the manifest property?

waiting on additional feedback.

GitHub issue:
https://github.com/w3c/manifest/issues/737

Discussion doc (Google only):
https://docs.google.com/document/d/1wchuU6uZAt10LYYL4U0GmI4lndwdkoMdvXKLiZkJ5Aw/edit

#4:
> Doesn't this already exist? Or is this different from the manifest property?

There's been some confusion because this feature keeps being labeled as "display: browser", which does already exist and has a separate meaning (specifically, that the app is opened in a regular browser tab).

This feature is about having a standalone app window with multiple tabs (containing separate documents inside the app scope) inside it.

Regardless of how we design this, the name of the feature proposal should not be named after a proposed solution, since that unnecessarily pigeonholes us into a particular solution.

[Monorail components: UI>Browser>WebAppInstalls]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Description Changed]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Removing old assignments that no longer represent what is being worked on. Our team's milestone based bug fix process will keep an eye on the WebAppInstall bugs and get them reassigned based on priorities.

[Empty comment from Monorail migration]

can you help triage?

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

add estimates.

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Modernizing label usage.

Updating ownership and status - please fix if incorrect!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a70ccafc5410a3399468affe71f275abfe00296

commit 6a70ccafc5410a3399468affe71f275abfe00296
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Mar 05 23:05:48 2020

Remove kDesktopPWAsWithoutExtensions flag check in AppServiceContextMenu

The kWeb branch in AppServiceContextMenu::IsCommandIdChecked() is
capable of handling web apps that run using BMO or Extensions as the
backend. This CL removes the flag check and fallthrough behaviour.

Bug: 897314
Change-Id: I530988629aa92e13d3cac9ccb8bcd500c1e7f7c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087247
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747462}

[modify] https://crrev.com/6a70ccafc5410a3399468affe71f275abfe00296/chrome/browser/ui/app_list/app_service/app_service_context_menu.cc

Screencast for WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/2086465

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/758d885f8658dea2c18568d64e0814de5ab28792

commit 758d885f8658dea2c18568d64e0814de5ab28792
Author: Alan Cutter <alancutter@chromium.org>
Date: Mon Mar 09 07:01:44 2020

desktop-pwas: Add experimental "open in tabbed window" option behind flag

This is part of an experimental implementation of tabbed web app windows
hidden behind the DesktopPWAsTabStrip flag.

This CL adds a UI option for Chrome OS that lets users assign individual
web apps to be opened in the experimental tabbed window.

Because this option is experimental and users may turn the flag off at
any time we do not store this setting in the same place as the launch
container setting. Instead we store it in a per web app
"experimental_tabbed_window_mode" pref.

Screencast:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=436695&signed_aid=pNFo1z1fXrwGgoTkDSgTXA==&inline=1

Bug: 897314
Change-Id: Ie0a9417e38fd0cfc593d93b5b97224742b37d841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086465
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748126}

[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/ash/app_list/app_list_metrics.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/ash/public/cpp/app_menu_constants.h
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/app/generated_resources.grd
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/apps/app_service/menu_util.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/app_list/app_service/app_service_context_menu.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/ash/launcher/app_service/app_service_shelf_context_menu.cc
[add] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/ash/launcher/app_service/app_service_shelf_context_menu_browsertest.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/web_applications/app_browser_controller.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/app_registrar.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/app_registrar.h
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/app_registry_controller.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/app_registry_controller.h
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/web_app_constants.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/web_app_prefs_utils.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/web_app_prefs_utils.h
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/extensions/bookmark_app_registry_controller.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/web_app_sync_bridge.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/common/chrome_features.cc
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/test/BUILD.gn
[modify] https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/tools/metrics/histograms/enums.xml

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Updating DevTrial milestone

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/133a4b151f4f6453b5a848f2b6ae0a01d02e2789

commit 133a4b151f4f6453b5a848f2b6ae0a01d02e2789
Author: Alan Cutter <alancutter@chromium.org>
Date: Mon Mar 30 04:47:40 2020

desktop-pwas: Move DCHECK for kDesktopPWAsTabStrip

This CL updates a DCHECK for kDesktopPWAsTabStrip being enabled to only
occur if we're updating an app to use the experimental tabbed mode.
Previously it was possible to hit this DCHECK when the experiment is
disabled and the user is setting the window mode to something other than
tabbed mode.

Bug: 897314
Change-Id: Ie1bc99cf9967d45c4f9f3048ff8bf88025ed34d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126334
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754394}

[modify] https://crrev.com/133a4b151f4f6453b5a848f2b6ae0a01d02e2789/chrome/browser/web_applications/components/app_registry_controller.cc

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bad4f92f63fa6575a10310c1e77a36d4305da298

commit bad4f92f63fa6575a10310c1e77a36d4305da298
Author: Alan Cutter <alancutter@chromium.org>
Date: Mon May 04 06:53:40 2020

desktop-pwas: Extend DesktopPWAsTabStrip flag expiry

This feature is still being prototyped.

Bug: 897314
Change-Id: I9264d05f254f50eb81a462c365b8461d5fba02e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178651
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764997}

[modify] https://crrev.com/bad4f92f63fa6575a10310c1e77a36d4305da298/chrome/browser/flag-metadata.json

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

Will the 3-finger swipe gesture to switch between tabs on ChromeOS be supported with tabbed PWAs. Currently on 84.0.4142.0 this does not work but it should because otherwise it's inconsistent with system behavior

[Empty comment from Monorail migration]

#45: Yes, created https://bugs.chromium.org/p/chromium/issues/detail?id=1084443.

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/866ccd78c033c3a461ab619e87c1f16d6f43c01a

commit 866ccd78c033c3a461ab619e87c1f16d6f43c01a
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Dec 03 05:14:12 2020

Extend tabbed web app experimental flags

This CL extends the expiry of:
 - enable-desktop-pwas-tab-strip
 - enable-desktop-pwas-tab-strip-link-capturing

Bug: 897314, 1078301
Change-Id: I1160964909d44d580b3cf394ce129adbbc7f3423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569141
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833163}

[modify] https://crrev.com/866ccd78c033c3a461ab619e87c1f16d6f43c01a/chrome/browser/flag-metadata.json

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/d7da81418e5b655aab6ab714c6864072d7d644ae

commit d7da81418e5b655aab6ab714c6864072d7d644ae
Author: Louise Brett <loubrett@google.com>
Date: Mon Jun 07 01:05:49 2021

Move DesktopPWAsTabStrip flag from chrome/ to content/.

This change means the flag can be used in components/ and content/ in
https://chromium-review.googlesource.com/c/chromium/src/+/2929540.

https://github.com/w3c/manifest/issues/737

Bug: 897314
Change-Id: I62bff44e6e5b94d0434cdb76ff33d23197cbb4ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2929417
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/master@{#889631}

[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/apps/app_service/menu_util.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/ui/ash/shelf/app_service/app_service_shelf_context_menu_browsertest.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/ui/views/web_apps/pwa_confirmation_bubble_view.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/ui/views/web_apps/web_app_confirmation_view.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/ui/web_applications/app_browser_controller.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/ui/web_applications/web_app_link_capturing_browsertest.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/web_applications/components/app_registrar.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/browser/web_applications/components/app_registry_controller.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/common/chrome_features.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/chrome/common/chrome_features.h
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/content/public/common/content_features.cc
[modify] https://crrev.com/d7da81418e5b655aab6ab714c6864072d7d644ae/content/public/common/content_features.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/ae398c46921448f8ead65daa950fc6aa3dbc513b

commit ae398c46921448f8ead65daa950fc6aa3dbc513b
Author: Louise Brett <loubrett@google.com>
Date: Fri Jun 11 01:39:41 2021

Add tabbed as a new display mode.

This change adds a new display mode "tabbed" which is only valid when
used as a display_override.

Tested:
- PWA with display:"standalone", display_override:["tabbed"] is
installable and tabbed is a valid display override when flag is enabled.
- PWA with display:"standalone", display_override:["tabbed"] is
installable but tabbed is not a valid display override when flag is
disabled.
- PWA with display:"tabbed" is not installable.


Bug: 897314
Change-Id: I140764f332a9318597d59adbbd277b7158b23738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2929540
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/master@{#891499}

[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/web_applications/app_service/web_app_publisher_helper.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/web_applications/components/web_app_constants.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/web_applications/externally_managed_app_install_task.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/web_applications/manifest_update_task.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/web_applications/proto/web_app.proto
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/web_applications/web_app.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/web_applications/web_app_database.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/chrome/browser/web_applications/web_app_proto_utils.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/components/sync/protocol/web_app_specifics.proto
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/components/webapps/browser/installable/installable_manager.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/components/webapps/browser/installable/installable_manager_unittest.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/content/child/runtime_features.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/third_party/blink/common/manifest/manifest_util.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/third_party/blink/common/manifest/manifest_util_unittest.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/third_party/blink/public/mojom/manifest/display_mode.mojom
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/third_party/blink/renderer/modules/manifest/manifest_parser.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/third_party/blink/renderer/modules/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/ae398c46921448f8ead65daa950fc6aa3dbc513b/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/fbe4d6d15ac72c502535a1827cd3712d02578394

commit fbe4d6d15ac72c502535a1827cd3712d02578394
Author: Louise Brett <loubrett@google.com>
Date: Fri Jun 11 08:05:59 2021

Open app in tabbed window if it has 'tabbed' display override

This change adds the method IsTabbedWindowModeEnabled which is used
instead of IsInExperimentalTabbedWindowMode.
IsInExperimentalTabbedWindowMode can eventually be removed once the
feature has launched and we remove the user setting to open in tabbed
window.

Bug: 897314
Change-Id: I3f395f9ee636462671cc5e07e8759671f0252725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2951983
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/master@{#891575}

[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/apps/intent_helper/apps_navigation_throttle.cc
[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/ui/web_applications/app_browser_controller.cc
[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/ui/web_applications/web_app_browsertest.cc
[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/ui/web_applications/web_app_launch_manager.cc
[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/ui/web_applications/web_app_launch_utils.cc
[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/web_applications/app_service/web_app_publisher_helper.cc
[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/web_applications/components/app_registrar.cc
[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/web_applications/components/app_registrar.h
[modify] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/browser/web_applications/components/web_app_constants.cc
[add] https://crrev.com/fbe4d6d15ac72c502535a1827cd3712d02578394/chrome/test/data/banners/manifest_tabbed_display_override.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/51548fb4b969c82c70f4fffa470358620183c959

commit 51548fb4b969c82c70f4fffa470358620183c959
Author: Louise Brett <loubrett@google.com>
Date: Fri Jun 18 00:27:21 2021

Put 'open as tabbed window' settings behind a separate flag

There are three places to select whether the app should open
in a tabbed window:
- ‘Open as tabbed window’ tickbox when installing the PWA
- ‘Open as tabbed window’ radio button when creating shortcut
- ‘New tabbed window’ when right clicking on the icon in the shelf

These are all for testing purposes and wont be launched so are put
behind the new DeskptopPWAsTabStripSettings flag in this cl.


Bug: 897314
Change-Id: I6a22b41aa4fd13a948f0d0191c7755470ffea71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2966676
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/master@{#893629}

[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/about_flags.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/apps/app_service/menu_util.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/flag-metadata.json
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/ui/ash/shelf/app_service/app_service_shelf_context_menu_browsertest.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/ui/views/web_apps/pwa_confirmation_bubble_view.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/ui/views/web_apps/web_app_confirmation_view.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/ui/web_applications/web_app_link_capturing_browsertest.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/web_applications/app_service/web_app_publisher_helper.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/web_applications/components/app_registrar.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/browser/web_applications/components/app_registrar.h
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/common/chrome_features.cc
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/chrome/common/chrome_features.h
[modify] https://crrev.com/51548fb4b969c82c70f4fffa470358620183c959/tools/metrics/histograms/enums.xml

[Empty comment from Monorail migration]

There is a bug in the current codebase logic:

1) WebAppInstallFinalizer::FinalizeInstall()
may make a copy of existing_web_app before commit.

2) Then registry_controller().SetExperimentalTabbedWindowMode() gets called which
uploads a change to the sync server - SetAppUserDisplayMode()

3)  SetWebAppManifestFieldsAndWriteData() get called at the end of WebAppInstallFinalizer::FinalizeInstall()
which will overwrite user display mode with its previous value.

We must not call any setters in WebAppInstallFinalizer::FinalizeInstall().
Please, fix.

The problematic setter call:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/web_applications/web_app_install_finalizer.cc;drc=f432daa83ec3869cbda6a454af11a82d06d16eef;l=219

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/262f3db86a44c626143e950a8b89787039e1ffcc

commit 262f3db86a44c626143e950a8b89787039e1ffcc
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Sep 10 03:06:44 2021

Extend the tabbed web app window feature flag expiries

This work on tabbed web app windows is still ongoing.

Bug: 897314
Change-Id: I7557c52fa0937aca299508c7a182ae49c0fc10e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3151353
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/main@{#920100}

[modify] https://crrev.com/262f3db86a44c626143e950a8b89787039e1ffcc/chrome/browser/flag-metadata.json

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/c157bc45a2c76ccb439240e817f0274e0e72e696

commit c157bc45a2c76ccb439240e817f0274e0e72e696
Author: Louise Brett <loubrett@google.com>
Date: Wed Jan 12 00:51:53 2022

Extend tabbed web app feature flag expiries.

Work is still ongoing for this feature.

Bug: 897314
Change-Id: I41c54816cf2d973df76ddb37d6e179c74c2f1455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3379602
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/main@{#957853}

[modify] https://crrev.com/c157bc45a2c76ccb439240e817f0274e0e72e696/chrome/browser/flag-metadata.json

Would be cool if the tabbed mode would support custom content in the title bar. For example, the Chrome browser has an extra "down" button in its titlebar (see attachment). Other applications feature similar extra content.

A custom title bar menu sounds like a good general proposal for web apps. We already do this for the Terminal system web app on Chrome OS.

[Comment Deleted]

> > Would be cool if the tabbed mode would support custom content in the title bar.
>
> A custom title bar menu sounds like a good general proposal for web apps

@leevi @alancutter Isn't this other feature you both are describing actually the PWA Windows Control Overlay that already exists since Chrome 97-98?

Article by Thomas Steiner and Amanda Baker: https://web.dev/window-controls-overlay/

Tabbed mode + WCO doesn't yet exist but it's true that it would solve most use cases of an app menu button.
Browser implementation/spec wise it might be easier to define tabbed mode + app menu button than tabbed mode + WCO. Both options are worth considering.

PWA Windows Control Overlay is not a viable solution, because tabs are not enabled.

Building a custom tab implementation is not a feasible solution, mostly because same site iframes will not run as separate processes.

Not entirely sure about how a "tabbed mode + app menu button" would specifically work. I see that it would be beneficial to add content on both sides of the tabs in certain situations. For example, the Opera browser (among others) does just this (see attachment).

Actually, it seems like same site iframes can now be run as separate processes, however, this is still experimental.

See: https://bugs.chromium.org/p/chromium/issues/detail?id=510122#c26

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/4cf6a057b265f80cfb9846a765fafc94baf64143

commit 4cf6a057b265f80cfb9846a765fafc94baf64143
Author: Louise Brett <loubrett@google.com>
Date: Thu Jun 02 07:03:10 2022

Tabbed mode manifest parsing.

Parses the 'tab_strip' manifest field when 'tabbed' is one of the
display overrides.

Explainer: https://github.com/WICG/manifest-incubations/blob/gh-pages/tabbed-mode-explainer.md
I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/IvfIkjvQYuY/m/cixwOyEeAAAJ

Bug: 897314
Change-Id: I58b234a1eb008769bb8b7490f04d7ad00b09a471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3676736
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/main@{#1009970}

[modify] https://crrev.com/4cf6a057b265f80cfb9846a765fafc94baf64143/third_party/blink/public/mojom/manifest/manifest.mojom
[modify] https://crrev.com/4cf6a057b265f80cfb9846a765fafc94baf64143/third_party/blink/renderer/modules/manifest/manifest_parser_unittest.cc
[modify] https://crrev.com/4cf6a057b265f80cfb9846a765fafc94baf64143/third_party/blink/renderer/modules/manifest/manifest_parser.cc
[modify] https://crrev.com/4cf6a057b265f80cfb9846a765fafc94baf64143/third_party/blink/renderer/modules/manifest/manifest_parser.h

Dragging tabs within a PWA to reorder them or to pull a tab into a new window crashes the PWA.

What OS are you using? This is a known issue on Mac: https://crbug.com/1076777

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/629e20bb6864fa7c74e33bd4aa7f0337c9523257

commit 629e20bb6864fa7c74e33bd4aa7f0337c9523257
Author: Louise Brett <loubrett@google.com>
Date: Wed Jun 15 01:53:05 2022

Extend tabbed web app feature flag expiries.

Bug: 897314
Change-Id: I6037af611ac359e0aad51112d47a6a948ead63c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3703118
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Louise Brett <loubrett@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1014244}

[modify] https://crrev.com/629e20bb6864fa7c74e33bd4aa7f0337c9523257/chrome/browser/flag-metadata.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/edcc2a0de62aa4242f558e697ca352275649bc1a

commit edcc2a0de62aa4242f558e697ca352275649bc1a
Author: Louise Brett <loubrett@google.com>
Date: Wed Jun 22 04:31:15 2022

Add tab_strip field to WebAppInstallInfo.

This CL plumbs the tab_strip field through mojom_traits for use in
WebAppInstallInfo.

Explainer: https://github.com/WICG/manifest-incubations/blob/gh-pages/tabbed-mode-explainer.md


Bug: 897314
Change-Id: I993fb3b19cefa95b124f456de43c3f8402ce957c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3694874
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1016540}

[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/third_party/blink/public/common/manifest/manifest.h
[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/chrome/browser/web_applications/web_app_install_utils_unittest.cc
[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/third_party/blink/common/manifest/manifest.cc
[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/third_party/blink/public/common/manifest/manifest_mojom_traits.h
[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/chrome/browser/web_applications/web_app_install_info.h
[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/third_party/blink/public/mojom/BUILD.gn
[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/third_party/blink/common/manifest/manifest_mojom_traits.cc
[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/chrome/browser/web_applications/web_app_install_utils.cc
[modify] https://crrev.com/edcc2a0de62aa4242f558e697ca352275649bc1a/chrome/browser/web_applications/web_app_constants.h

[Description Changed]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/a0db97de163ba2e993b98f1a7c11e76a91462f1c

commit a0db97de163ba2e993b98f1a7c11e76a91462f1c
Author: Louise Brett <loubrett@google.com>
Date: Wed Jul 06 01:10:37 2022

Add tab_strip field to web_app and web_app_database

This CL ignores the home_tab icons, which will be handled in a
future CL.

Explainer: https://github.com/WICG/manifest-incubations/blob/gh-pages/tabbed-mode-explainer.md


Bug: 897314
Change-Id: I03384e4e04157ce64af5e2124e6e013470c9b10c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3740222
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1021024}

[add] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/proto/web_app_tab_strip.proto
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/web_app.cc
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/web_app.h
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/manifest_update_task.cc
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/proto/web_app.proto
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/test/web_app_test_utils.cc
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/web_app_unittest.cc
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/web_app_install_utils.cc
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/proto/BUILD.gn
[modify] https://crrev.com/a0db97de163ba2e993b98f1a7c11e76a91462f1c/chrome/browser/web_applications/web_app_database.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/741ba7f06fb05968222b6e3e865ef0517dfa6435

commit 741ba7f06fb05968222b6e3e865ef0517dfa6435
Author: Louise Brett <loubrett@google.com>
Date: Mon Jul 18 07:49:34 2022

Allow tabbed web apps to set a custom new tab URL

Tabbed web apps can set a URL in the manifest to be opened when the
new tab button is clicked, instead of opening the start URL.

Explainer: https://github.com/WICG/manifest-incubations/blob/gh-pages/tabbed-mode-explainer.md

Bug: 897314
Change-Id: Iccfe133dafac645300752a3c18986abc81ac87bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3750616
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Auto-Submit: Louise Brett <loubrett@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1025163}

[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/ui/web_applications/web_app_browser_controller.h
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/ui/web_applications/app_browser_controller.cc
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/ui/web_applications/app_browser_controller.h
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/test/data/banners/manifest_tabbed_display_override.json
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/web_applications/web_app_registrar_unittest.cc
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/web_applications/web_app_registrar.cc
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/ui/web_applications/web_app_browser_controller.cc
[add] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/test/data/banners/manifest_tab_strip_customizations.json
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/ui/browser.cc
[modify] https://crrev.com/741ba7f06fb05968222b6e3e865ef0517dfa6435/chrome/browser/web_applications/web_app_registrar.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/5ba24c793ffc9dd40451719f7039e54ce0516ae4

commit 5ba24c793ffc9dd40451719f7039e54ce0516ae4
Author: Louise Brett <loubrett@google.com>
Date: Tue Aug 09 04:24:06 2022

Open pinned home tab when tabbed web app opens.

For apps that have set the home tab in their manifest, the home tab
will be pinned any time the app is opened. This includes installing,
link capturing and opening from the shelf.

Future CLs will handle:
- Not allowing the pinned home tab to be closed.
- Links opened from home tab opening in new tabs.
- Pin home tab when app is restored.

Bug: 897314
Change-Id: Id23a5d95fd24800e0415aa7f9723e8f67758fac5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789442
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/main@{#1032870}

[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/web_applications/web_app_launch_utils.cc
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/web_applications/web_app_launch_utils.h
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/web_applications/web_app_launch_process.cc
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/web_applications/web_app_registrar.cc
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/web_applications/web_app_database.cc
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/web_applications/test/web_app_browsertest_util.h
[add] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/web_applications/web_app_tabbed_utils.h
[add] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/test/data/web_apps/tab_strip_customizations.html
[add] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/web_applications/web_app_tabbed_utils.cc
[rename] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/test/data/web_apps/tab_strip_customizations.json
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/web_applications/app_browser_controller.cc
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/web_applications/test/web_app_browsertest_util.cc
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/5ba24c793ffc9dd40451719f7039e54ce0516ae4/chrome/browser/web_applications/web_app_registrar.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df

commit d9f966d3fe44fb0f29afdeb3a43f01a257ec63df
Author: Louise Brett <loubrett@google.com>
Date: Mon Aug 29 04:23:14 2022

Add navigation throttle for tabbed web apps

The navigation throttle is only created for tabbed web apps with a
pinned home tab. It causes the following behaviour:
- When a link is clicked on the home tab, it will open in a new tab.
- When a link to the home tab is clicked, it will open in the home
tab and this tab will be focused.

Bug: 897314
Change-Id: Ib8bd92329f9d47f2192c4fa3aa70a34f048cb420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826451
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1040249}

[modify] https://crrev.com/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df/chrome/browser/ui/web_applications/web_app_launch_utils.cc
[modify] https://crrev.com/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df/chrome/browser/web_applications/web_app_tab_helper.h
[modify] https://crrev.com/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df/chrome/browser/ui/web_applications/web_app_launch_utils.h
[add] https://crrev.com/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df/chrome/browser/ui/web_applications/tabbed_web_app_navigation_throttle.cc
[modify] https://crrev.com/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df/chrome/browser/ui/web_applications/tabbed_web_app_navigation_throttle.h
[modify] https://crrev.com/d9f966d3fe44fb0f29afdeb3a43f01a257ec63df/chrome/browser/chrome_content_browser_client.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/c88b09d86cd644e76755592eebbcc2fcab5ed880

commit c88b09d86cd644e76755592eebbcc2fcab5ed880
Author: Louise Brett <loubrett@google.com>
Date: Thu Sep 01 09:13:56 2022

Remove some tab menu options for tabbed web apps.

Not all of the tab menu options are relevant for tabbed web apps.
This CL removes:
- Add tab to group
- Move tab to another window
- Pin tab
- Follow/Unfollow site

For the pinned home tab the following are also removed:
- Duplicate
- Close

The added tests are intended to fail when new menu items are added.
This means that whoever is adding an item will need to consider
whether the item is relevant for tabbed web apps and either add it
to the test or disable the item for web apps.

Bug: 897314
Change-Id: I471f65463638ddffb4cf5645de99067e5e4dff06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3864661
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1041958}

[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/web_applications/web_app_tabbed_utils.h
[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/web_applications/web_app_tabbed_utils.cc
[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/tabs/tab_menu_model.cc
[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/browser_tab_strip_model_delegate.h
[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/tabs/test_tab_strip_model_delegate.h
[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/browser_tab_strip_model_delegate.cc
[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/tabs/tab_menu_model_unittest.cc
[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/tabs/test_tab_strip_model_delegate.cc
[modify] https://crrev.com/c88b09d86cd644e76755592eebbcc2fcab5ed880/chrome/browser/ui/tabs/tab_strip_model_delegate.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/556b52113dff2adb309e2a4128da87d8dffe9559

commit 556b52113dff2adb309e2a4128da87d8dffe9559
Author: Louise Brett <loubrett@google.com>
Date: Thu Sep 08 08:11:19 2022

Add Copy URL to tab context menu

This menu item will only be shown for tabbed web apps.

Bug: 897314
Change-Id: Ieda51edc0602ecb81559457f26df70e6bb2fa643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3875347
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044431}

[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/tabs/tab_menu_model.cc
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/browser_tab_strip_model_delegate.h
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/tabs/test_tab_strip_model_delegate.h
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/browser_tab_strip_model_delegate.cc
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/tools/metrics/actions/actions.xml
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/tabs/tab_strip_model_delegate.h
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/tabs/tab_menu_model_unittest.cc
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/tabs/test_tab_strip_model_delegate.cc
[modify] https://crrev.com/556b52113dff2adb309e2a4128da87d8dffe9559/chrome/browser/ui/browser_commands.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/bca7e40f1be3d84ec01361cc3b6764d346b480f2

commit bca7e40f1be3d84ec01361cc3b6764d346b480f2
Author: Louise Brett <loubrett@google.com>
Date: Fri Sep 09 15:57:25 2022

Disable 'Open in Chrome' menu item for the pinned home tab of web apps

This option causes the tab to close, which we don't want to happen for
the pinned home tab.

Bug: 897314
Change-Id: I43b86ead14e37801f44c61de8e24f0333f858d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3874298
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1045138}

[modify] https://crrev.com/bca7e40f1be3d84ec01361cc3b6764d346b480f2/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/bca7e40f1be3d84ec01361cc3b6764d346b480f2/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/68e3a06a6f14c51b0d013c7e78405abe04787770

commit 68e3a06a6f14c51b0d013c7e78405abe04787770
Author: Louise Brett <loubrett@google.com>
Date: Wed Sep 14 20:21:48 2022

Only navigate the home tab if the URL has changed

Otherwise the home tab should just be focused.

As discussed in go/tabbed-pwas-home-tab, URLs that are equal to the
start URL but also have query params or hash params should open in
the home tab. In these cases the home tab should be navigated so the
page displays the correct content. However we don't want to navigate
the home tab if the URL hasn't changed to avoid an unecessary reload.
This doesn't handle scrolling back to the top of the page unfortunately.

Bug: 897314
Change-Id: Ibadd49a7841b4765f16e440cae8e196ce2b287e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3868627
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1047085}

[modify] https://crrev.com/68e3a06a6f14c51b0d013c7e78405abe04787770/chrome/browser/ui/web_applications/web_app_launch_utils.cc
[modify] https://crrev.com/68e3a06a6f14c51b0d013c7e78405abe04787770/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/68e3a06a6f14c51b0d013c7e78405abe04787770/chrome/browser/ui/web_applications/tabbed_web_app_navigation_throttle.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/86f7cdad51c753a14af355acb0638d0ebd5282fd

commit 86f7cdad51c753a14af355acb0638d0ebd5282fd
Author: Louise Brett <loubrett@google.com>
Date: Wed Sep 28 08:33:17 2022

Remove favicons for tabbed web apps

For most tabbed web apps the favicon is the same for every tab, so
avoid repetition by removing it.

Bug: 897314
Change-Id: I5b00e1e23d479301ff8f376ca2be29f2d8780ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3878449
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/main@{#1052286}

[modify] https://crrev.com/86f7cdad51c753a14af355acb0638d0ebd5282fd/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/86f7cdad51c753a14af355acb0638d0ebd5282fd/chrome/browser/ui/browser.cc
[modify] https://crrev.com/86f7cdad51c753a14af355acb0638d0ebd5282fd/chrome/browser/ui/web_applications/app_browser_controller_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/58ed936db675a06a0897daf0534fab3b21d8a03e

commit 58ed936db675a06a0897daf0534fab3b21d8a03e
Author: Louise Brett <loubrett@google.com>
Date: Tue Oct 25 07:26:15 2022

Only create tabbed web app navigation throttle for primary main frame

This fixes an issue with the pinned home tab where subframe
navigations were opening in a new tab, causing some strange bahviour.

This change also adds WillRedirectRequest(). This doesn't change
any behaviour but makes it clear what is happening with redirects.

Bug: 897314
Change-Id: I9af7e791dae976a3148bc38d29a05bcd7ccaac54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963947
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1063187}

[modify] https://crrev.com/58ed936db675a06a0897daf0534fab3b21d8a03e/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/58ed936db675a06a0897daf0534fab3b21d8a03e/chrome/browser/ui/web_applications/tabbed_web_app_navigation_throttle.cc
[modify] https://crrev.com/58ed936db675a06a0897daf0534fab3b21d8a03e/chrome/test/data/web_apps/tab_strip_customizations.html
[modify] https://crrev.com/58ed936db675a06a0897daf0534fab3b21d8a03e/chrome/browser/ui/web_applications/tabbed_web_app_navigation_throttle.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/32c3be549a4b623761b02aa6fba06a5d94b04e79

commit 32c3be549a4b623761b02aa6fba06a5d94b04e79
Author: Louise Brett <loubrett@google.com>
Date: Fri Nov 04 02:55:55 2022

Dont create tabbed web app navigation throttle for reloads.

In some situations, reloading the home tab would cause a new tab to
open. It doesn't make sense for reloading to open in a new tab or
focus the home tab, so we shouldn't create the throttle for reloads.


Bug: 897314
Change-Id: I9fcdc53619adbe0776b8da572f345fc831624f3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4001320
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1067380}

[modify] https://crrev.com/32c3be549a4b623761b02aa6fba06a5d94b04e79/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/32c3be549a4b623761b02aa6fba06a5d94b04e79/chrome/browser/ui/web_applications/tabbed_web_app_navigation_throttle.cc

[Empty comment from Monorail migration]

[Monorail components: UI>Browser>WebAppInstalls>Tabbed]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/6024a419704c71e2cddff8c4525c9d1efc6769b1

commit 6024a419704c71e2cddff8c4525c9d1efc6769b1
Author: Louise Brett <loubrett@google.com>
Date: Mon Nov 07 01:18:50 2022

Don't look at query params when comparing home tab URL for tabbed PWAs.

If the start_url of a tabbed web app contains query params, an
identical URL without the query params should also be considered
part of the home tab.

Bug: 897314
Change-Id: Ie023fc63ac4f1455a7fd6a2d1123db7eacdb6c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4005623
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/main@{#1067949}

[modify] https://crrev.com/6024a419704c71e2cddff8c4525c9d1efc6769b1/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/6024a419704c71e2cddff8c4525c9d1efc6769b1/chrome/browser/ui/web_applications/web_app_tabbed_utils.cc
[add] https://crrev.com/6024a419704c71e2cddff8c4525c9d1efc6769b1/chrome/test/data/web_apps/tab_strip_query_params_in_start_url.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/015114f674e4f99e6c74cdd28bfa268c7397af6d

commit 015114f674e4f99e6c74cdd28bfa268c7397af6d
Author: Louise Brett <loubrett@google.com>
Date: Mon Nov 07 04:14:11 2022

Update tabbed PWAs flag description.

People often search for "tabbed" to try find this flag but the
description previously didn't contain that word so the flag wouldn't
show up.

Bug: 897314
Change-Id: Iec4f3fee3979f153e817d7cccb06dccfea638a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4005694
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/main@{#1067973}

[modify] https://crrev.com/015114f674e4f99e6c74cdd28bfa268c7397af6d/chrome/browser/flag_descriptions.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/ae01bed2171b357155ef18e220130f9f1a6b8c66

commit ae01bed2171b357155ef18e220130f9f1a6b8c66
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Mon Nov 14 01:04:58 2022

Desktop PWAs: Extend expiry of tab-strip flags

We extend the following flags:
- enable-desktop-pwas-tab-strip
- enable-desktop-pwas-tab-strip-settings
- enable-desktop-pwas-sub-apps
- enable-desktop-pwas-default-offline-page

Bug: 897314
Change-Id: I127ec4a2433942462668057350f3ee91e374183a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4022954
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Louise Brett <loubrett@google.com>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1070828}

[modify] https://crrev.com/ae01bed2171b357155ef18e220130f9f1a6b8c66/chrome/browser/flag-metadata.json

[Empty comment from Monorail migration]

We've found the following bugs / issues for tabbed PWA's in our tests:
- The home_tab field is ignored if we set an url different than the start_url. Proposed solution: home_tab url should be the start_url of a tabbed PWA
- The window title is overlayed over the tab navigation. Proposed solution: should be hidden
- We've found no way to detect if the PWA is in tabbed mode or not (because of the flag). Is there a way to detect this?

Thanks for your feedback!

[Comment Deleted]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/0115847959389e0596cc2cea975f1bd7728ceaa5

commit 0115847959389e0596cc2cea975f1bd7728ceaa5
Author: Louise Brett <loubrett@google.com>
Date: Wed Apr 26 08:06:13 2023

Add new flag for tabbed mode customizations.

Add a new flag for tabbed mode to separate the 'tabbed' display mode
and the 'tab_strip' manifest field. This new flag is for the
'tab_strip' field which allows apps to customise the tab strip and the
existing flag, kDesktopPWAsTabStrip, is for the tabbed display mode.

See explainer for more detail:
https://github.com/WICG/manifest-incubations/blob/gh-pages/tabbed-mode-explainer.md

Bug: 897314
Change-Id: I86806d626ba2357fdcbf01f1b29512aa6f09015d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4478391
Commit-Queue: Louise Brett <loubrett@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1135781}

[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/content/child/runtime_features.cc
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/chrome/browser/about_flags.cc
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/third_party/blink/common/features.cc
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/third_party/blink/public/common/features.h
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/third_party/blink/renderer/modules/manifest/manifest_parser.cc
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/chrome/browser/flag-metadata.json
[modify] https://crrev.com/0115847959389e0596cc2cea975f1bd7728ceaa5/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/5d5013f516d270b2bd4d6d257de2d710c2740bef

commit 5d5013f516d270b2bd4d6d257de2d710c2740bef
Author: Louise Brett <loubrett@google.com>
Date: Thu May 18 07:37:49 2023

Manifest updating for tab_strip field

Bug: 897314
Change-Id: I048c286a90c63c0a5747ddaf4bd9eaed23889791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4541946
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Louise Brett <loubrett@google.com>
Cr-Commit-Position: refs/heads/main@{#1145848}

[modify] https://crrev.com/5d5013f516d270b2bd4d6d257de2d710c2740bef/chrome/browser/web_applications/web_app.h
[modify] https://crrev.com/5d5013f516d270b2bd4d6d257de2d710c2740bef/chrome/browser/web_applications/manifest_update_manager_browsertest.cc
[modify] https://crrev.com/5d5013f516d270b2bd4d6d257de2d710c2740bef/chrome/browser/web_applications/manifest_update_utils.cc

Re https://crbug.com/chromium/897314#c94:
Thanks for the feedback Philipp! Sorry for the slow response - I only just saw your comment.

> The home_tab field is ignored if we set an url different than the start_url. Proposed solution: home_tab url should be the start_url of a tabbed PWA
We've decided to not let the home tab url be customisable for now - so we will use the start_url. But even if you do try to set a url, the home_tab field shouldn't be completely ignored - if you're able to share the syntax you used that would help to figure out what is happening here.

> The window title is overlayed over the tab navigation. Proposed solution: should be hidden
Are you using windows? If so, this is tracked in https://crbug.com/1084384

> We've found no way to detect if the PWA is in tabbed mode or not (because of the flag). Is there a way to detect this?
You can use a media query to check the display mode. Eg: media="(display-mode: tabbed)"

Thanks for your feedback Louise! Are there any plans to bring the tabbed mode in trial?

We've found another "bug": If the PWA ist in tabbed mode, the launch_handler settings in the manifest (https://developer.mozilla.org/en-US/docs/Web/API/Launch_Handler_API) are ignored. It will always open a new tab instead of trigger the launchQueue when "focus-existing" is defined in the manifest.

We're planning to run an origin trial on ChromeOS from M117.

I've filed https://crbug.com/1466384 to track the launch_handler bug. Thanks for pointing this out!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/541ae570566c2da6dab7d5e3630e9a74395ff584

commit 541ae570566c2da6dab7d5e3630e9a74395ff584
Author: Louise Brett <loubrett@google.com>
Date: Fri Jul 21 00:27:35 2023

Add use counter for tabbed display mode.

Bug: 897314
Change-Id: Iaacedea5634481074f771efcaaa25210714216a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4701610
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Louise Brett <loubrett@google.com>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1173252}

[modify] https://crrev.com/541ae570566c2da6dab7d5e3630e9a74395ff584/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify] https://crrev.com/541ae570566c2da6dab7d5e3630e9a74395ff584/third_party/blink/renderer/modules/manifest/manifest_manager.cc
[modify] https://crrev.com/541ae570566c2da6dab7d5e3630e9a74395ff584/third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
[modify] https://crrev.com/541ae570566c2da6dab7d5e3630e9a74395ff584/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/bc12de7f20408d4934f360a041aaf525087c7a3b

commit bc12de7f20408d4934f360a041aaf525087c7a3b
Author: Louise Brett <loubrett@google.com>
Date: Fri Aug 04 13:28:55 2023

Enable origin trial for tabbed mode on ChromeOS

Intent to experiment: https://groups.google.com/a/chromium.org/g/blink-dev/c/m16m2TEq-NM/m/0Bc10numCgAJ

Bug: 897314
Change-Id: I5b521cd572fe2f2d6919ce0839722fe84475400a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4751382
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1179554}

[modify] https://crrev.com/bc12de7f20408d4934f360a041aaf525087c7a3b/third_party/blink/renderer/platform/runtime_enabled_features.json5

[Empty comment from Monorail migration]

[Monorail components: -UI>Browser>WebAppInstalls]

This issue was migrated from crbug.com/chromium/897314?no_tracker_redirect=1

[Monorail blocked-on: crbug.com/chromium/1020050, crbug.com/chromium/1062169, crbug.com/chromium/1065757, crbug.com/chromium/1076721, crbug.com/chromium/1076725, crbug.com/chromium/1076726, crbug.com/chromium/1076775, crbug.com/chromium/1076777, crbug.com/chromium/1076778, crbug.com/chromium/1076780, crbug.com/chromium/1078301, crbug.com/chromium/1082103, crbug.com/chromium/1084443, crbug.com/chromium/1104083, crbug.com/chromium/1156880, crbug.com/chromium/1205701, crbug.com/chromium/1230434, crbug.com/chromium/1268237, crbug.com/chromium/1381358, crbug.com/chromium/1406730, crbug.com/chromium/1417525, crbug.com/chromium/1418181]
[Monorail blocking: crbug.com/chromium/917517, crbug.com/chromium/953472, crbug.com/chromium/964071]
[Monorail components added to Component Tags custom field.]