IssueTracker

Generated Metadata

• Summary: The Apps Script project is unexpectedly requesting the script.container.ui authorization scope when the word 'show' is present in a comment and SpreadsheetApp.getActive() is invoked. This behavior is unexpected and should be investigated.
• Tags:
  • authorization-scope
  • spreadsheetapp
  • script-container-ui
  • unexpected-behavior
  • comment-parsing

Additional resources:

• https://stackoverflow.com/.../unexpected-error-while-getting-the-method-or...
• https://stackoverflow.com/.../were-sorry-a-server-error-occurred-while-read...
• https://stackoverflow.com/.../google-add-on-script-throws-server-error-whe...
• https://stackoverflow.com/.../authorisation-is-required-to-perform-that-actio...
• https://stackoverflow.com/.../permission-denied-when-trying-to-create-a-spr...

A workaround is to manually specific scopes. https://developers.google.com/apps-script/concepts/scopes

I have reported this to the engineering team and future updates will be shared here. Thank you for your patience.

Making it a list assignment instead of a direct assignment fixes it immediately with no changes to gn_ast, though that does mean individual deps will be added to each split target over time. Is that acceptable?

diff --git i/chrome/android/javatests/BUILD.gn w/chrome/android/javatests/BUILD.gn
index 23c28e94caa84..cf4086e62fc69 100644
--- i/chrome/android/javatests/BUILD.gn
+++ w/chrome/android/javatests/BUILD.gn
@@ -1375,7 +1375,10 @@ android_library("chrome_test_java_org.chromium.chrome.browser.tasks") {
     "//chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TestRecyclerViewSimpleViewBinder.java",
   ]
 
-  deps = chrome_test_java_deps
+  deps = [
+    "//third_party/android_deps:espresso_java",
+    chrome_test_java_deps,
+  ]
 }
 
 android_library("chrome_test_java_org.chromium.chrome.browser.toolbar") {

I think that's actually preferable. We just did the big list to save time.

Awesome, that's a lot easier of a fix. This command can find potential issues for gn_editor:

$ git grep " deps = [^\[]" -- "**BUILD.gn"

I'll fix the android ones at least.

Project: chromium/src
Branch: main
Author: Peter Wen wnwen@google.com
Link:      https://chromium-review.googlesource.com/6427941

android: Make deps assignment a list where possible

     
    The places where it makes sense for gn_editor to work and append to a 
    list (e.g. deps = [ target ] becomes deps = [ target, new_target ]), 
    gn_editor expects the assignment to be a GN list instead of just a 
    direct variable assignment. When it's a direct variable assignment, 
    gn_editor assumes that it should not change and expects the user to 
    manually figure out which variable(s) the new dep should be added to. 
     
    In the case of the deps lists in this CL, however, these are expected to 
    change and new deps needed for individual targets going forward, so 
    these need to be a pure list assignment in order for gn_editor to append 
    to the existing list. 
     
    R=martinkong@google.com 
     
    Bug: 406536423 
    Change-Id: I0b81d34b1ae5fd56ca20430aae7e03f6f9409d3b 
    Fixed: 406536423 
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6427941 
    Commit-Queue: Martin Kong <martinkong@google.com> 
    Auto-Submit: Peter Wen <wnwen@chromium.org> 
    Reviewed-by: Martin Kong <martinkong@google.com> 
    Cr-Commit-Position: refs/heads/main@{#1442310}