Change theme
Help
Press space for more information.
Show links for this issue (Shortcut: i, l)
Copy issue ID
Previous Issue (Shortcut: k)
Next Issue (Shortcut: j)
Sign in to use full features.
Vote: I am impacted
Notification menu
Refresh (Shortcut: Shift+r)
Go home (Shortcut: u)
Pending code changes (auto-populated)
View issue level access limits(Press Alt + Right arrow for more information)
Attachment actions
Unintended behavior
View staffing
Description
Several issues noticed in stack sampling:
useStackSampling = truefrom macrobenchmark inPerfettoConfig.Benchmark(), since what it really means is "enable stack sampling if Arguments.profiler == StackSamplingSimpleperf"We should refactor this to be clearer. PerfettoConfig.Benchmark shouldn't internally read argument values for profiler/sample freq/duration. duration just gets stored in a pojo and subsequently ignored by PerfettoConfig.
Trying out StackSampling in a test benchmark I see that sampling frequency is extremely low, see attached screenshot. It's configured for 1khz, but it doesn't seem to be actually doing that
Stack sampling is strangely turned on for multiple processes (both test and target at least) - is that avoidable? we only want it for the target.
Sample trace:https://ui.perfetto.dev/#!/?s=e9db786bd486fe6c66e8803de9a3e0e55adc12cb