IssueTracker

General Description: We see a new error in zircon/system/ulib/zxtest/include/zxtest/cpp/scoped_trace.h, due to a virtual method inside a final class.

Error Message:

3864/171948](70) CXX host_x64/obj/zircon/system/ulib/fbl/test/fbl-test.confine_array_index_tests.cc.o
FAILED: [code=1] host_x64/obj/zircon/system/ulib/fbl/test/fbl-test.confine_array_index_tests.cc.o
../../prebuilt/third_party/clang/custom/bin/clang++ -MD -MF host_x64/obj/zircon/system/ulib/fbl/test/fbl-test.confine_array_index_tests.cc.o.d -DFBL_TEST_ENABLE_WAVL_TREE_BALANCE_TEST=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -DNDEBUG=1 -DRAPIDJSON_HAS_STDSTRING -DRAPIDJSON_HAS_CXX11_RANGE_FOR -DRAPIDJSON_HAS_CXX11_RVALUE_REFS -DRAPIDJSON_HAS_CXX11_TYPETRAI...
In file included from ../../zircon/system/ulib/fbl/test/confine_array_index_tests.cc:7:
In file included from ../../zircon/system/ulib/zxtest/include/zxtest/zxtest.h:19:
In file included from ../../zircon/system/ulib/zxtest/include/zxtest/cpp/zxtest.h:29:
../../zircon/system/ulib/zxtest/include/zxtest/cpp/scoped_trace.h:22:11: error: virtual method '~ScopedTrace' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
   22 |   virtual ~ScopedTrace() final { zxtest::Runner::GetInstance()->PopTrace(); }
      |           ^
1 error generated.

First Failing Bot: https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.arm64-release/b8718867796630328289/overview

Potential culprits:

• https://github.com/llvm/llvm-project/pull/133265

Seems like we need to fix instances of this in Fuchsia code.