Assigned
Status Update
No update yet.
Comments
ge...@google.com
Hi, thanks for reporting.
As a temporary workaround, you can probably:
- unregister your margin transformer
- register a MarginPageTransformer with an offset of 0
- viewpager2.requestTransform()
- viewpager2.adapter.notifyItemInserted()
- revert back to the original transformer
It should be indistinguishible from the user perspective when done while viewPager.getScrollState() == SCROLL_STATE_IDLE (at that stage, there is no visible offset).
If it's not there, OnPageChangeCallback will notify you once the viewpager changes to SCROLL_STATE_IDLE.
Alternatively, if you don't want the animation, a notifyDatasetChanged() should work fine. Especially if you're using Fragments, as they will be kept around.
Apologies for the extra steps. We'll look into it!
As a temporary workaround, you can probably:
- unregister your margin transformer
- register a MarginPageTransformer with an offset of 0
- viewpager2.requestTransform()
- viewpager2.adapter.notifyItemInserted()
- revert back to the original transformer
It should be indistinguishible from the user perspective when done while viewPager.getScrollState() == SCROLL_STATE_IDLE (at that stage, there is no visible offset).
If it's not there, OnPageChangeCallback will notify you once the viewpager changes to SCROLL_STATE_IDLE.
Alternatively, if you don't want the animation, a notifyDatasetChanged() should work fine. Especially if you're using Fragments, as they will be kept around.
Apologies for the extra steps. We'll look into it!
ma...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit f3df487541c41b9b0e81199a73eaeda058cab7a9
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Aug 01 22:20:00 2019
Fix for PageTransformer + dataSet animations clash
Suspends data-set change animations in the presence of a
PageTransformer.
Bug: 134658996
Test: ./gradlew viewpager2:connectedCheck
Change-Id: I873f7233a87b553ef6f410a76b35e6567bd4dc80
A viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageTransformerItemAnimatorTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java
https://android-review.googlesource.com/1095609
https://goto.google.com/android-sha1/f3df487541c41b9b0e81199a73eaeda058cab7a9
Branch: androidx-master-dev
commit f3df487541c41b9b0e81199a73eaeda058cab7a9
Author: Jakub Gielzak <jgielzak@google.com>
Date: Thu Aug 01 22:20:00 2019
Fix for PageTransformer + dataSet animations clash
Suspends data-set change animations in the presence of a
PageTransformer.
Bug: 134658996
Test: ./gradlew viewpager2:connectedCheck
Change-Id: I873f7233a87b553ef6f410a76b35e6567bd4dc80
A viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageTransformerItemAnimatorTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java
ma...@google.com
I'm assuming you meant to assign this to Rasha since she authored the CL you referenced in
ma...@google.com
Oops. I missed that Rasha is out. My mistake. Back to Adrian.
ap...@google.com
Project: fuchsia
Branch: main
Author: Adrian Danis <
Link:
[kernel][object] Correct lock order in koid search
Expand for full commit details
[kernel][object] Correct lock order in koid search
Corrects the DumpHandlesForKoid debugging method to avoid acquiring the
HandleTable lock while holding the JobDispatcher lock. This is done by
building a temporary linked list of RefPtrs, which is not very
efficient but this is only used for diagnostic dumping.
Bug: 407559899
Change-Id: Ib518e3868d64e529b4668db2b74ed3c6a30c2ef0
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1240984
Fuchsia-Auto-Submit: Adrian Danis <adanis@google.com>
Commit-Queue: Adrian Danis <adanis@google.com>
Reviewed-by: Carlos Pizano Uribe <cpu@google.com>
Files:
- M
zircon/kernel/object/diagnostics.cc
Hash: f51a76e791587e8fb7d4c0833d37be3f5c3bae6d
Date: Tue Apr 01 19:35:33 2025
Description
Originated on flake: