IssueTracker

I attached a repro project. This is the stacktrace printed from the Retrofit error (I included the keep rules for the Kodein issue):

java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType
        at retrofit2.HttpServiceMethod.parseAnnotations(HttpServiceMethod.java:365)
        at retrofit2.Retrofit.loadServiceMethod(Retrofit.java:4)
        at retrofit2.Retrofit$1.invoke(Retrofit.java:7)
        at java.lang.reflect.Proxy.invoke(Proxy.java:1006)
        at $Proxy1.getAllBreeds(Unknown Source)
        at com.example.api.DogBreedApiImpl.getAllBreeds(DogBreedApi.kt:5)
        at com.example.kodein7.MainActivity$onCreate$1.invokeSuspend(MainActivity.kt:5)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:3)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:18)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7660)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

R8 fullmode will remove all attributes for classes that are not kept. Attributes and annotations can only be read by reflection and for full mode we require an explicit keep rule to keep the signatures (and other attributes).

As you point to, adding keep rules for the types in kodein will force R8 to keep the signatures.

For retrofit, you will have to keep the api classes. Interestingly, you also have to keep the kotlin.coroutines.Continuation as well. Adding the below rules fixes the issue in the sample for me (note, you should refine the keep rule for the api to only keep what is needed).

-keep class com.example.api.** { *; }
-keep class kotlin.coroutines.Continuation

I will make a pull request on retrofit to add kotlin.coroutines.Continuation to the rules we consume.

Will R8 strip the signature even if I have -keepattributes Signature set in my rules?

If so, is there a rule that could be used to keep the signature just for the api classes?

Yes, R8 in full-mode will strip all signatures for not-kept classes if using -keepattributes Signature. The only way to keep the generic signature for a class is if you keep it.

Having a rule for only keeping certain attributes would actually be quite nice, sort of like:

-keep,Signature class com.example.api.* { *; }

would allow developers to more fine-grained describe what they would like to keep. It would break compatibility though.

We are btw removing all attributes for not kept classes, such as InnerClasses, EnclosingMethod etc.

I found that -keep, allowobfuscation, allowoptimization class com.example.api.**Endpoints { *; } fixes the issue (at least in the sample project).

Is this new behavior for 7.0.0 (or whatever version of R8 is used with it)? In AGP 4.2.0 this wasn't happening.

Maybe somewhat related, but it looks like consumerProguardFile isn't working on AGP 7.0.0-beta01. I tried adding these rules to the consumer-rules.pro file in their respective modules in my real project, and it didn't work unless I put it into my app module's proguard file.

The library gradle file (technically a buildSrc precompiled script) looks like:

plugins {
  id("com.android.library")
}

android {
  compileSdk = project.compileSdkVersion

  defaultConfig {
    consumerProguardFile(project.file("consumer-rules.pro"))

    minSdk = project.minSdkVersion

    testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
  }

  ...
}