[Merge M136] Add price drop and price tracking metrics for tab resumption [408303644]

Fixed

Bug

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Apr 4, 2025 12:26AM

This is an M136 merge request from crbug/407620667. The following changes were detected on the parent issue:

https://chromium-review.googlesource.com/c/chromium/src/+/6410179

To proceed with this merge request:

Please update the following custom fields on this issue:
- Code Changes - Change(s) to be merged. (Please add the full Gerrit URL of all trunk changes.)
- OS - OS(s) impacted by the change(s).
- Safe Merge - All change(s) meet Safe Merge Criteria (see below)
- Flag Name - Please provide the experiment flag name or leave blank if not applicable.
Please explain why this merge is needed.
When ready for review, assign this bug to merges@chromium.org

Safe Merge Criteria

Please only select Yes in the Safe Merge field if all the following apply:

Change(s) are guarded entirely behind a finch flag enabled at less than 5% in the Stable channel.
Change(s) have baked for 24 hours in Canary on all applicable OSs.
Change(s) have been verified in a live Canary against all applicable OSs.
Change(s) do not modify any strings that require translation. (.grd or .grdp files.)
Change(s) do not affect the implementation of WebView.

Please contact the milestone owner if you have questions.

Owners: andywu (ChromeOS), srinivassista (Desktop US), danielyip (Desktop EMEA), govind (Mobile US), eakpobaro (Mobile EMEA)

*Find more information on Chrome/Chromium's merge process at go/chrome-merge-process and Chromium Docs - Merge Request Process

Comments

da...@google.com <da...@google.com> Apr 4, 2025 12:30AM

Reassigned to me...@chromium.org.

ch...@google.com <ch...@google.com> #2Apr 4, 2025 12:35AM

Reassigned to da...@google.com.

We have passed this to the development team and will update this issue with more information as it becomes available.

ch...@google.com <ch...@google.com> #3Apr 7, 2025 12:42PM

I actually requested to have more for both collapsed and expanded, or customize it.
Even the "styles" settings don't show the current preview. See attached

We could have there (or somewhere else) a setting for the style of the quick-settings tiles, and how many to have in each state (collapsed/expanded).

The current ones (though have nicer description and no issues with texts) made the icons so small, almost as small as the status bar icons. It makes it longer to find what I want to press on because of this.
And of course because the items are larger, there are less being shown than it could be.
In expanded more, there are 8 even though there is space for more as it's in full screen.

go...@google.com <go...@google.com> #4Apr 7, 2025 06:22PM

Marked as fixed.

Also, when closing the expanded view you have to go back, you can't just swipe up to close expanded view anymore.

IssueTracker

This issue is a part of the Chromium tracker.