Bug P2
Status Update
No update yet.
Comments
ch...@appspot.gserviceaccount.com
Please attach a sample project that reproduces your issue.
ch...@appspot.gserviceaccount.com
ch...@appspot.gserviceaccount.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bd065925676170c8453321e970d455fac06b8d3d
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 28 15:47:16 2019
Add ProGuard rules for DrawerArrowDrawable.setProgress()
setProgress() is called via an ObjectAnimator and
therefore needs to be specifically kept when
obfuscating with ProGuard.
Test: tested in sample project attached to bug
Change-Id: I9c420ce728c5cb887d29df9f856bfd31f5bdbcdf
Fixes: 123449431
M navigation/ui/build.gradle
A navigation/ui/proguard-rules.pro
https://android-review.googlesource.com/887876
https://goto.google.com/android-sha1/bd065925676170c8453321e970d455fac06b8d3d
Branch: androidx-master-dev
commit bd065925676170c8453321e970d455fac06b8d3d
Author: Ian Lake <ilake@google.com>
Date: Mon Jan 28 15:47:16 2019
Add ProGuard rules for DrawerArrowDrawable.setProgress()
setProgress() is called via an ObjectAnimator and
therefore needs to be specifically kept when
obfuscating with ProGuard.
Test: tested in sample project attached to bug
Change-Id: I9c420ce728c5cb887d29df9f856bfd31f5bdbcdf
Fixes: 123449431
M navigation/ui/build.gradle
A navigation/ui/proguard-rules.pro
ch...@appspot.gserviceaccount.com
We've added the appropriate ProGuard configuration and it'll be available in the next release.
As a workaround, you can add the following to your ProGuard configuration:
-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
As a workaround, you can add the following to your ProGuard configuration:
-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
ch...@appspot.gserviceaccount.com
Sure, thanks for the quick fix.
ch...@appspot.gserviceaccount.com
I had to use the androidx version for proguard rules
-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}
Description
Internal (Googlers-only) Reports:
- Chromium:
(Legacy) Chromeperf Report:
Top 1 regressions (out of 1, with 0 improvements) in this group:
- ChromiumPerf/win-11-perf/blink_perf.dom/insert-text-with-dir-auto/insert-text-with-dir-auto.html
10.59%: 213.0843 -> 190.5187 unitless
Top 1 affected measurements in win-11-perf:
- blink_perf.dom/insert-text-with-dir-auto/insert-text-with-dir-auto.html
10.59%: 213.0843 -> 190.5187 unitless
Regressions grouped by blink_perf.dom includes data from the following benchmarks with listed owners:
blink_perf.dom: masonf@chromium.org
Commits in this range:
Chromium Commit Position:
V8 Commit Position:
WebRTC Git Hash: