Status Update
Comments
24...@project.gserviceaccount.com <24...@project.gserviceaccount.com> #2
24...@project.gserviceaccount.com <24...@project.gserviceaccount.com> #3
24...@project.gserviceaccount.com <24...@project.gserviceaccount.com> #4
Apologies for delay in addressing this, it ended up in a big list of redesign-related issues.
The search widget isn't actually part of the site we control (you'll find it's the same on several Google owned properties), I agree it's not great so I've raised it with the internal team.
I'll close this issue as we can't address it ourselves, but it's helpful to show this is being noticed externally.
dx...@google.com <dx...@google.com> #5
Project: angle/angle
Branch: main
Author: Yuly Novikov
Link:
Revert "GL: Allow untranslated shaders to pass through on GLES"
Expand for full commit details
This reverts commit 4e77552b86a89b449ada6d6c18f84285f5812b1d.
Reason for revert: breaks ChromeOS and fuzzers
Bug: angleproject:398857482
Original change's description:
> GL: Allow untranslated shaders to pass through on GLES
>
> Add an EGL extension EGL_ANGLE_create_context_passthrough_shaders which
> uses the NULL translator and passes the original shader to the driver.
> The parser is still used for shader reflection.
>
> Bug: angleproject:398857482
> Change-Id: I7c5fcc318c7e11931f78c08dcbf4764bf77d397d
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6297527
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Bug: angleproject:398857482, angleproject:410423936
Bug: chromium:410114655, chromium:410100607, chromium:410121218
Bug: chromium:410052365, chromium:410290507, chromium:410178288
No-Presubmit: true
Change-Id: I45b01960637a1cda05d21a7df6d07465f6a8f5e9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6448984
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Files:
- M
include/EGL/eglext_angle.h
- M
include/GLSLANG/ShaderLang.h
- M
include/platform/autogen/FrontendFeatures_autogen.h
- M
include/platform/frontend_features.json
- M
src/common/CompiledShaderState.cpp
- M
src/common/CompiledShaderState.h
- M
src/compiler/translator/CollectVariables.cpp
- M
src/compiler/translator/CollectVariables.h
- M
src/compiler/translator/Compiler.cpp
- M
src/compiler/translator/Compiler.h
- M
src/compiler/translator/HashNames.cpp
- M
src/compiler/translator/HashNames.h
- M
src/compiler/translator/Name.cpp
- M
src/compiler/translator/ShaderLang.cpp
- M
src/compiler/translator/glsl/OutputGLSLBase.cpp
- M
src/compiler/translator/glsl/OutputGLSLBase.h
- M
src/compiler/translator/msl/TranslatorMSL.cpp
- M
src/compiler/translator/msl/UtilsMSL.cpp
- M
src/compiler/translator/msl/UtilsMSL.h
- M
src/compiler/translator/util.cpp
- M
src/compiler/translator/util.h
- M
src/compiler/translator/wgsl/RewritePipelineVariables.cpp
- M
src/compiler/translator/wgsl/Utils.cpp
- M
src/libANGLE/Caps.cpp
- M
src/libANGLE/Caps.h
- M
src/libANGLE/Compiler.cpp
- M
src/libANGLE/Context.cpp
- M
src/libANGLE/Shader.cpp
- M
src/libANGLE/Shader.h
- M
src/libANGLE/State.cpp
- M
src/libANGLE/State.h
- M
src/libANGLE/capture/FrameCapture.cpp
- M
src/libANGLE/renderer/gl/DisplayGL.cpp
- M
src/libANGLE/renderer/gl/renderergl_utils.cpp
- M
src/libANGLE/renderer/metal/mtl_msl_utils.mm
- M
src/libANGLE/validationEGL.cpp
- M
src/tests/angle_end2end_tests.gni
- D
src/tests/egl_tests/EGLContextPassthroughShadersTest.cpp
- M
src/tests/gl_tests/LineLoopTest.cpp
- M
src/tests/gl_tests/TextureTest.cpp
- M
util/autogen/angle_features_autogen.cpp
- M
util/autogen/angle_features_autogen.h
Hash: 5dd0557841fcd4ce50f62def65e204526b6cf08b
Date: Mon Apr 14 14:34:57 2025
dx...@google.com <dx...@google.com> #6
Project: chromium/src
Branch: main
Author: chromium-autoroll
Link:
Roll ANGLE from d5ab13318ad6 to a5d750fb72b3 (7 revisions)
Expand for full commit details
https://chromium.googlesource.com/angle/angle.git/+log/d5ab13318ad6..a5d750fb72b3
2025-04-14 yuxiang.qian@arm.com Add test to check EGL_KHR_platform_android
2025-04-14 ynovikov@chromium.org Revert "GL: Allow untranslated shaders to pass through on GLES"
2025-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 75621a1b9953 to 95d3d27a122a (1865 revisions)
2025-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5ec40ef70a52 to a24af46b3d3b (14 revisions)
2025-04-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from ad6225aacbc5 to 76c1572eaba4 (12 revisions)
2025-04-11 lexa.knyazev@gmail.com Fix GL_OES_texture_3D entry points validation
2025-04-11 geofflang@chromium.org GL: Allow untranslated shaders to pass through on GLES
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:410052365,chromium:410100607,chromium:410114655,chromium:410121218,chromium:410178288,chromium:410290507
Tbr: yuxinhu@google.com
Change-Id: I2804235c0e931d2847cf07544784bddfde407620
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6454836
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1446696}
Files:
- M
DEPS
- M
third_party/angle
Hash: 0d2e6e5af279941c6c1be296179167e25a80668b
Date: Mon Apr 14 19:18:48 2025
24...@project.gserviceaccount.com <24...@project.gserviceaccount.com> #7
If this is incorrect, please add the hotlistid:5433040 and re-open the issue.
Description
Fuzzing Engine: libFuzzer
Fuzz Target: angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux
Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
sh::ContainsReturnOrDiscard
sh::RunAtTheEndOfShader
sh::AddXfbEmulationSupport
Sanitizer: address (ASAN)
Regressed:
Reproducer Testcase:
Issue filed automatically.
See