IssueTracker

since these are in public API (:/) we need to do this in 1.2

Opening diff shortly

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date:   Tue Aug 11 09:30:34 2020

    [GH] Hide deprecated internal API.
   
    ## Proposed Changes
   
    * `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
   
    ## Testing
   
    Test: Ran unit tests locally
   
    ## Issues Fixed
   
    Fixes: 76109329
   
    This is an imported pull request from https://github.com/androidx/androidx/pull/61.
   
    Resolves #61
    Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
    GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
   
    Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A       room/runtime/api/current.ignore
M       room/runtime/api/current.txt
M       room/runtime/api/public_plus_experimental_current.txt
M       room/runtime/api/restricted_current.txt
M       room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

I have faced a similar OOM error when building my project.
I looked into the heap dump using the Eclipse Memory Analyzer, and several URLClassLoaders ate many memory (about 25%).

Please run './gradlew clean assemble' about 10 times with the attached project and try hprof.
You can see that many URLClassLoaders are not released.

I reproduced OOM with android-architecture-components/BasicSample.
https://github.com/googlesamples/android-architecture-components

1. Clone https://github.com/googlesamples/android-architecture-components
2. Edit BasicSample/build.gradle to change archLifecycleVersion and archRoomVersion to 1.0.0-alpha3.
3. Run ./gradlew clean assembleDebug many times.
-----
$ cd BasicSample
$ while true; do echo "-----"; ./gradlew clean assembleDebug > /dev/null || break; done
-----

#6, #7; can you share your java versions ?

I've updated the project in #6 to gradle 4.1, android gradle plugin 3.0.0-beta4 and arch components alpha-9) Then i did run the following command w/o a problem:
for ((n=0;n<200;n++)); do gw clean && gw assemble; done

I'm unable to reproduce this but we are seeing some other apps being affected as well, trying to figure out what triggers it.

can you share the output of:
java -version from command line.

thanks.

$ java -version
openjdk version "1.8.0_131"
OpenJDK Runtime Environment (build 1.8.0_131-8u131-b11-2ubuntu1.17.04.3-b11)
OpenJDK 64-Bit Server VM (build 25.131-b11, mixed mode)

ok, seems like we ARE still leaking these. Looks like we fixed leaking the giant object, which prevents us from seeing this issue most of the time. And if app's class loader grows big for whatever reason, it becomes noticeable.

seems like this issue is related:
https://github.com/xerial/sqlite-jdbc/issues/267

will see if we can find a workaround :/. A potential solution might be to use a single connection but that might have too many hard to discover side effects.

I've tried a patch for the https://github.com/xerial/sqlite-jdbc/issues/267 and it fixes the problem (along w/ new code in Room to force unregister the driver).

Our options seems to be either wait for a xerial update or ship w/ a custom version.
If we go w/ a custom version, any other processor that uses xerial will have a problem.
We can jarjar to workaround it but need to make sure all references from native code to xerial are properly rewritten, which makes it an even more riskier change.

we are waiting for a new release on xerial to fix this.
if this is blocking you, please star that bug to increase its priority for Xerial developer.

there is a new xerial version available that includes the fix CL.
next version of room will depend on it.

Great! Any idea when? I have to force-kill the process every few builds right now unless I want to wait for 20 minutes till it OOM's.

probably next week.
you can try to add `org.xerial:sqlite-jdbc:3.20.1` to your annotationProcessor configuration to override the version, it will help some but we also needed to change Room to properly take advantage of the new version so proper fix will be only when we ship.

change is merged, will be fixed in next release.

I tested the bug fix and the issue is still around but happens fewer times.

#17: As #3 said above, DataBinding also have OOM problem. Did you use DataBinding?

Yes, but I'm using the latest version (gradle 3.0.0) and I still have this issue.