Fixed
Status Update
Comments
e....@gmail.com <e....@gmail.com> #2
[Empty comment from Monorail migration]
e....@gmail.com <e....@gmail.com> #3
[Empty comment from Monorail migration]
e....@gmail.com <e....@gmail.com> #4
Hey Paul, can you give input on how important this is?
e....@gmail.com <e....@gmail.com> #5
Doesn't this already exist? Or is this different from the manifest property?
e....@gmail.com <e....@gmail.com> #6
waiting on additional feedback.
mi...@gmail.com <mi...@gmail.com> #7
GitHub issue:
https://github.com/w3c/manifest/issues/737
Discussion doc (Google only):
https://docs.google.com/document/d/1wchuU6uZAt10LYYL4U0GmI4lndwdkoMdvXKLiZkJ5Aw/edit
#4:
> Doesn't this already exist? Or is this different from the manifest property?
There's been some confusion because this feature keeps being labeled as "display: browser", which does already exist and has a separate meaning (specifically, that the app is opened in a regular browser tab).
This feature is about having a standalone app window with multiple tabs (containing separate documents inside the app scope) inside it.
Regardless of how we design this, the name of the feature proposal should not be named after a proposed solution, since that unnecessarily pigeonholes us into a particular solution.
[Monorail components: UI>Browser>WebAppInstalls]
Discussion doc (Google only):
#4:
> Doesn't this already exist? Or is this different from the manifest property?
There's been some confusion because this feature keeps being labeled as "display: browser", which does already exist and has a separate meaning (specifically, that the app is opened in a regular browser tab).
This feature is about having a standalone app window with multiple tabs (containing separate documents inside the app scope) inside it.
Regardless of how we design this, the name of the feature proposal should not be named after a proposed solution, since that unnecessarily pigeonholes us into a particular solution.
[Monorail components: UI>Browser>WebAppInstalls]
al...@google.com <al...@google.com> #8
[Empty comment from Monorail migration]
mr...@gmail.com <mr...@gmail.com> #9
[Empty comment from Monorail migration]
e....@gmail.com <e....@gmail.com> #10
[Empty comment from Monorail migration]
e....@gmail.com <e....@gmail.com> #11
[Empty comment from Monorail migration]
[Deleted User] <[Deleted User]> #12
[Empty comment from Monorail migration]
an...@gmail.com <an...@gmail.com> #13
[Description Changed]
e....@gmail.com <e....@gmail.com> #14
[Empty comment from Monorail migration]
ma...@marcardar.com <ma...@marcardar.com> #15
[Empty comment from Monorail migration]
ma...@marcardar.com <ma...@marcardar.com> #16
Removing old assignments that no longer represent what is being worked on. Our team's milestone based bug fix process will keep an eye on the WebAppInstall bugs and get them reassigned based on priorities.
ma...@marcardar.com <ma...@marcardar.com> #17
[Empty comment from Monorail migration]
e....@gmail.com <e....@gmail.com> #18
can you help triage?
al...@google.com <al...@google.com>
[Deleted User] <[Deleted User]> #19
[Empty comment from Monorail migration]
ma...@marcardar.com <ma...@marcardar.com> #20
[Empty comment from Monorail migration]
ro...@gmail.com <ro...@gmail.com> #21
add estimates.
ar...@gmail.com <ar...@gmail.com> #22
[Empty comment from Monorail migration]
ju...@gmail.com <ju...@gmail.com> #23
[Empty comment from Monorail migration]
ki...@google.com <ki...@google.com> #24
[Empty comment from Monorail migration]
jo...@gmail.com <jo...@gmail.com> #25
[Empty comment from Monorail migration]
sz...@gmail.com <sz...@gmail.com> #26
Modernizing label usage.
e....@gmail.com <e....@gmail.com> #27
Updating ownership and status - please fix if incorrect!
ta...@gmail.com <ta...@gmail.com> #28
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/6a70ccafc5410a3399468affe71f275abfe00296
commit 6a70ccafc5410a3399468affe71f275abfe00296
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Mar 05 23:05:48 2020
Remove kDesktopPWAsWithoutExtensions flag check in AppServiceContextMenu
The kWeb branch in AppServiceContextMenu::IsCommandIdChecked() is
capable of handling web apps that run using BMO or Extensions as the
backend. This CL removes the flag check and fallthrough behaviour.
Bug: 897314
Change-Id: I530988629aa92e13d3cac9ccb8bcd500c1e7f7c1
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2087247
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747462}
[modify]https://crrev.com/6a70ccafc5410a3399468affe71f275abfe00296/chrome/browser/ui/app_list/app_service/app_service_context_menu.cc
commit 6a70ccafc5410a3399468affe71f275abfe00296
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Mar 05 23:05:48 2020
Remove kDesktopPWAsWithoutExtensions flag check in AppServiceContextMenu
The kWeb branch in AppServiceContextMenu::IsCommandIdChecked() is
capable of handling web apps that run using BMO or Extensions as the
backend. This CL removes the flag check and fallthrough behaviour.
Bug: 897314
Change-Id: I530988629aa92e13d3cac9ccb8bcd500c1e7f7c1
Reviewed-on:
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747462}
[modify]
ta...@gmail.com <ta...@gmail.com> #30
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/758d885f8658dea2c18568d64e0814de5ab28792
commit 758d885f8658dea2c18568d64e0814de5ab28792
Author: Alan Cutter <alancutter@chromium.org>
Date: Mon Mar 09 07:01:44 2020
desktop-pwas: Add experimental "open in tabbed window" option behind flag
This is part of an experimental implementation of tabbed web app windows
hidden behind the DesktopPWAsTabStrip flag.
This CL adds a UI option for Chrome OS that lets users assign individual
web apps to be opened in the experimental tabbed window.
Because this option is experimental and users may turn the flag off at
any time we do not store this setting in the same place as the launch
container setting. Instead we store it in a per web app
"experimental_tabbed_window_mode" pref.
Screencast:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=436695&signed_aid=pNFo1z1fXrwGgoTkDSgTXA==&inline=1
Bug: 897314
Change-Id: Ie0a9417e38fd0cfc593d93b5b97224742b37d841
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2086465
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748126}
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/ash/app_list/app_list_metrics.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/ash/public/cpp/app_menu_constants.h
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/app/generated_resources.grd
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/apps/app_service/menu_util.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/app_list/app_service/app_service_context_menu.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/ash/launcher/app_service/app_service_shelf_context_menu.cc
[add]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/ash/launcher/app_service/app_service_shelf_context_menu_browsertest.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/ui/web_applications/app_browser_controller.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/app_registrar.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/app_registrar.h
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/app_registry_controller.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/app_registry_controller.h
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/web_app_constants.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/web_app_prefs_utils.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/components/web_app_prefs_utils.h
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/extensions/bookmark_app_registry_controller.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/browser/web_applications/web_app_sync_bridge.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/common/chrome_features.cc
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/chrome/test/BUILD.gn
[modify]https://crrev.com/758d885f8658dea2c18568d64e0814de5ab28792/tools/metrics/histograms/enums.xml
commit 758d885f8658dea2c18568d64e0814de5ab28792
Author: Alan Cutter <alancutter@chromium.org>
Date: Mon Mar 09 07:01:44 2020
desktop-pwas: Add experimental "open in tabbed window" option behind flag
This is part of an experimental implementation of tabbed web app windows
hidden behind the DesktopPWAsTabStrip flag.
This CL adds a UI option for Chrome OS that lets users assign individual
web apps to be opened in the experimental tabbed window.
Because this option is experimental and users may turn the flag off at
any time we do not store this setting in the same place as the launch
container setting. Instead we store it in a per web app
"experimental_tabbed_window_mode" pref.
Screencast:
Bug: 897314
Change-Id: Ie0a9417e38fd0cfc593d93b5b97224742b37d841
Reviewed-on:
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748126}
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[add]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
[modify]
ki...@google.com <ki...@google.com> #31
[Empty comment from Monorail migration]
st...@speakap.nl <st...@speakap.nl> #32
[Empty comment from Monorail migration]
gi...@inevent.com <gi...@inevent.com> #33
Updating DevTrial milestone
gi...@inevent.com <gi...@inevent.com> #34
[Empty comment from Monorail migration]
ki...@google.com <ki...@google.com> #35
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/133a4b151f4f6453b5a848f2b6ae0a01d02e2789
commit 133a4b151f4f6453b5a848f2b6ae0a01d02e2789
Author: Alan Cutter <alancutter@chromium.org>
Date: Mon Mar 30 04:47:40 2020
desktop-pwas: Move DCHECK for kDesktopPWAsTabStrip
This CL updates a DCHECK for kDesktopPWAsTabStrip being enabled to only
occur if we're updating an app to use the experimental tabbed mode.
Previously it was possible to hit this DCHECK when the experiment is
disabled and the user is setting the window mode to something other than
tabbed mode.
Bug: 897314
Change-Id: Ie1bc99cf9967d45c4f9f3048ff8bf88025ed34d8
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/2126334
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754394}
[modify]https://crrev.com/133a4b151f4f6453b5a848f2b6ae0a01d02e2789/chrome/browser/web_applications/components/app_registry_controller.cc
commit 133a4b151f4f6453b5a848f2b6ae0a01d02e2789
Author: Alan Cutter <alancutter@chromium.org>
Date: Mon Mar 30 04:47:40 2020
desktop-pwas: Move DCHECK for kDesktopPWAsTabStrip
This CL updates a DCHECK for kDesktopPWAsTabStrip being enabled to only
occur if we're updating an app to use the experimental tabbed mode.
Previously it was possible to hit this DCHECK when the experiment is
disabled and the user is setting the window mode to something other than
tabbed mode.
Bug: 897314
Change-Id: Ie1bc99cf9967d45c4f9f3048ff8bf88025ed34d8
Reviewed-on:
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754394}
[modify]
md...@gmail.com <md...@gmail.com> #36
[Empty comment from Monorail migration]
Description
Version used: 25.4.0
Theme used: Theme.AppCompat.Light.DarkActionBar
Devices/Android versions reproduced on: Samsung Galaxy S5 4.4.2
Issue background:
Samsung API 19 devices are known for this. I you override View class method with parameter of type that doesn't exist on API 19 it will crash. WindowInsets is a prime example. That's why we have WindowInsetsCompat and a listener hooked *into a platform listener*.
Guide for solution:
Wherever the someMethod(Icon) is declared it should be someMethod(IconCompat) where IconCompat wraps an Object that's cast to Icon at runtime.
Full stack trace:
Fatal Exception: java.lang.NoClassDefFoundError: android/graphics/drawable/Icon
at java.lang.Class.getDeclaredMethods(Class.java)
at java.lang.Class.getDeclaredMethods(Class.java:656)
at android.view.ViewDebug.getExportedPropertyMethods(ViewDebug.java:960)
at android.view.ViewDebug.exportMethods(ViewDebug.java:1047)
at android.view.ViewDebug.dumpViewProperties(ViewDebug.java:997)
at android.view.ViewDebug.dumpViewProperties(ViewDebug.java:983)
at android.view.ViewDebug.dumpView(ViewDebug.java:900)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:870)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dump(ViewDebug.java:793)
at android.view.ViewDebug.dispatchCommand(ViewDebug.java:416)
at android.view.ViewRootImpl$W.executeCommand(ViewRootImpl.java:6258)
at android.view.IWindow$Stub.onTransact(IWindow.java:65)
at android.os.Binder.execTransact(Binder.java:404)
at dalvik.system.NativeStart.run(NativeStart.java)
Caused by java.lang.ClassNotFoundException: Didn't find class "android.graphics.drawable.Icon" on path: DexPathList[[zip file "/data/app/cz.quickjobs.midgard-1.apk"],nativeLibraryDirectories=[/data/app-lib/cz.quickjobs.midgard-1, /vendor/lib, /system/lib]]
at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
at java.lang.ClassLoader.loadClass(ClassLoader.java:497)
at java.lang.ClassLoader.loadClass(ClassLoader.java:457)
at java.lang.Class.getDeclaredMethods(Class.java)
at java.lang.Class.getDeclaredMethods(Class.java:656)
at android.view.ViewDebug.getExportedPropertyMethods(ViewDebug.java:960)
at android.view.ViewDebug.exportMethods(ViewDebug.java:1047)
at android.view.ViewDebug.dumpViewProperties(ViewDebug.java:997)
at android.view.ViewDebug.dumpViewProperties(ViewDebug.java:983)
at android.view.ViewDebug.dumpView(ViewDebug.java:900)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:870)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dumpViewHierarchy(ViewDebug.java:867)
at android.view.ViewDebug.dump(ViewDebug.java:793)
at android.view.ViewDebug.dispatchCommand(ViewDebug.java:416)
at android.view.ViewRootImpl$W.executeCommand(ViewRootImpl.java:6258)
at android.view.IWindow$Stub.onTransact(IWindow.java:65)
at android.os.Binder.execTransact(Binder.java:404)
at dalvik.system.NativeStart.run(NativeStart.java)