Crash When Opening DialogFragment with TargetFragment SupportLibrary 26.0.1 [64658401]

Duplicate

of 62974813

Bug

[AOSP] assigned

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 14, 2017 06:54AM

Here is how I am opening the dialog fragment
LinkInsertDialogFragment linkInsertDialogFragment = LinkInsertDialogFragment.newInstance();
linkInsertDialogFragment.setTargetFragment(EditNoteFragment.this,LinkInsertDialogFragment.LINK_INSERT_CODE);
linkInsertDialogFragment.show(getChildFragmentManager());

Crash does not happen when I down grade to Support Library 25.4.0

java.lang.IllegalStateException: Fragment LinkInsertDialogFragment{2755fa2c #0 com.test.test.fragments.LinkInsertDialogFragment} declared target fragment EditNoteFragment{1dd10ccd #4 id=0x7f0f00b7 com.test.test.fragments.note.EditNoteFragment} that does not belong to this FragmentManager!
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1352)
at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1740)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1809)
at android.support.v4.app.BackStackRecord.executeOps(BackStackRecord.java:799)
at android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2580)
at android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2367)
at android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2322)
at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2229)
at android.support.v4.app.FragmentManagerImpl$1.run(FragmentManager.java:700)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5343)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:905)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:700)

Comments

ar...@google.com <ar...@google.com> #2Aug 17, 2017 01:23PM

Assigned to ar...@google.com.

Can you please provide the below requested information to better understand the issue:

Steps to reproduce
Please provide source code or apk of a sample application to reproduce the issue.
Also kindly mention the steps to be followed for reproducing the issue with the given sample application.

Frequency
How frequently does this issue occur? (e.g 100% of the time, 10% of the time)

Expected output
Could you please explain the expected behavior.

Current output
Could you please explain the current behavior.

[Deleted User] <[Deleted User]> #3Aug 18, 2017 05:19AM

Steps to reproduce
1. Open Dialog Fragment Like below code with setting Target Fragment.

LinkInsertDialogFragment linkInsertDialogFragment = LinkInsertDialogFragment.newInstance();
linkInsertDialogFragment.setTargetFragment(EditNoteFragment.this,1245);
linkInsertDialogFragment.show(getChildFragmentManager());

2. Execute this code.
Frequency
100%

Expected output
The exception mentioned in above reply should not happen in support library 26.0.0 and 26.0.1 as it does not happen the previous version of support library 25.4.0.

Current output
it throws an exception and application crash.

java.lang.IllegalStateException: Fragment LinkInsertDialogFragment{2755fa2c #0 com.test.test.fragments.LinkInsertDialogFragment} declared target fragment EditNoteFragment{1dd10ccd #4 id=0x7f0f00b7 com.test.test.fragments.note.EditNoteFragment} that does not belong to this FragmentManager!

Thanks.

ar...@google.com <ar...@google.com> #4Aug 18, 2017 10:36AM

We are not able to reproduce the issue with the sample code given in

comment #3

.

Please provide an sample project or apk as requested in

comment #2

[Deleted User] <[Deleted User]> #5Aug 18, 2017 10:48AM

here is another example of same thing

https://stackoverflow.com/questions/44203982/why-is-android-o-failing-with-does-not-belong-to-this-fragmentmanager

where someone has posted a workaround to solve it.

[Deleted User] <[Deleted User]> #6Aug 18, 2017 12:04PM

Here is sample project which reproduces it.

1. Click the button within fragment which opens a dialog fragment
2. It will crash for Support Library 26.0.1 and same code working fine in 25.4.0

SupportLibBug.zip

1.5 MB

Download

wx...@gmail.com <wx...@gmail.com> #7Aug 21, 2017 03:09AM

Hi,
I have encountered exactly the same issue here, using getFragmentManager() instead of getChildFragmentManager() can in some case be a workaround. Hope this can be fixed quick.

Thanks.

ar...@google.com <ar...@google.com> #8Aug 21, 2017 10:08AM

We have passed this defect on to the engineering team and will update this issue with more information as it becomes available.

yt...@gmail.com <yt...@gmail.com> #9Aug 24, 2017 03:31AM

This was marked as "working as intended" on

https://issuetracker.google.com/issues/62974813, right?
Solution is very straightforward, use same fragment manager, getFragmentManager instead of getChildFragmentManager in simple case.

But I think this is very important as P2 or above! All devs should check their code.

[Deleted User] <[Deleted User]> #10Sep 8, 2017 10:58AM

We're also running into this crash now. This appears to be a change with Support Library version 26.0.0. Can this be added to the Support Library Release Notes Page for that version?

https://developer.android.com/topic/libraries/support-library/revisions.html

I agree with the previous comment - this needs visibility. Developers need to know to re-test this code. And if developers start running into this crash, it's currently not easy to track down what change specifically would have introduced the crash.

The correct solution can also be difficult to work out, but I don't think there can be a canonical answer aside from "make sure you understand which fragment manager you're using for everything and then do the right thing for your case." :)

ja...@gmail.com <ja...@gmail.com> #11Oct 29, 2017 10:34PM

I too confirm this problem with API >=26 or with android support libs >= 26

mi...@gmail.com <mi...@gmail.com> #12Nov 12, 2017 02:03PM

This bug totally blocks upgrading.
The only way to upgrade is to throw away these buggy fragments and use Conductor, Flow, etc.

is...@google.com <is...@google.com> Oct 5, 2018 07:06AM

Status: New

il...@google.com <il...@google.com> #13Jan 3, 2019 09:14PM

Status: Duplicate of

62974813

This is indeed the same issue as

https://issuetracker.google.com/issues/62974813 - the target Fragment must be from the same FragmentManager as the Fragment is added, so you must use getFragmentManager() and not getChildFragmentManager() if you want to use setTargetFragment().

Alternatively, use getChildFragmentManager() and getParentFragment().