Option to disable System Image patcher [67816403]

Fixed

Feature Request

[AOSP] Linux

Status Update

No update yet.

Description

ta...@gmail.com

created issue #1

Oct 15, 2017 09:03PM

On a very slow internet connection, it is very hard to download >1GB system images. That's why the new patcher helps a lot.

But when we have a fast internet connection, patcher is always slower. In fact for me, downloading 1GB takes ~1 minute and total install time would be ~2 minutes. But the patcher takes around 10-15 minutes on my slow computer.

What's worse is that the download operation can be done in background while the patching must be done in foreground. This means that now when I need to upgrade my images I need to make break for 15 minutes. This is much worse than my older experience.

Please allow us to choose.

Comments

ta...@gmail.com <ta...@gmail.com> #2Oct 15, 2017 09:10PM

Actually it took 20 minutes.

uc...@google.com <uc...@google.com> #3Oct 16, 2017 10:36PM

Assigned to tn...@google.com.

Thank you for suggesting this enhancement. We value the feedback from our community and hope to review your suggestion in an upcoming sprint.

rp...@google.com <rp...@google.com> Oct 26, 2017 11:48PM

Reassigned to jb...@google.com.

yo...@gmail.com <yo...@gmail.com> #4Apr 18, 2018 06:57PM

Google should benchmark every individual patch on a lower end hardware, if applying the patch takes more than some threshold (e.g. 30 secs), then Google should not even offer the patch and just use full download.

ad...@google.com <ad...@google.com> Sep 12, 2018 09:29PM

Reassigned to ad...@google.com.

ad...@google.com <ad...@google.com> Nov 9, 2018 06:49PM

Accepted by ad...@google.com.

ad...@google.com <ad...@google.com> #5Nov 21, 2018 07:05PM

Pending ag/5581779 & the relevant topic.

ad...@google.com <ad...@google.com> #6Nov 21, 2018 07:44PM

Can you please also specify what is your host OS, and whether you update an already installed but out-of-date system image, you are talking about the case when a system image is installed from scratch?

ta...@gmail.com <ta...@gmail.com> #7Nov 21, 2018 07:47PM

Hi, I use MacOS. This is not a fresh install from scratch. Since there is no patching in that case, it is pretty fast.
Patching is slow when I have an update on any of the system images.

ad...@google.com <ad...@google.com> #8Dec 3, 2018 02:55PM

Marked as fixed.

This has been added on 3.4. In SDK manager, on "SDK Update Sites" tab, there is now a new option called "Disable SDK diff pacthing". If the checkbox is selected, all SDK updates will be performed via full downloads, thus optimizing for local execution time (because there will be no patch to apply) but potentially increasing the download size in a noticeable way. This is recommended only for lower end hardware where applying patch takes longer. This option is not selected by default, as patching still remains the preferred method.

ad...@google.com <ad...@google.com> #9Dec 3, 2018 02:56PM

(internal ref: ag/5581779 & ag/5581819; merged to master today and should be available in the next canary)

ta...@gmail.com <ta...@gmail.com> #10Dec 3, 2018 05:13PM

Thanks a lot.