IssueTracker

Right now we use AppInfoWithLiveness.lookup, which will do a single target lookup. This means that the assumenosideeffects rule will only be applied for invokes which has a single target. That still might not be the precise target mentioned in the rule.

comment #1 suggested more limited application of -assumenosideeffects, like, if there are multiple call targets, check if all of them have bound -assumenosideeffects rules.

comment #2 worried that, we only applied the rule to the invocation that has only one single target, but the rule may want to specify more (probably, e.g., all methods that override the method of interest). Public issue 130804193 (and reproduction go/r8g/37283) indicate that user expectation is comment #2, rather than comment #1.

Project: r8
Branch: master

commit 88f57ee620305d546ab5efe8ce2a03d2e2028762
Author: Jinseong Jeon <jsjeon@google.com>
Date:   Thu Apr 25 09:26:32 2019

    Add tests for assumenosideeffects with multiple targets.
   
    Bug: 130804193, 70550443
    Change-Id: I62110c3b67047f3e9974aa20735d8bb669ce4ca6

M       src/main/java/com/android/tools/r8/ir/optimize/MemberValuePropagation.java
A       src/test/java/com/android/tools/r8/shaking/assumenosideeffects/AssumenosideeffectsWithMultipleTargetsTest.java

https://r8-review.googlesource.com/37283