Removed jars in Desugar classpath [72313724]

Verified

Bug

Status Update

No update yet.

Description

wk...@google.com

created issue #1

Jan 22, 2018 05:32PM

The first build after updating the Google Play Services SDK version fails in a project with Java 8 features enabled. Running the build again fixes it.

Android Studio 3.1 Canary 8
Build #AI-173.4529993, built on January 6, 2018
JRE: 1.8.0_152-release-1024-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.9.0-5-amd64

Steps to Reproduce:
1. Start a new, empty (from templates) project.
2. Enable Java 8 desugaring:
compileOptions {
targetCompatibility 1.8
sourceCompatibility 1.8
}

3. Add the line to dependencies:
compile 'com.google.android.gms:play-services-base:11.6.2'
4. Build APK
5. Change the Play Services version to 'com.google.android.gms:play-services-base:11.8.0'
6. Build APK and observe crash:

:app:transformClassesWithStackFramesFixerForDebug
Error parsing command line: While parsing option --classpath_entry /usr/local/google/home/wkal/StudioProjects/search-samples/recipe-app-start/app/build/intermediates/transforms/stackFramesFixer/debug/42.jar: /usr/local/google/home/wkal/StudioProjects/search-samples/recipe-app-start/app/build/intermediates/transforms/stackFramesFixer/debug/42.jar is not a valid path: it does not exist.
Try --help.

Error parsing command line: While parsing option --classpath_entry /usr/local/google/home/wkal/StudioProjects/search-samples/recipe-app-start/app/build/intermediates/transforms/stackFramesFixer/debug/42.jar: /usr/local/google/home/wkal/StudioProjects/search-samples/recipe-app-start/app/build/intermediates/transforms/stackFramesFixer/debug/42.jar is not a valid path: it does not exist.
Try --help.

Error parsing command line: While parsing option --classpath_entry /usr/local/google/home/wkal/StudioProjects/search-samples/recipe-app-start/app/build/intermediates/transforms/stackFramesFixer/debug/42.jar: /usr/local/google/home/wkal/StudioProjects/search-samples/recipe-app-start/app/build/intermediates/transforms/stackFramesFixer/debug/42.jar is not a valid path: it does not exist.
Try --help.

Error parsing command line: While parsing option --classpath_entry /usr/local/google/home/wkal/StudioProjects/search-samples/recipe-app-start/app/build/intermediates/transforms/stackFramesFixer/debug/42.jar: /usr/local/google/home/wkal/StudioProjects/search-samples/recipe-app-start/app/build/intermediates/transforms/stackFramesFixer/debug/42.jar is not a valid path: it does not exist.
Try --help.

:app:transformClassesWithDesugarForDebug FAILED

7. Build APK again without any changes - the project builds.
8. Going from version 11.8.0 back to 11.6.2 breaks again, then works on subsequent builds.

Comments

az...@lyft.com <az...@lyft.com> #2Jan 31, 2018 09:20PM

We're seeing this problem a lot after `git pull` and similar updates in the codebase when you already have cache from previous builds, it doesn't seem related to Google Play Services at all.

It only fails for application modules in our project.

gradle clean for failed module helps, but obviously not a great solution.

Environment:

- AGP 3.1.0-alpha09
- Source target 8
- Gradle 4.5

az...@lyft.com <az...@lyft.com> #3Feb 14, 2018 12:42AM

Hi team, can we escalate this please?

Just reproduced again on AGP-3.2.0-alpha02, happened on non-clean build when I updated Google Play Services in our project from 10.2.6 to 11.8.0 (I was seeing it before with just updates in the codebase, but now updating Google Play Services triggered it).

Running gradle with --stacktrace gives following helpful info pointing to the problem (same as original error reporter pointed though):

```
Error parsing command line: While parsing option --classpath_entry /app/build/intermediates/transforms/stackFramesFixer/dev/debug/19.jar: /app/build/intermediates/transforms/stackFramesFixer/dev/debug/19.jar is not a valid path: it does not exist.
Try --help.
```

Notes:

- `--classpath_entry /app/build/intermediates/transforms/stackFramesFixer/dev/debug/19.jar` is indeed logged as parameter passed to `com.google.devtools.build.android.desugar.Desugar`
- File `/app/build/intermediates/transforms/stackFramesFixer/dev/debug/19.jar` indeed does not exist
- The error about 19.jar is logged 15 times which is strange, might be related to amount of CPU cores I have (16), might be coinsedense

It blocks our migration from Buck to Gradle as main dev build system because it breaks incremental builds sometimes :(

Kind regards,
Artem.

wk...@google.com <wk...@google.com> #4Feb 14, 2018 11:56AM

Artem: escalated to the team via email, thanks for bumping this

ga...@google.com <ga...@google.com> Feb 15, 2018 12:14AM

Assigned to ga...@google.com.

ga...@google.com <ga...@google.com> #5Feb 15, 2018 11:26PM

Issue will happen whenever non-existing jar is passed to Desugar. It will never be in the input, but it might end up in the classpath. When calculating the classpath, we do not remove the deleted files.

ga...@google.com <ga...@google.com> #6Feb 16, 2018 10:04PM

Marked as fixed.

Fixed in ag/Ibb74076f967f5c6d2e05d81e98f2ec75a582aad6.

az...@lyft.com <az...@lyft.com> #7Feb 16, 2018 11:51PM

UWESOME!

Thanks Ivan!

yu...@google.com <yu...@google.com> #8Feb 23, 2018 07:42PM

Verified by yu...@google.com.

Verified in:

Android Studio 3.1 RC 1
Build #AI-173.4617476, built on February 22, 2018
JRE: 1.8.0_152-release-1024-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.9.0-5-amd64

az...@lyft.com <az...@lyft.com> #9Feb 23, 2018 09:22PM

#8

But what version of Android Gradle Plugin was used? That's most interesting part (as well as desugar version)

Thanks!

yu...@google.com <yu...@google.com> #10Feb 23, 2018 11:33PM

This should be fixed in the next release of Android Studio. Current available in beta channel is 3.1 Beta 4.