Google logo in GMSPanoramaView positioned incorrectly on iPhone X [72581496]

Fixed

Bug

Status Update

No update yet.

Description

fu...@gmail.com

created issue #1

Jan 30, 2018 02:12PM

What is the incorrect behavior that you are experiencing?

In comparison to GMSMapView, the Google logo in GMSPanoramaView is shifted to the top:
On iPhone X in portrait orientation, the Google logo is shifted 66 pt to the top.
On iPhone X in landscape orientation, the Google logo is shifted 32 pt to the top.

What should happen instead?

The Google logo should be at the same position as in GMSMapView.

Steps to reproduce the problem:
1. Build a demo app with a full-screen GMSPanoramaView
2. Test on iPhone X

Operating system version: 11.2
Google Maps SDK for iOS version: 2.5.30219
Hardware model: iPhone X

Comments

an...@google.com <an...@google.com> #2Feb 2, 2018 11:31AM

Assigned to an...@google.com.

Can you provide the stack trace?

di...@google.com <di...@google.com> #3Feb 12, 2018 03:01PM

I think this console log would help:

Main Thread Checker: UI API called on a background thread: -[UIApplication applicationState]
PID: 31300, TID: 2413714, Thread name: com.google.Maps.LabelingBehavior, Queue name: com.apple.root.default-qos.overcommit, QoS: 21
Backtrace:
4 GooglePlacePickerDemos 0x00000001069bbef4 GMSIsApplicationInBackground + 53
5 GooglePlacePickerDemos 0x0000000106a5a5ea -[GMSForegroundDispatchQueue initWithName:targetQueue:] + 237
6 GooglePlacePickerDemos 0x0000000106a271a2 _ZN7gmscore6vector4text8GlyphSetC2ERKNS_4base10reffed_ptrINS0_16TextureAtlasPoolEEEPU28objcproto17OS_dispatch_queue8NSObjectPK8__CTFontff + 344
7 GooglePlacePickerDemos 0x0000000106a1967a _ZN7gmscore6vector4text10GlyphCache11GetGlyphSetEPK8__CTFontf + 214
8 GooglePlacePickerDemos 0x0000000106a17dce _ZN7gmscore6vector4text6GLText14PrefetchGlyphsERKNS_4base10reffed_ptrINS1_10GlyphCacheEEERKNSt3__16vectorItNS9_9allocatorItEEEEPK8__CTFontf + 22
9 GooglePlacePickerDemos 0x0000000106a17ed1 _ZN7gmscore6vector4text6GLText14PrefetchGlyphsERKNS_4base10reffed_ptrINS1_10GlyphCacheEEEPK8__CTLinebf + 207
10 GooglePlacePickerDemos 0x00000001069fdc4f _ZN7gmscore6vector12GLPointLabel22PrefetchGlyphsForGroupEPNS0_12GLLabelGroupE + 181
11 GooglePlacePickerDemos 0x00000001069fdb77 _ZN7gmscore6vector12GLPointLabel14PrefetchGlyphsEv + 33
12 GooglePlacePickerDemos 0x0000000106a12143 _ZN7gmscore6vector16LabelingBehavior23CreatePendingOperationsERKNSt3__13setINS_4base10reffed_ptrINS0_7GLLabelEEENS2_4lessIS7_EENS2_9allocatorIS7_EEEESE_SE_NS0_13LabelDrawModeE + 1093
13 GooglePlacePickerDemos 0x0000000106a11b11 _ZN7gmscore6vector16LabelingBehavior14RunLabelingJobERKNS_4base10reffed_ptrINS1_11LabelingJobEEE + 357
14 GooglePlacePickerDemos 0x0000000106a1199e ___ZN7gmscore6vector16LabelingBehavior14CommitInternalEPNS_8renderer14EntityRendererE_block_invoke + 22
15 Foundation 0x000000010ae37ff8 __NSThreadPerformPerform + 334
16 CoreFoundation 0x000000010ba28ef1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
17 CoreFoundation 0x000000010bac8011 __CFRunLoopDoSource0 + 81
18 CoreFoundation 0x000000010ba0d8e9 __CFRunLoopDoSources0 + 185
19 CoreFoundation 0x000000010ba0cecf __CFRunLoopRun + 1279
20 CoreFoundation 0x000000010ba0c759 CFRunLoopRunSpecific + 409
21 Foundation 0x000000010adf245e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 274
22 GooglePlacePickerDemos 0x0000000106a4feb9 -[GMSx_GTMSimpleWorkerThread main] + 337
23 Foundation 0x000000010adffedc __NSThread__start__ + 1197
24 libsystem_pthread.dylib 0x000000010cfeb93b _pthread_body + 180
25 libsystem_pthread.dylib 0x000000010cfeb887 _pthread_body + 0
26 libsystem_pthread.dylib 0x000000010cfeb08d thread_start + 13
2017-08-09 22:14:34.392200+0530 GooglePlacePickerDemos[31300:2413714] [reports] Main Thread Checker: UI API called on a background thread: -[UIApplication applicationState]
PID: 31300, TID: 2413714, Thread name: com.google.Maps.LabelingBehavior, Queue name: com.apple.root.default-qos.overcommit, QoS: 21
Backtrace:
4 GooglePlacePickerDemos 0x00000001069bbef4 GMSIsApplicationInBackground + 53
5 GooglePlacePickerDemos 0x0000000106a5a5ea -[GMSForegroundDispatchQueue initWithName:targetQueue:] + 237
6 GooglePlacePickerDemos 0x0000000106a271a2 _ZN7gmscore6vector4text8GlyphSetC2ERKNS_4base10reffed_ptrINS0_16TextureAtlasPoolEEEPU28objcproto17OS_dispatch_queue8NSObjectPK8__CTFontff + 344
7 GooglePlacePickerDemos 0x0000000106a1967a _ZN7gmscore6vector4text10GlyphCache11GetGlyphSetEPK8__CTFontf + 214
8 GooglePlacePickerDemos 0x0000000106a17dce _ZN7gmscore6vector4text6GLText14PrefetchGlyphsERKNS_4base10reffed_ptrINS1_10GlyphCacheEEERKNSt3__16vectorItNS9_9allocatorItEEEEPK8__CTFontf + 22
9 GooglePlacePickerDemos 0x0000000106a17ed1 _ZN7gmscore6vector4text6GLText14PrefetchGlyphsERKNS_4base10reffed_ptrINS1_10GlyphCacheEEEPK8__CTLinebf + 207
10 GooglePlacePickerDemos 0x00000001069fdc4f _ZN7gmscore6vector12GLPointLabel22PrefetchGlyphsForGroupEPNS0_12GLLabelGroupE + 181
11 GooglePlacePickerDemos 0x00000001069fdb77 _ZN7gmscore6vector12GLPointLabel14PrefetchGlyphsEv + 33
12 GooglePlacePickerDemos 0x0000000106a12143 _ZN7gmscore6vector16LabelingBehavior23CreatePendingOperationsERKNSt3__13setINS_4base10reffed_ptrINS0_7GLLabelEEENS2_4lessIS7_EENS2_9allocatorIS7_EEEESE_SE_NS0_13LabelDrawModeE + 1093
13 GooglePlacePickerDemos 0x0000000106a11b11 _ZN7gmscore6vector16LabelingBehavior14RunLabelingJobERKNS_4base10reffed_ptrINS1_11LabelingJobEEE + 357
14 GooglePlacePickerDemos 0x0000000106a1199e ___ZN7gmscore6vector16LabelingBehavior14CommitInternalEPNS_8renderer14EntityRendererE_block_invoke + 22
15 Foundation 0x000000010ae37ff8 __NSThreadPerformPerform + 334
16 CoreFoundation 0x000000010ba28ef1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
17 CoreFoundation 0x000000010bac8011 __CFRunLoopDoSource0 + 81
18 CoreFoundation 0x000000010ba0d8e9 __CFRunLoopDoSources0 + 185
19 CoreFoundation 0x000000010ba0cecf __CFRunLoopRun + 1279
20 CoreFoundation 0x000000010ba0c759 CFRunLoopRunSpecific + 409
21 Foundation 0x000000010adf245e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 274
22 GooglePlacePickerDemos 0x0000000106a4feb9 -[GMSx_GTMSimpleWorkerThread main] + 337
23 Foundation 0x000000010adffedc __NSThread__start__ + 1197
24 libsystem_pthread.dylib 0x000000010cfeb93b _pthread_body + 180
25 libsystem_pthread.dylib 0x000000010cfeb887 _pthread_body + 0
26 libsystem_pthread.dylib 0x000000010cfeb08d thread_start + 13

fu...@gmail.com <fu...@gmail.com> #4Feb 13, 2018 08:10PM

deleted

an...@google.com <an...@google.com> #5Mar 7, 2018 11:52AM

Reassigned to di...@google.com.

Just wanted to add the this problem is still present in the GM version of Xcode 9

di...@google.com <di...@google.com> #6Mar 12, 2018 08:46AM

Accepted by di...@google.com.

We believe that this issue should be solved in the Maps iOS SDK v2.5 release. If this issue still occurs, please let us know.

fu...@gmail.com <fu...@gmail.com> #7Apr 9, 2018 05:05PM

Btw, the position is also incorrect on iPad.

di...@google.com <di...@google.com> #8May 3, 2018 02:13PM

Marked as fixed.

This issue should be fixed in v2.7

fu...@gmail.com <fu...@gmail.com> #9May 4, 2018 01:00PM

Yes it is. Thanks.