Verified
Status Update
Comments
cc...@google.com <cc...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha07
androidx.compose.material3:material3-android:1.4.0-alpha07
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha07
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha07
cc...@google.com <cc...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <
Link:
Update the TwoRowsTopAppBar API
Expand for full commit details
Update the TwoRowsTopAppBar API
- Update the API to the feedback from the API council.
- Remove the `expanded` lambda parameter and have a separate params for
the expanded and collapsed heights.
Test: Updated
Bug: 306697446
Bug: 229134133
Bug: 268068946
Fixes: 394144086
Relnote: "Updates to the TowRowsTopAppBar API. We removed the `expanded`
lambda parameters and added separate parameters for the expanded and
collapsed heights."
Change-Id: Idd6777bc381871b9e77c040762c6bca7355cda8a
Files:
- M
compose/material3/material3/api/current.txt
- M
compose/material3/material3/api/restricted_current.txt
- M
compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/AppBarSamples.kt
- M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/AppBarTest.kt
- M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
Hash: e414ed68307128f55615f1e482bee2212677098c
Date: Thu Feb 06 13:54:36 2025
Description
Version used: 1.0.0-alpha5
Devices/Android versions reproduced on: n/a
A PagedList has access to the DataSource that we supply to page against. Admittedly, in the current PagedList implementation, that is buried under some wrapper layers.
Some DataSource implementations may require us to clean them up when we are done with them (e.g., to avoid garbage collection issues). When we are done with a PagedList, in many cases we are done with the DataSource backing that PagedList. It stands to reason that we should be able to retrieve our DataSource from the PagedList in order to be able to clean it up (e.g., call some close() method).
Thanks for considering this!