Fixed
Status Update
Comments
jh...@google.com <jh...@google.com>
jh...@google.com <jh...@google.com> #2
This bug should go to the emulator team. However, I do not have permission to file bug against them yet.
di...@google.com <di...@google.com> #3
Thank you for reporting this. I think we have a bad race condition in RecurrentTask
. When a callback fires, the QEMUTimer
is empty (see cb(opaque)
is unlock):
/* remove timer from the list before calling the callback */
timer_list->active_timers = ts->next;
ts->next = NULL;
ts->expire_time = -1;
cb = ts->cb;
opaque = ts->opaque;
/* run the callback (the timer list can be modified) */
qemu_mutex_unlock(&timer_list->active_timers_lock);
cb(opaque);
qemu_mutex_lock(&timer_list->active_timers_lock);
and timer_del_locked
simply removes the QEMUTimer
instance from the active_timers
list. I am not sure how to avoid race conditions here. Consider this:
1: void myCallback(void* arg) {
2:
3: someCall();
4:
5: }
- The control enters into
myCallback
and the thread is preempted before the function had a chance making any side effect (line2
here). ËœRecurrentTask
is called on a separate thread.- Since
myCallback
did not write anywhere that it is busyËœRecurrentTask
proceeds destroying the statemyCallback
is about to access. myCallback
wakes and proceeds accessing already destroyed data.
Either I am missing something or this API is incomplete.
av...@google.com <av...@google.com> #4
di...@google.com <di...@google.com> #5
The opt-out period will end on October 31st. Your app will only get the updated basemap style after that.
lm...@google.com <lm...@google.com> #6
The opt-out period has ended as of November 1st. Your app will now only get the updated basemap stye.
Updated Release Notes are available at:https://developers.google.com/maps/documentation/ios-sdk/releases
Updated Release Notes are available at:
Description
This transition will happen in several steps, with an opt-in period (defaulting to the previous style) and an opt-out period (defaulting to the new style) before the new style is applied on all iOS apps.
For the Google Maps SDK for iOS, these milestones are as follows:
Opt-in period: starting in early February 2018.
Opt-out period: around May 2018.
End of opt-out period: around August 2018.
The instructions to opt-in and opt-out will be included Google Maps SDK for iOS release notes [2] at the release times mentioned above. The opt-in and opt-out features will consist of a small update in your app's GMSServices [3] configuration.
We will keep this issue updated as we approach milestones.
[1]:
[2]:
[3]: